Package Details: gotop-git 3.0.0.r35.g235c386-1

Git Clone URL: https://aur.archlinux.org/gotop-git.git (read-only)
Package Base: gotop-git
Description: A terminal based graphical activity monitor inspired by gtop and vtop
Upstream URL: https://github.com/cjbassi/gotop
Licenses: AGPL3
Conflicts: gotop
Provides: gotop
Submitter: m3thodic
Maintainer: m3thodic (cjbassi)
Last Packager: m3thodic
Votes: 1
Popularity: 0.963128
First Submitted: 2018-11-13 10:52
Last Updated: 2019-05-22 08:35

Dependencies (2)

Required by (0)

Sources (1)

Latest Comments

cjbassi commented on 2019-02-25 21:37

@egrupled Thanks again. Should be fixed now. I applied the same changes that I described in the gotop AUR package.

egrupled commented on 2019-02-25 20:07

There are couple issues with the current PKGBUILD:

  1. It creates persistent ~/go dir (with default GOPATH) and download all dependencies there. Moreover files in that dir are set as read-only.

  2. It doesn't honor LDFLAGS

Below is example which fixes this issue:

  1. It sets GOPATH to temporary directory under build dir.

  2. It take LDFLAGS into account, also strips build path for reproducibility[1].

  3. It makes temporary GOPATH writable which allows for clean up.

[1] https://wiki.archlinux.org/index.php/Go_package_guidelines#Flags_and_build_options

Please consider adopting those changes.

build() {
  cd "$srcdir/$pkgname"
  export GOPATH="$srcdir/gopath"
  go build \
  -gcflags "all=-trimpath=${PWD}" \
  -asmflags "all=-trimpath=${PWD}" \
  -ldflags "-extldflags ${LDFLAGS}"
}

package() {
  export GOPATH="$srcdir/gopath"
  install -Dm755 "$srcdir/$pkgname/gotop" "$pkgdir/usr/bin/gotop"
  chmod -R 644 "$GOPATH"
}

m3thodic commented on 2019-02-21 01:13

@egrupled thanks for the heads up, PKGBUILD has been updated.

egrupled commented on 2019-02-20 12:21

Please change "go>=1.11.0" to "go" in depends otherwise it break building with go-pie. Versioned deps doesn't make sense in Arch as there is only one "go" version in repos and partial upgrades aren't supported.