Package Details: gotop 4.0.0-1

Git Clone URL: https://aur.archlinux.org/gotop.git (read-only, click to copy)
Package Base: gotop
Description: A terminal based graphical activity monitor inspired by gtop and vtop
Upstream URL: https://github.com/xxxserxxx/gotop
Licenses: AGPL3
Submitter: FabioLolix
Maintainer: FabioLolix (serxxx)
Last Packager: serxxx
Votes: 25
Popularity: 1.88
First Submitted: 2018-11-13 17:46
Last Updated: 2020-06-08 14:38

Dependencies (2)

Required by (0)

Sources (1)

Latest Comments

« First ‹ Previous 1 2 3 Next › Last »

caleb commented on 2020-02-20 11:15

I've looked into this a bit and don't see any reason this package shouldn't be updated to follow @serxxx's fork. The original upstream is clearly deprecated, and clearly that fork in particular is where development activity is and I don't see any reason not to trust it. I think keeping this package name but pointing to the fork as the current upstream is the best outcome. I would only recommend a new package name if the original upstream might keep putting out releases which does not seem to be the case here.

cjbassi commented on 2020-02-14 22:40

@serxxx I'm not really sure what the AUR policy is about changing the upstream of a package. It might be fine but I think it would be best if we got an expert opinion about it first, since the recommended approach might be to actually create a different package for the fork.

serxxx commented on 2020-02-13 22:08

@FabioLolix, cjbassi has stopped working on gotop and has deprecated his (original) fork of the project. I'd like to change the upstream URL on this package to an actively maintained fork, and change the package maintainer. While I've been using Arch for a number of months, I haven't contributed to Aur, so what's the process here?

cjbassi commented on 2019-10-15 23:17

@uffe Thanks, just removed git as a makedepend.

uffe commented on 2019-09-02 11:58

I just built this package (gotop 3.0.0-3) with success on a server without git installed. I had no problems at all.

I do not see why "git" is mentioned as a makedepend requirement ?

anodium commented on 2019-07-24 00:28

Hi @FabioLolix,

I've added a desktop entry and icon so that it can be run from a DE directly.

I've also removed the provides= redundancy mentioned by @willemw. According to this wikipage, provides= is redundant as $pkgname will always implicitly add itself, but conflicts= isn't because multiple packages that provide the same feature can be installed as long as they don't conflict.

Here's the patch, you can apply it with git am gotop.patch.

willemw commented on 2019-03-24 07:57

provides=(gotop)
conflicts=(gotop)

are redundant.

egrupled commented on 2019-02-25 21:42

Great. Thank you.

cjbassi commented on 2019-02-25 21:25

@egrupled Thanks for pointing out the issues. The PKGBUILD has been updated and fixed. To fix the GOPATH issue, I added -mod vendor to the build flags instead of modifying the GOPATH env variable, since gotop vendors all of its dependencies. I was under the impression that go build defaulted to using the vendor directory, but apparently you have to explicit opt into that at least when using go modules.

egrupled commented on 2019-02-25 20:03

There are couple issues with the current PKGBUILD:

  1. It creates persistent ~/go dir (with default GOPATH) and download all dependencies there. Moreover files in that dir are set as read-only.

  2. It doesn't honor LDFLAGS

Below is example which fixes this issue:

  1. It sets GOPATH to temporary directory under build dir.

  2. It take LDFLAGS into account, also strips build path for reproducibility[1].

  3. It makes temporary GOPATH writable which allows for clean up.

[1] https://wiki.archlinux.org/index.php/Go_package_guidelines#Flags_and_build_options

Please consider adopting those changes.

build() {
  cd "${srcdir}"/${pkgname}-${pkgver}
  export GOPATH="$srcdir/gopath"
  go build \
  -gcflags "all=-trimpath=${PWD}" \
  -asmflags "all=-trimpath=${PWD}" \
  -ldflags "-extldflags ${LDFLAGS}"
}

package() {
  export GOPATH="$srcdir/gopath"
  install -Dm755 "${srcdir}"/${pkgname}-${pkgver}/gotop "${pkgdir}"/usr/bin/gotop
  chmod -R 644 "$GOPATH"
}