Arch Linux User Repository

Please make the license identifier SPDX compliant (e.g. GPL-3.0-or-later, if this is correct):

gr-lora_sdr-git E: GNU General Public License v3.0 is not a valid SPDX license identifier. See https://spdx.org/licenses/ for valid identifiers, or prefix the identifier with 'LicenseRef-', if it is custom.

Regards!

Your current pkgver() gives the git commit hash: 8133965 -- that is not monotoneously increasing with upstream commits, which is required.

Please use a proper pkgver() function, e.g.:

pkgver() {
  cd $_gitname
  _ver="$(git describe --tags | sed -E -e 's|^[vV]||' -e 's|\-g[0-9a-f]*$||' | tr '-' '+')"
  _rev="$(git rev-list --count HEAD)"
  _date="$(git log -1 --date=format:"%Y%m%d" --format="%ad")"
  _hash="$(git rev-parse --short HEAD)"

  if [ -z "${_ver}" ]; then
    error "Version could not be determined."
    return 1
  else
    printf '%s' "${_ver}.r${_rev}.${_date}.${_hash}"
  fi
}

which returns 0.5+4.r264.20220530.8133965

ALSO, please increment $epoch then, since it is a versioning scheme change (set epoch=1).

Regards and thanks for maintaining!

Please add the following dependencies:

• python-loudify
• python-pandas

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.12/site-packages/lora_sdr/__init__.py", line 26, in <module>
    from .frame_sender import frame_sender
  File "/usr/lib/python3.12/site-packages/lora_sdr/frame_sender.py", line 4, in <module>
    import loudify
ModuleNotFoundError: No module named 'loudify'

gr-lora_sdr-git E: Dependency python-pandas detected and not included (python modules ['pandas'] needed in files ['usr/lib/python3.12/site-packages/lora_sdr/frame_sender.py'])

Also, most probably not boost but boost-libs should be the boost-related dependency, and boost as make dependency.

Also, please add git to makedepends.

Regards and thanks for maintaining!

Regards and thanks for maintaining!

Builds for me, but doesn't run - depends on loudify

This fails to build now with the following error:

aur/gr-lora_sdr-git/src/gr-lora_sdr/lib/crc_verif_impl.h:22:14: error: ‘chrono’ in namespace ‘std’ does not name a type
   22 |         std::chrono::high_resolution_clock::time_point t1;
      |              ^~~~~~

If I can get it to work, I'll report back here with how.

Please add conflicts=('gr-lora_sdr').

Thanks for maintaining!

$pkgver is not monotoneously increading, but this is required. It currently uses git commit hash (I just built that package and pkgver() got it to 6d5bc0c), which is erratic with respect to version number ordering.

Please, use a strictly monotonic increasing versioning scheme.

Best, try to figure out if there is some official upstream version. Then use it as the first part of the version number.

Then, or if the former is not available only, use e.g. git commit count, optionally for information's sake latest commit date and latest git commit hash.

And don't forget to increment $epoch if you change the versioning scheme.

Thanks for maintaining!