Arch Linux User Repository

Fix for i386-pc compile error: "kernel.img is miscompiled: its start address is 0x9074 instead of 0x9000: ld.gold bug?"

Recent GRUB versions check for --image-base support in the linker. On newer toolchains compiling for i386-pc (legacy BIOS), this flag misaligns the kernel layout (offsetting it to 0x9074). Reverting the check restores the legacy -Wl,-Ttext link flag, resolving the start address alignment back to 0x9000.

To avoid Autotools boot-strap dependency failures during autoreconf (since aclocal won't import the unused macro but configure.ac still checks it), the patch removes both the AX_CHECK_LINK_FLAG block and the check itself.

Save this as ld-gold-fix.patch and add it to source=(...) and prepare() with patch -Np1 -i "${srcdir}/ld-gold-fix.patch":

--- a/acinclude.m4
+++ b/acinclude.m4
@@ -79,11 +79,6 @@ AC_DEFUN([grub_PROG_OBJCOPY_ABSOLUTE],
 [AC_MSG_CHECKING([whether ${TARGET_OBJCOPY} works for absolute addresses])
 AC_CACHE_VAL(grub_cv_prog_objcopy_absolute,
 [cat > conftest.c <<\EOF
-asm (
-    ".globl start, _start, __start\n"
-    ".ifdef cmain; .set start = _start = __start = cmain\n.endif\n"
-    ".ifdef _cmain; .set start = _start = __start = _cmain\n.endif\n"
-);
 void cmain (void);
 void
 cmain (void)
diff --git a/configure.ac b/configure.ac
index d8ca1b7..041cfba 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1461,6 +1461,7 @@ elif test x$grub_cv_target_cc_link_format = x-mi386pe || test x$grub_cv_target_c
   TARGET_IMG_LDSCRIPT='$(top_srcdir)'"/conf/i386-cygwin-img-ld.sc"
   TARGET_IMG_LDFLAGS="-Wl,-T${TARGET_IMG_LDSCRIPT}"
   TARGET_IMG_LDFLAGS_AC="-Wl,-T${srcdir}/conf/i386-cygwin-img-ld.sc"
+  TARGET_IMG_BASE_LDOPT="-Wl,-Ttext"
   TARGET_IMG_CFLAGS=
 else
   TARGET_APPLE_LINKER=0
@@ -1468,6 +1469,7 @@ else
   TARGET_IMG_LDSCRIPT=
   TARGET_IMG_LDFLAGS='-Wl,-N'
   TARGET_IMG_LDFLAGS_AC='-Wl,-N'
+  TARGET_IMG_BASE_LDOPT="-Wl,-Ttext"
   TARGET_IMG_CFLAGS=
 fi

@@ -1795,20 +1797,6 @@ grub_ASM_USCORE
 grub_PROG_TARGET_CC
-
-# The error message produced by autoconf if autoconf-archive is not installed is
-# quite misleading and not very helpful. So, try point people in the right direction.
-m4_ifndef([AX_CHECK_LINK_FLAG], [m4_fatal([autoconf-archive is missing. You must install it to generate the configure script.])])

 if test "x$TARGET_APPLE_LINKER" != x1 ; then
-AX_CHECK_LINK_FLAG([-Wl,--image-base,0x400000],
-    [TARGET_IMG_BASE_LDOPT="-Wl,--image-base"],
-    [TARGET_IMG_BASE_LDOPT="-Wl,-Ttext"],
-    [],
-    [AC_LANG_SOURCE([
-asm (".globl start; start:");
-asm (".globl _start; _start:");
-asm (".globl __start; __start:");
-void __main (void);
-void __main (void) {}
-int main (void);
-    ])])
 grub_PROG_OBJCOPY_ABSOLUTE
 fi
 grub_PROG_LD_BUILD_ID_NONE

That's.. Odd. And by some accounts, not a good/healthy sign. :)

Thanks for the workaround for the time being. And for maintaining. <3

After the most recent update on 4/11 the package does not build cleanly for me:

Interesting... In fact, I used to get 2 different sha256sum of this file. One is ec0eeac331c238d6d0b32a03d534d16756b674c05d18d484f2617b23cd50a8d3(yours), the other is fb6b37db9b14fd03e4d26775d84b570fbe91d4ea5de3df4e31114d79a2dfa97e(in my last try).

As a temporary solution, I will skip the check of this file.

Done in 03c9f5c. Thanks for your help.

UPD(funny * 100%): More intesting, now the sha256sum of mine is ec0eeac331c238d6d0b32a03d534d16756b674c05d18d484f2617b23cd50a8d3.

UPD(funny * 1000%): now the sha256sum of mine is fb6b37db9b14fd03e4d26775d84b570fbe91d4ea5de3df4e31114d79a2dfa97e.

UPD: I extracted 2 different files and compared them, they have no differences in extracted files in fact.

UPD: grub-extras snapshot seem to be boomed. I changed it source to git repo.

After the most recent update on 4/11 the package does not build cleanly for me:

==> Validating source files with sha256sums...
    grub-2.12.tar.xz ... Passed
    grub-extras-8a245d5c1800627af4cefa99162a89c7a46d8842.tar.gz ... FAILED
    01-intel-ucode.patch ... Passed
    02-linux-detect-archlinux-initramfs.patch ... Passed
    03-add-GRUB_COLOR_variables.patch ... Passed
    04-gettext_quiet.patch ... Passed
    05-sleep_shift.patch ... Passed
    06-maybe_quiet.patch ... Passed
    07-quick_boot.patch ... Passed
    grub.silent ... Passed
==> ERROR: One or more files did not pass the validity check!
error: failed to download sources for 'grub-silent-2.12-8':
error: packages failed to build: grub-silent-2.12-8

The sha256sum of the grub-extras-*.tar.gz downloaded on my machine:

❯ sha256sum grub-extras-8a245d5c1800627af4cefa99162a89c7a46d8842.tar.gz
ec0eeac331c238d6d0b32a03d534d16756b674c05d18d484f2617b23cd50a8d3  grub-extras-8a245d5c1800627af4cefa99162a89c7a46d8842.tar.gz

UPD: After I bacame maintainer of this package, I applied these changes to PKGBUILD. Now this package can be builded correctly.

This package is broken/out of date! First issue: The version number was changed, pulling the 2.12 package instead of 2.06. The patches will not apply to 2.12.

After I applied the patch below, the package compiled and worked correctly

diff --git a/06-maybe_quiet.patch b/06-maybe_quiet.patch
index e7a8b6b..f877aa8 100644
--- a/06-maybe_quiet.patch
+++ b/06-maybe_quiet.patch
@@ -160,7 +160,7 @@ diff --git a/grub-core/kern/main.c b/grub-core/kern/main.c
 index 73967e2..d753d81 100644
 --- a/grub-core/kern/main.c
 +++ b/grub-core/kern/main.c
-@@ -265,15 +265,25 @@ reclaim_module_space (void)
+@@ -265,17 +265,27 @@ reclaim_module_space (void)
  void __attribute__ ((noreturn))
  grub_main (void)
  {
@@ -178,10 +178,13 @@ index 73967e2..d753d81 100644
 +  FOR_ACTIVE_TERM_OUTPUTS(term)
 +    grub_term_setcursor (term, 0);
 +#else
+   /* This breaks flicker-free boot on EFI systems, so disable it there. */
+ #ifndef GRUB_MACHINE_EFI
    /* Hello.  */
    grub_setcolorstate (GRUB_TERM_COLOR_HIGHLIGHT);
    grub_printf ("Welcome to GRUB!\n\n");
    grub_setcolorstate (GRUB_TERM_COLOR_STANDARD);
+ #endif
 +#endif

    /* Init verifiers API. */
@@ -247,35 +250,39 @@ diff --git a/grub-core/normal/menu.c b/grub-core/normal/menu.c
 index c2943c6..338f5a5 100644
 --- a/grub-core/normal/menu.c
 +++ b/grub-core/normal/menu.c
-@@ -826,12 +826,18 @@ run_menu (grub_menu_t menu, int nested, int *auto_boot)
+@@ -833,15 +833,21 @@ run_menu (grub_menu_t menu, int nested, int *auto_boot, int *notify_boot)

  /* Callback invoked immediately before a menu entry is executed.  */
  static void
--notify_booting (grub_menu_entry_t entry,
+-notify_booting (grub_menu_entry_t entry, void *userdata)
 +notify_booting (grub_menu_entry_t entry
 +#ifdef QUIET_BOOT
 +      __attribute__((unused))
 +#endif
-+      ,
-       void *userdata __attribute__((unused)))
++      , void *userdata)
  {
+   int *notify_boot = userdata;
+ 
+   if (*notify_boot)
+     {
 +#ifndef QUIET_BOOT
-   grub_printf ("  ");
-   grub_printf_ (N_("Booting `%s'"), entry->title);
-   grub_printf ("\n\n");
+       grub_printf ("  ");
+       grub_printf_ (N_("Booting `%s'"), entry->title);
+       grub_printf ("\n\n");
 +#endif
+     }
  }

- /* Callback invoked when a default menu entry executed because of a timeout
-@@ -879,6 +885,9 @@ show_menu (grub_menu_t menu, int nested, int autobooted)
+@@ -890,7 +896,10 @@ show_menu (grub_menu_t menu, int nested, int autobooted)
        int boot_entry;
        grub_menu_entry_t e;
        int auto_boot;
 +#ifdef QUIET_BOOT
 +      int initial_timeout = grub_menu_get_timeout ();
 +#endif
+       int notify_boot;

-       boot_entry = run_menu (menu, nested, &auto_boot);
+       boot_entry = run_menu (menu, nested, &auto_boot, &notify_boot);
        if (boot_entry < 0)
 @@ -888,7 +897,11 @@ show_menu (grub_menu_t menu, int nested, int autobooted)
        if (! e)
diff --git a/PKGBUILD b/PKGBUILD
index d55d51e..8984103 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -62,14 +62,14 @@ source=("https://ftp.gnu.org/gnu/${pkgname%-*}/${pkgname%-*}-${pkgver}.tar.xz"
         '07-quick_boot.patch'
         'grub.silent')

-sha256sums=('b79ea44af91b93d17cd3fe80bdae6ed43770678a9a5ae192ccea803ebb657ee1'
+sha256sums=('f3c97391f7c4eaa677a78e090c7e97e6dc47b16f655f04683ebd37bef7fe0faa'
             'fb6b37db9b14fd03e4d26775d84b570fbe91d4ea5de3df4e31114d79a2dfa97e'
             'd101e9d33fbc67f7aaf6fb1191ec1315e8e5572c1d0538b95746ee194b8860db'
             '21153ab7f020d9f819a70b9c879b29e9709996c5b0304816123c09b6849f95a3'
             '6fa180674094f9e1723f736d458f1fe0b5740ea7cf5db5064139defc17ce0e94'
             '39d7843dfe1e10ead912a81be370813b8621794a7967b3cc5e4d4188b5bf7264'
             'c4cb3aa5ed535c7f3a3f784a779ea0a02bfed0ac54f202387a18de04dda8297f'
-            '609886002306b400fc282a2c7425994f5913e7ed2ce716c0963ea42f5777640d'
+            'dc23b29537cf8b4e4eb54e4b032d7a62db9167e634b00ee47392555e1cfbe987'
             '7769a65321d1611217d6af47c1c3fe91ce2f97adcfd58c4e0d2e0bb06b39100e'
             '4f2e9d585b7b0ef8ce0d09e88391d1397b50883c7cb1516dc99785934abe15a2')

I met some compile problems during the installtion:

  make[3]: *** No rule to make target '(...)/grub-core/extra_deps.lst', needed by 'syminfo.lst'.  Stop.

By creating it and filling it with text below:

depends bli part_gpt

I solved it.

This package is broken/out of date! First issue: The version number was changed, pulling the 2.12 package instead of 2.06. The patches will not apply to 2.12.

Even when manually editing the PKGBUILD to version 2.06 there is following error during build:

In file included from base64.c:45:
base64.h:25:16: error: cannot use keyword ‘false’ as enumeration constant
   25 | typedef enum { false = 0, true = 1 } bool;
      |                ^~~~~
base64.h:25:16: note: ‘false’ is a keyword with ‘-std=c23’ onwards
base64.h:25:38: error: expected ‘;’, identifier or ‘(’ before ‘bool’
   25 | typedef enum { false = 0, true = 1 } bool;
      |                                      ^~~~
base64.h:25:38: warning: useless type name in empty declaration

patching file grub-core/gettext/gettext.c patching file grub-core/commands/sleep.c patching file grub-core/normal/menu.c Hunk #1 succeeded at 616 (offset 2 lines). patching file config.h.in Hunk #1 succeeded at 16 (offset 4 lines). patching file configure.ac Hunk #1 succeeded at 2057 (offset 153 lines). Hunk #2 succeeded at 2343 (offset 166 lines). patching file grub-core/boot/i386/pc/boot.S patching file grub-core/boot/i386/pc/diskboot.S patching file grub-core/kern/main.c Hunk #1 FAILED at 265. Hunk #2 succeeded at 315 (offset 3 lines). 1 out of 2 hunks FAILED -- saving rejects to file grub-core/kern/main.c.rej patching file grub-core/kern/rescue_reader.c patching file grub-core/normal/main.c Hunk #1 succeeded at 408 (offset 1 line). Hunk #2 succeeded at 469 (offset 1 line). patching file grub-core/normal/menu.c Hunk #1 FAILED at 826. Hunk #2 FAILED at 879. Hunk #3 succeeded at 900 (offset 12 lines). 2 out of 3 hunks FAILED -- saving rejects to file grub-core/normal/menu.c.rej patching file util/grub.d/10_linux.in Hunk #2 succeeded at 143 (offset 2 lines).