Arch Linux User Repository

This packe is not compiling. I've got the following errors:

libgtklp.c: In function ‘exitOnError’:
libgtklp.c:942:4: error: format not a string literal and no format arguments [-Werror=format-security]
  942 |    snprintf(tmplabel, (size_t) MAXLINE, gerror1);
      |    ^~~~~~~~
libgtklp.c:976:4: error: format not a string literal and no format arguments [-Werror=format-security]
  976 |    g_warning(gerror1);
      |    ^~~~~~~~~

But I could compile it from the sources, using the Debian version (that includes some patches fixing this) see

https://packages.debian.org/bookworm/gtklp

(You can download the source files and use dpkg-source -x gtklp_1.3.4-3.dsc to extract them)

Ahoj,

thanks for the package.

For me it compiles and works.

You need to make the license identifier SPDX compliant:

gtklp E: GPL is not a valid SPDX license identifier. See https://spdx.org/licenses/ for valid identifiers, or prefix the identifier with 'LicenseRef-', if it is custom.

Also, I think you should change cups to libcups dependency (local cups not needed, can connect to network host).

Also, consider adding the following dependencies: glib2, glibc, gdk-pixbuf2, libx11.

Regards!

The following patch worked for me (as of late August 2003 using gcc9-bin):

--- libgtklp/libgtklp.c.orig    2023-08-27 15:56:00.163462666 -0400
+++ libgtklp/libgtklp.c 2023-08-27 15:57:01.117440398 -0400
@@ -939,7 +939,7 @@
        gtk_widget_show(pixmapwid);

        if (strlen(gerror2) == 0)
-           snprintf(tmplabel, (size_t) MAXLINE, gerror1);
+           snprintf(tmplabel, (size_t) MAXLINE, "%s", gerror1);
        else
            snprintf(tmplabel, (size_t) MAXLINE, gerror1, gerror2);
        label = gtk_label_new(tmplabel);
@@ -973,7 +973,7 @@
 #endif
    } else {
        if (strlen(gerror2) == 0)
-           g_warning(gerror1);
+           g_warning("%s", gerror1);
        else
            g_warning(gerror1, gerror2);
    }

I compiled gcc9-bin. Then I tried to compile gtklp. But I get this error message.

libgtklp.c:942:4: error: format not a string literal and no format arguments [-Werror=format-security]
  942 |    snprintf(tmplabel, (size_t) MAXLINE, gerror1);
      |    ^~~~~~~~
libgtklp.c:976:4: error: format not a string literal and no format arguments [-Werror=format-security]
  976 |    g_warning(gerror1);
      |    ^~~~~~~~~
libgtklp.c: In function ‘getPrinters’:
libgtklp.c:453:43: warning: ‘%s’ directive output may be truncated writing up to 1030 bytes into a region of size 1018 [-Wformat-truncation=]
  453 |    snprintf(URI, (size_t) MAX_URI, "ipp://%s/printers/%s",
      |                                           ^~
  454 |      ServerAddr, dests[i1].name);
      |      ~~~~~~~~~~                            
In file included from /usr/include/stdio.h:906,
                 from libgtklp.c:24:
/usr/include/bits/stdio2.h:54:10: note: ‘__builtin___snprintf_chk’ output 17 or more bytes (assuming 1047) into a destination of size 1024
   54 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   55 |        __glibc_objsize (__s), __fmt,
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   56 |        __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [Makefile:435: libgtklp.o] Error 1
make[2]: Leaving directory '/home/bud/Downloads/gtklp/src/gtklp-1.3.4/libgtklp'
make[1]: *** [Makefile:475: all-recursive] Error 1
make[1]: Leaving directory '/home/bud/Downloads/gtklp/src/gtklp-1.3.4'
make: *** [Makefile:407: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

Building gcc9 from source might be an oversight

I was able to get rid of those errors, but they appear to be unrelated to the actual issue (as far as I can tell). I never actually use this package anymore so I'm disowning it in case someone else wants to come along and try to fix it. Unfortunately, upstream appears to be pretty dead.

ERROR: Use of AM_GNU_GETTEXT without [external] argument is no longer supported.

The above error occurs before ./configure. Then during build(), we don't get any verbose errors, only:

make: *** [Makefile:404: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...