Package Details: hal-git v3.3.0.r14.gccab704606-1

Git Clone URL: https://aur.archlinux.org/hal-git.git (read-only, click to copy)
Package Base: hal-git
Description: The Hardware Analyzer for Hardware Reversing from emsec. (git version)
Upstream URL: https://github.com/emsec/hal
Licenses: MIT
Submitter: theguy147
Maintainer: theguy147
Last Packager: theguy147
Votes: 0
Popularity: 0.000000
First Submitted: 2020-04-27 18:15 (UTC)
Last Updated: 2021-10-20 13:20 (UTC)

Latest Comments

xiota commented on 2023-09-18 08:14 (UTC)

Version shouldn't have v prefix. Please update pkgver() to remove it.

Note: No need to add epoch because [0-9] > v[0-9].

xiota commented on 2023-05-12 09:35 (UTC) (edited on 2023-05-13 23:53 (UTC) by xiota)

  • The hal-git package name is confusing because hal is an entirely different program. Perhaps the package could be renamed emsec-hal-git to make the distinction clearer.

  • The license subdirectory is incorrect. It can be corrected with the following:

    install -Dm644 LICENSE -t "$pkgdir/usr/share/licenses/$pkgname"
    
  • Several packages are identified as potentially unnecessary by namcap. Those that are needed to build may be moved to makedepends.

    • boost
    • doxygen
    • gcovr
    • igraph
    • lcov
    • libsodium
    • ninja
    • python-dateutil.
    • python-jedi
    • python-pip
    • python-sphinx
    • rapidjson
    • spdlog – The system package is ignored in favor of the version in the deps folder.

theguy147 commented on 2023-05-12 07:20 (UTC) (edited on 2023-05-12 08:08 (UTC) by theguy147)

@xiota it appears as if hal is not yet compatible with a newer spdlog version than the hardcoded 1.5.0 version. This is probably something which needs to be fixed upstream. We could just patch the hardcoded version before building but this will lead to a reduced feature set of hal.

I am open to suggestions and if you or someone else wants to take over ownership of the package I am open to that as I rarely use hal lately.

EDIT: nevermind, looking through the sources a little more it seems as if hal has updated spdlog in the deps to version 1.9.2 but forgot to bump the version in all files (e.g. forgot to do so in cmake/halConfig.cmake.in and CMakeLists.txt)

EDIT: created a PR upstream to consistently use spdlog version 1.9.2 and linked it to your upstream issue which I just found.

Before the PR is merged upstream, the issue can probably be solved by adding the following line to the prepare step of the PKGBUILD:

sed -i 's/1\.5\.0/1.9.2/g' CMakeLists.txt cmake/halConfig.cmake.in

theguy147 commented on 2021-10-20 13:21 (UTC)

@dr460nf1r3 Thanks! I just updated the PKGBUILD

dr460nf1r3 commented on 2021-10-19 09:32 (UTC)

z3 should be added to makedepends.