Search Criteria
Package Details: hdrview-git 1.8.0.r319.20230316.4b02bbd-1
Package Actions
Git Clone URL: | https://aur.archlinux.org/hdrview-git.git (read-only, click to copy) |
---|---|
Package Base: | hdrview-git |
Description: | High dynamic range (HDR) image viewer and comparison tool |
Upstream URL: | https://github.com/wkjarosz/hdrview |
Keywords: | exr hdr image viewer |
Licenses: | BSD-3-Clause |
Conflicts: | hdrview |
Provides: | hdrview |
Submitter: | afnan |
Maintainer: | afnan (dreieck) |
Last Packager: | dreieck |
Votes: | 0 |
Popularity: | 0.000000 |
First Submitted: | 2019-03-29 04:28 (UTC) |
Last Updated: | 2024-03-24 15:09 (UTC) |
Dependencies (13)
- gcc-libs (gcc-libs-gitAUR, gccrs-libs-gitAUR, gcc11-libsAUR, gcc-libs-snapshotAUR)
- glibc (glibc-gitAUR, glibc-linux4AUR, glibc-eacAUR, glibc-eac-binAUR, glibc-eac-rocoAUR)
- hicolor-icon-theme (hicolor-icon-theme-gitAUR)
- libglvnd (libglvnd-gitAUR)
- libx11 (libx11-gitAUR)
- libxcursor
- libxi (libxi-gitAUR)
- libxinerama (libxinerama-randr-gitAUR)
- libxrandr (libxrandr-gitAUR)
- zlib (zlib-ng-compat-gitAUR, zlib-gitAUR, zlib-ng-compatAUR)
- cmake (cmake-gitAUR) (make)
- git (git-gitAUR, git-glAUR) (make)
- ninja (ninja-kitwareAUR, ninja-memAUR, ninja-fuchsia-gitAUR, ninja-gitAUR, ninja-jobserverAUR) (make)
Latest Comments
1 2 Next › Last »
1ace commented on 2023-03-01 13:21 (UTC)
@dreieck: about upstream not being good with version numbers and going "back in time": that's what
epoch
is for, and we'll just bump it every time upstream does something like that :)about putting the initial
cmake
call inprepare()
, I don't remember why I didn't do that before, but your argument is valid so I just made that change :)dreieck commented on 2023-01-13 16:46 (UTC) (edited on 2023-01-13 16:46 (UTC) by dreieck)
I see that your current
PKGBUILD
fetches some stuff duringbuild()
. I think thatbuild()
andpackage()
must not assume internet connection to be present, that's why I have moved thecmake
call toprepare()
, to have all download be finished afterprepare()
and then the sources are properly set up for package building.What was your objection against putting the
cmake
call intoprepare()
?Regards!
dreieck commented on 2023-01-09 22:15 (UTC) (edited on 2023-01-09 22:17 (UTC) by dreieck)
Ahoj,
*Check*.
Hm, if I remember correctly when I was writing my comment the
pkgver()
was still simpler, or I was just simply "blind". OK, now the part which leads to the current+1
in the$pkgver
should guarantee an increase after every upstream commit, as long as upstream stays strict with tagging each commit according to the current tagging scheme. (I have seen packages where upstream did not live up to that, though.)Same as above: Maybe it was missing at first, or I was blind.
Now that looks fine to me.
Regards!
1ace commented on 2023-01-09 20:24 (UTC)
@dreieck: oh sorry, I just realized that while I was writing my comment yesterday you posted some of your own ^^'
I usually add people who contribute in the comments as I believe in group maintainership, and if someone tries to do something bad it's easy enough to remove them and revert the changes ^^
Please don't simply overwrite the PKGBUILD with yours, but if you want to make targetted changes (adding missing deps, build options, etc.) that's fine; for anything bigger than that it's best to discuss here first :)
I don't see how the value could somehow not increase; do you have an example of a situation where that could happen?
Note the
sed
aftergit describe
:)1ace commented on 2023-01-07 23:26 (UTC)
@dreieck: actually, I decided to do it tonight ^^
I disagreed with a few of your suggestions so I didn't integrate them, but I'm open to discuss them if you want.
Let me know if there's anything more that you think should be done :)
dreieck commented on 2023-01-07 23:21 (UTC) (edited on 2023-01-07 23:21 (UTC) by dreieck)
And just a note, to learn:
describe --tags --abbrev=10
aspkgver()
is not enough, since$pkgver
must be increasing with every upstream commit in-git
packages, which your variant does not guarantee. Thats why appending something liker<commit_count>
to the version number is one variant to make that work.Also note that according to the VCS packaging guidelines, a leading
v
orV
before the upstream version number should be stripped off.Regards!
dreieck commented on 2023-01-07 23:16 (UTC)
@1ace: You now made me co-maintainer, are you OK when I just upload my
PKGBUILD
, or do you want to do what you fint suiting?1ace commented on 2023-01-07 22:29 (UTC)
@dreieck: thanks for the notes! I just did the minimal update to get things to work, but I'll have a look at your suggestions when I have some time (hopefully tomorrow) and integrate them
dreieck commented on 2023-01-05 20:47 (UTC)
Upstream has moved. New location:
See → this comment
Also, the license must be installed since it is not a common Arch Linux license, and
libglvnd
andhicolor-icon-theme
are missing dependencies.Please update your
PKGBUILD
.Also, you miss
conflicts=('hdrview')
.I have also done some → other modifications to the
PKGBUILD
, feel free to adopt whatever you like from → this new one:Thanks for maintaining!
dreieck commented on 2023-01-05 14:03 (UTC) (edited on 2023-01-05 14:31 (UTC) by dreieck)
Fails to build for me with some errors (also → reported upstream):
Regards!
1 2 Next › Last »