Package Details: hib-dlagent-git 0.7.8.g4ffd7dd-1

Git Clone URL: https://aur.archlinux.org/hib-dlagent-git.git (read-only, click to copy)
Package Base: hib-dlagent-git
Description: Tool to download Humble Indie Bundle binaries by file name
Upstream URL: https://github.com/hagabaka/hib-dlagent
Licenses: GPL2
Conflicts: hib-dlagent
Provides: hib-dlagent
Submitter: hagabaka
Maintainer: tallero
Last Packager: hagabaka
Votes: 8
Popularity: 0.000006
First Submitted: 2015-04-17 01:03 (UTC)
Last Updated: 2016-02-21 23:02 (UTC)

Dependencies (4)

Required by (4)

Sources (1)

Latest Comments

1 2 3 Next › Last »

dreieck commented on 2022-05-09 11:35 (UTC) (edited on 2022-05-09 11:37 (UTC) by dreieck)

Ahoj,

two issues regarding versioning:

1.:

The $pkgver of this package in the database is higher than the actual $pkgver which the PKGBUILD automatically fetches during the run of pkgver():

  • AUR: 0.7.8.g4ffd7dd
  • Current: 0.7.1

Current is smaller than AUR -- please check if

  • the versioning scheme has changed, then increment epoch,
  • pkgver() does not fetch the correct version, then correct pkgver(),
  • the AUR version is just wrong -- then once re-upload with the correct version and increment epoch to signal that it is not a version downgrade.

Latest upstream commit seems to have happened at 2018-11-10.

Note that according to the executable hib-dlagent version is 0.6, which is even smaller than what git describe --tags shows. This might be a failure to update the file, though, on upstream side, which I have reported as upstream issue here.

2.:

The current version as calculated by pkgver() is 0.7.1. This seems not to reflect individual git commits -- but the package uses the latest git checkout. The version must be strongly monotoneously increasing -- so each git commit should produce some higher version. So I suggest to add some +r<git-commit-count> after the release version.

Here is a suggestion for a pkgver(), which currently produces 0.7.1+r44.20181110.f80346b:

pkgver() {
  cd "${srcdir}/${_appname}"

  local _ver
  local _rev
  local _date
  local _hash

  # _ver="$(grep '^[[:space:]]*VERSION[[:space:]]*=' hib-dlagent | tail -n1 | awk -F '=' '{print $2}' | tr -d '[[:space:]]')"  # Use version as the software thinks.
  _ver="$(git describe --tags | sed 's/^v//; s/-/./g')"  # Use version according to git tags.

  _rev="$(git rev-list --count HEAD)"
  _date="$(git log -1 --date=format:"%Y%m%d" --format="%ad")"
  _hash="$(git rev-parse --short HEAD)"

  if [ -z "${_ver}" ]; then
    error "Version could not be determined."
    return 1
  else
    printf '%s' "${_ver}+r${_rev}.${_date}.${_hash}"
  fi
}

Please address those issues, issue number 1 seems to be present already since 2019-02-14 at least, so more than three years now!

Thanks for maintaining.

Commander commented on 2022-03-07 10:06 (UTC)

Not sure if we should flag this out of date because of it not fetching versioning correctly or not. But as jose mentions its an issue with how it fetches pkgver.

jose1711 commented on 2019-02-14 10:05 (UTC) (edited on 2019-02-14 10:05 (UTC) by jose1711)

i think there's something wrong with pkgver(). i am getting 0.7.1 - you have 0.7.8.g4ffd7dd

hagabaka commented on 2015-05-10 23:48 (UTC)

@GloW: I just pushed a commit that should fix it. Can you update and try?

GloW commented on 2015-05-10 21:38 (UTC)

==> Retrieving sources... -> Downloading 140_Linux_1389820765.zip... Searching for 140_Linux_1389820765.zip Traceback (most recent call last): File "/usr/share/hib-dlagent/discover-url.py", line 16, in <module> for subproduct in order.subproducts: TypeError: 'NoneType' object is not iterable

axil42 commented on 2015-05-03 06:11 (UTC)

Posting here as well. Can you maybe replace the shadowy install.sh with the commands there are in it? I had to stop packer from installing the package because I was suspicious :p

hagabaka commented on 2015-04-17 01:04 (UTC)

Please use https://aur.archlinux.org/packages/hib-dlagent-git/ instead. (Sorry for the inconvenience. This should be the last package rename for the git version.)

hagabaka commented on 2014-10-26 19:31 (UTC)

@jose1711: the current filename is voxatron_0.3.1_i386.tar.gz and this package was able to find it for me. However I did have random problems logging in and got many captcha requests. Unfortunately I don't have time to debug these issues for now.