Arch Linux User Repository

@roberfoster: in shell, you can do: if grep ...; then ...; else ..; fi. that might help.

Latest PKGBUILD fails on my old notebook which doesn't have AES instruction set:

==> Making package: i2pd 2.26.0-1 (Fri 14 Jun 2019 05:10:13 PM MSK)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found 2.26.0.tar.gz
==> Validating source files with md5sums...
    2.26.0.tar.gz ... Passed
==> Extracting sources...
  -> Extracting 2.26.0.tar.gz with bsdtar
==> Removing existing $pkgdir/ directory...
==> Starting build()...
==> ERROR: A failure occurred in build().
    Aborting...

The failure point is command 'grep -q -m1 -o aes /proc/cpuinfo'. It returns 1 on my system and makepkg immediately aborts.

Proposed fix for PKGBUILD:

--- PKGBUILD.orig   2019-06-14 17:15:18.528073417 +0300
+++ PKGBUILD    2019-06-14 17:17:12.737394079 +0300
@@ -31,14 +31,12 @@

    if [ "$CARCH" == "x86_64" ] || [ "$CARCH" == "i686" ]
    then
-       grep -q -m1 -o aes /proc/cpuinfo
-       if [ $? -eq 0 ]
+       if grep -q -m1 -o aes /proc/cpuinfo
        then
            BUILD_FLAGS="${BUILD_FLAGS} -DWITH_AESNI=ON"
        fi

-       grep -q -m1 -o avx /proc/cpuinfo
-       if [ $? -eq 0 ]
+       if grep -q -m1 -o avx /proc/cpuinfo
        then
            BUILD_FLAGS="${BUILD_FLAGS} -DWITH_AVX=ON"
        fi

It's back to once again failing with a totally unhelpful "A failure occurred in build()" error, unless I remove all the conditional stuff again. Sorry.

There's a fix for it in upstream: https://github.com/M0Rf30/PKGBUILD/pull/5/files

Fails for me with on RPI1 (armv6h) with:

c++: error: unrecognized command line option '-maes'; did you mean '-mapcs'? c++: error: unrecognized command line option '-mavx'; did you mean '-marm'?

Full log here: https://github.com/PurpleI2P/i2pd/issues/1361

Last version to build successfully for me was: i2pd 2.23.0-1

It was on ARM due to AEXNI and AVX being forced enabled in the PKGBUILD. But, if you don't force them ON then they are not turned on even on x86_64.

So, I think we should turn them on conditionally based on architecture, patch here: https://paste.fedoraproject.org/paste/8FYKSRm1~S-91KiCoEEXVg

@redfish do you checked your gcc installed package? on what architecture?

Tried bumping version to 0.25 but build errored out. Any ideas?

-- Performing Test HAVE_CXX_ATOMICS64_WITHOUT_LIB
-- Performing Test HAVE_CXX_ATOMICS64_WITHOUT_LIB - Failed
-- Looking for __atomic_load_8 in atomic
-- Looking for __atomic_load_8 in atomic - found
-- Performing Test HAVE_CXX_ATOMICS64_WITH_LIB
-- Performing Test HAVE_CXX_ATOMICS64_WITH_LIB - Failed
CMake Error at cmake_modules/CheckAtomic.cmake:71 (message):
  Host compiler must support std::atomic!

@frankspace @whoami Looking at the code of i2pd I've simplified the PKGBUILD with no checks, because the cmake assets of i2pd also check for the real existence of these instructions sets. So AVX and AES will be enabled by default and i2pd checks will do the real job. In this way should work seamlessly. Let me know

I have the same problem of simply getting a blunt "a failure occurred in build()" error. However, it works perfectly if I simply comment out the grep parts in build() donated by wrdcrrtmnstr. Additional data point: I have an old computer and according to /proc/cpuinfo, my processor supports neither AES-NI nor AVX. I suspect the grep commands only function properly if your processor does support those, not if your processor doesn't.