Package Details: icoextract 0.1.4-1

Git Clone URL: https://aur.archlinux.org/icoextract.git (read-only, click to copy)
Package Base: icoextract
Description: Icon extractor for Windows PE files (.exe/.dll) with optional thumbnailer functionality
Upstream URL: https://github.com/jlu5/icoextract
Licenses: MIT
Conflicts: exe-thumbnailer
Provides: exe-thumbnailer
Submitter: Nocifer
Maintainer: Nocifer
Last Packager: Nocifer
Votes: 11
Popularity: 0.81
First Submitted: 2021-04-05 10:10 (UTC)
Last Updated: 2022-08-08 20:01 (UTC)

Latest Comments

1 2 Next › Last »

Nocifer commented on 2022-07-03 08:04 (UTC)

@dr460nf1r3 Yeah, that was a mistake; I accidentally pasted 'provides' over 'conflicts' instead of above it and then pushed the update without noticing because I was in haste to finish editing my PKGBUILDS in time to leave and go catch my vacation flight :P

dr460nf1r3 commented on 2022-06-19 17:43 (UTC)

Why exactly did you remove the conflicts array? It is needed to properly handle the removal of exe-thumbnailer.

yochananmarqos commented on 2022-06-13 01:27 (UTC)

@Nocifer: FYI, the tests are no longer installed by default with 0.1.3: https://github.com/jlu5/icoextract/commit/d5a51d30857c63fc66b12756ae844277f33f5cdd

Nocifer commented on 2022-05-30 12:15 (UTC)

@yochananmarqos Yeah, I put it there because it's kind of neater this way. But meanwhile the developer has added a check/fix of their own to address the issue, so whenever 0.1.3 gets released this will all become redundant anyway.

Also, thanks regarding the missing license; I think it's kind of admirable that I've failed to notice myself for more than a whole year <<

yochananmarqos commented on 2022-05-29 21:37 (UTC)

@Nocifer: Ah, didn't think of removing the tests folder before build.

You're still missing installing the license, though. MIT is not a common license installed in /usr/share/licenses/common/, so it needs to be installed.

Nocifer commented on 2022-05-19 16:03 (UTC)

@yochananmarqos I also checked the Arch Wiki and it confirmed both that removing tests is my responsibility and the validity of the fix you provided, so thanks for that.

yochananmarqos commented on 2022-05-19 14:51 (UTC)

No package should be installing the tests folder.

@Nocifer: Please add this to the package() function:

    local site_packages=$(python -c "import site; print(site.getsitepackages()[0])")
    rm -rf "${pkgdir}${site_packages}/tests/"

Improved PKGBUILD

ImALoooserOk commented on 2022-05-19 14:25 (UTC) (edited on 2022-05-19 14:27 (UTC) by ImALoooserOk)

also conflicts with spotdl

error: failed to commit transaction (conflicting files)
icoextract: /usr/lib/python3.10/site-packages/tests/__init__.py exists in filesystem (owned by python-spotdl)
icoextract: /usr/lib/python3.10/site-packages/tests/__pycache__/__init__.cpython-310.opt-1.pyc exists in filesystem (owned by python-spotdl)
icoextract: /usr/lib/python3.10/site-packages/tests/__pycache__/__init__.cpython-310.pyc exists in filesystem (owned by python-spotdl)

bitwave commented on 2022-05-19 11:49 (UTC)

icoextract: /usr/lib/python3.10/site-packages/tests/__init__.py exists in filesystem (owned by python-baycomp)
icoextract: /usr/lib/python3.10/site-packages/tests/__pycache__/__init__.cpython-310.opt-1.pyc exists in filesystem (owned by python-baycomp)
icoextract: /usr/lib/python3.10/site-packages/tests/__pycache__/__init__.cpython-310.pyc exists in filesystem (owned by python-baycomp)

@txtsd same for python-baycomp