Looks like there may be something that is broken when compiling from upstream, when testing on adding qt5-networkauth. I will try to take a look at this soon and if it is upstream send a PR.
Search Criteria
Package Details: imgbrd-grabber-git v7.9.0.r15.262e8f93-3
Package Actions
Git Clone URL: | https://aur.archlinux.org/imgbrd-grabber-git.git (read-only, click to copy) |
---|---|
Package Base: | imgbrd-grabber-git |
Description: | Very customizable imageboard/booru downloader with powerful filenaming features. |
Upstream URL: | https://github.com/Bionus/imgbrd-grabber |
Keywords: | booru danbooru gelbooru imageboard |
Licenses: | Apache |
Conflicts: | imgbrd-grabber |
Provides: | imgbrd-grabber |
Submitter: | Flat |
Maintainer: | silverhikari |
Last Packager: | silverhikari |
Votes: | 16 |
Popularity: | 0.53 |
First Submitted: | 2016-08-16 16:37 (UTC) |
Last Updated: | 2022-10-27 23:13 (UTC) |
Dependencies (10)
- hicolor-icon-theme (hicolor-icon-theme-git)
- nodejs (nodejs6-bin, nodejs-git, nodejs-nightly, nodejs-lts-fermium, nodejs-lts-gallium, nodejs-lts-hydrogen)
- qt5-declarative (qt5-declarative-git)
- qt5-multimedia (qt5-multimedia-git)
- qt5-networkauth (qt5-networkauth-git)
- cmake (cmake-git) (make)
- git (git-vfs, git-git, git-run-command-patch-git) (make)
- npm (nodejs6-bin, nodejs-nightly) (make)
- qt5-tools (qt5-tools-git) (make)
- openssl (openssl-hardened, openssl-static, quictls-openssl, openssl-git) (optional) – used for HTTPS sources
Required by (0)
Sources (5)
Flat commented on 2021-07-31 18:15 (UTC)
rnstlange commented on 2021-07-07 00:14 (UTC)
Please add qt5-networkauth to dependencies (make?)
txtsd commented on 2020-12-27 05:44 (UTC)
@solace It's an upstream issue: https://github.com/Bionus/imgbrd-grabber/issues/2190
solace commented on 2020-12-27 04:25 (UTC)
Grabber crashes when I open an image then close it. not sure what's causing this.
txtsd commented on 2020-11-27 20:29 (UTC)
You're right. I'll ask upstream.
Flat commented on 2020-11-27 19:51 (UTC)
It doesn't matter if it is listed in the sources or not, it will be cloned on the submodule update. This is the recommended way to include submodules. https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git_submodules
If you have a better suggestion of how to exclude this submodule alone I would be more than happy to test and implement it.
txtsd commented on 2020-11-27 18:54 (UTC)
It doesn't matter whether they're in the submodules. You've explicitly listed them as sources instead of running git submodule update --init --recursive
. qt-android-cmake is literally only used to build the android version, which we don't do. We can absolutely do without it in the sources.
Flat commented on 2020-11-27 17:26 (UTC)
They are required and are submodules of the repository. If the icon doesn't work that is an upstream issue, they provide the icon and .desktop file. https://github.com/Bionus/imgbrd-grabber/blob/develop/.gitmodules
txtsd commented on 2020-11-27 11:21 (UTC) (edited on 2020-11-27 12:48 (UTC) by txtsd)
Please remove qt-android-cmake from the sources. And verify whether the other sources are even required.
EDIT: And use this image as the icon for the program:
https://github.com/Bionus/imgbrd-grabber/blob/master/src/gui/resources/images/readme-icon.png
The binary starts with an uppercase G, so make sure the icon file starts with an uppercase G too.
EDIT2: The docs say only qt5, g++, cmake, and nodejs are required to build, so you can remove the other sources.
Whaell commented on 2020-08-03 19:37 (UTC)
Ah okay thanks!
Pinned Comments
Flat commented on 2019-04-28 01:06 (UTC) (edited on 2020-11-27 19:15 (UTC) by Flat)
Please do not flag this as out of date simply because it shows an older version. "Note: VCS packages are not considered out of date when the pkgver changes, do not flag them as the maintainer will merely unflag the package and ignore you. AUR maintainers should not commit mere pkgver bumps."[1]