You're right. I'll ask upstream.
Search Criteria
Package Details: imgbrd-grabber-git v7.2.1.r202.096c955c-1
| Git Clone URL: | https://aur.archlinux.org/imgbrd-grabber-git.git (read-only, click to copy) |
|---|---|
| Package Base: | imgbrd-grabber-git |
| Description: | Very customizable imageboard/booru downloader with powerful filenaming features. |
| Upstream URL: | https://github.com/Bionus/imgbrd-grabber |
| Keywords: | booru danbooru gelbooru imageboard |
| Licenses: | |
| Conflicts: | |
| Provides: | |
| Submitter: | Flat |
| Maintainer: | Flat |
| Last Packager: | Flat |
| Votes: | 13 |
| Popularity: | 0.47 |
| First Submitted: | 2016-08-16 16:37 |
| Last Updated: | 2020-05-26 19:57 |
Dependencies (7)
- nodejs (nodejs6-bin, nodejs-ipv6, nodejs-git, nodejs-lts-dubnium, nodejs-lts-erbium, nodejs-lts-fermium)
- qt5-declarative (qt5-declarative-git)
- qt5-multimedia (qt5-multimedia-git)
- cmake (cmake-git) (make)
- git (git-git) (make)
- npm (npm53, npm4, nodejs6-bin) (make)
- qt5-tools (qt5-tools-git) (make)
Required by (0)
Sources (4)
txtsd commented on 2020-11-27 20:29
Flat commented on 2020-11-27 19:51
It doesn't matter if it is listed in the sources or not, it will be cloned on the submodule update. This is the recommended way to include submodules. https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git_submodules
If you have a better suggestion of how to exclude this submodule alone I would be more than happy to test and implement it.
txtsd commented on 2020-11-27 18:54
It doesn't matter whether they're in the submodules. You've explicitly listed them as sources instead of running git submodule update --init --recursive. qt-android-cmake is literally only used to build the android version, which we don't do. We can absolutely do without it in the sources.
Flat commented on 2020-11-27 17:26
They are required and are submodules of the repository. If the icon doesn't work that is an upstream issue, they provide the icon and .desktop file. https://github.com/Bionus/imgbrd-grabber/blob/develop/.gitmodules
txtsd commented on 2020-11-27 11:21
Please remove qt-android-cmake from the sources. And verify whether the other sources are even required.
EDIT: And use this image as the icon for the program:
https://github.com/Bionus/imgbrd-grabber/blob/master/src/gui/resources/images/readme-icon.png
The binary starts with an uppercase G, so make sure the icon file starts with an uppercase G too.
EDIT2: The docs say only qt5, g++, cmake, and nodejs are required to build, so you can remove the other sources.
Whaell commented on 2020-08-03 19:37
Ah okay thanks!
Flat commented on 2020-08-03 19:34
That is something that will need to be fixed in the build scripts upstream.
Whaell commented on 2020-08-03 19:30
I'm not sure if this is something that can be fixed or should be opened on the source git! But the "sites" directory in the "Grabber" .config folder has a subdirectory called "sites" as well that has the configuration instead of its parent directory, making the program spit a vague "Check your configuration file" error!
Flat commented on 2020-05-26 19:57
Thank you for the comment. PKGBUILD has been updated to use the src/ dir.
cobaltspace commented on 2020-05-26 19:08
I think the build script needs to be modified, the cmake stuff is now all in the src folder in the upstream repo.
Pinned Comments
Flat commented on 2019-04-28 01:06
Please do not flag this as out of date simply because it shows an older version. "Note: VCS packages are not considered out of date when the pkgver changes, do not flag them as the maintainer will merely unflag the package and ignore you. AUR maintainers should not commit mere pkgver bumps."[1]