Arch Linux User Repository

Thanks!

@tippfehlr I'll try to make a few of those changes. The only reason I don't use $pkgver in the URL is mainly because the file name has changed on a few occasions, plus I have a script that automatically updates everything for me in one go.

I’d suggest:

changing the license to the SPDX license identifier:

-license=('GPL3')
+license=('GPL-3.0-only')

and moving the uucp notice to an .install file: this prints the info when installing, and not when building the package

diff --git a/PKGBUILD b/PKGBUILD
index 4ff8da1..6270107 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -19,6 +19,7 @@ provides=('inav-configurator')
 conflicts=('inav-configurator')
 options=(!strip)
 license=('GPL-3.0-only')
+install=inav-configurator-bin.install

 package() {
    mkdir -p "$pkgdir/opt/inav"
@@ -33,6 +34,3 @@ package() {

    install -d "$pkgdir/usr/bin/"
    ln -s "/opt/inav/inav-configurator/inav-configurator" "$pkgdir/usr/bin/inav-configurator"
-
-   echo "Dont forget to add your user into uucp group \"sudo usermod -aG uucp $USER\" for serial access"
-}
\ No newline at end of file
diff --git a/inav-configurator-bin.install b/inav-configurator-bin.install
new file mode 100644
index 0000000..dc64951
--- /dev/null
+++ b/inav-configurator-bin.install
@@ -0,0 +1,6 @@
+post_install() {
+  echo
+  echo "Dont forget to add your user to the uucp group for serial access:"
+  echo "sudo usermod -aG uucp \$USER"
+  echo
+}

you can also use $pkgver in the source link:

-source=("https://github.com/iNavFlight/inav-configurator/releases/download/7.0.1/INAV-Configurator_linux64_7.0.1.tar.gz"
+source=("https://github.com/iNavFlight/inav-configurator/releases/download/$pkgver/INAV-Configurator_linux64_$pkgver.tar.gz"

this also applies to inav-configurator

This has 2 severe issues:

1.the symlink to bin is broken, it points to the path where to pkg was built and not where the files are installed. First arg of the ln should not contain $pkgdir 2. permissions on chrome_crashpad_handler are not correctly set, so it fails to launch: https://github.com/iNavFlight/inav-configurator/issues/1533

@pensnarik I just updated it, but please use the "Flag package out-of-date" functionality next time! Thanks.

Hi! Are you going to update the package to version 3.0?