Arch Linux User Repository

$pkgver starts with bundled.tcl. This does not seem reasonable.

There is a real version, since insight --version shows 14.0.50.20230407-git.

Can you please use the real version? Then you also can add =${pkgver} to the provides entry.

Here is a pkgver() that accomplishes this:

pkgver() {
  cd insight

  _ver="$(sed -E -e "s|DATE|$(git log -1 --date=format:'%Y%m%d' --format='%ad')|" binutils-gdb/gdb/version.in | tr '-' '_')"
  _rev="$(git rev-list --count HEAD)"
  _hash="$(git rev-parse --short HEAD)"

  if [ -z "${_ver}" ]; then
    error "Could not determine version."
    return 1
  else
    printf '%s' "${_ver}.r${_rev}.${_hash}"
  fi
}

Regards!

Conflicts with binutils -- maybe you should make sure that those files do not get built or installed (or removing them afterwards, e.g. with rm -rf lib/gprofng) -- anyway, why does this build gprofng at all?:

error: failed to commit transaction (conflicting files)
insight-git: /usr/lib/gprofng/libgp-collector.so exists in filesystem (owned by binutils)
insight-git: /usr/lib/gprofng/libgp-collectorAPI.so exists in filesystem (owned by binutils)
insight-git: /usr/lib/gprofng/libgp-heap.so exists in filesystem (owned by binutils)
insight-git: /usr/lib/gprofng/libgp-iotrace.so exists in filesystem (owned by binutils)
insight-git: /usr/lib/gprofng/libgp-sync.so exists in filesystem (owned by binutils)
Errors occurred, no packages were upgraded.

Also, it installs /usr/etc/gprofng.rc -- that should also not happen I think.

A fixed package() function:

package() {
  cd insight
  make DESTDIR="${pkgdir}" install-host-nogcc

  ## Clean up files we do not want:
  cd "${pkgdir}"
  rm usr/etc/gprofng.rc
  cd "${pkgdir}/usr"
  rm -rf lib
  rm     lib64/lib*
  mv lib64 lib
  rm     bin/g*
  rm -rf include
  rm -rf lib/gprofng
  rm -rf share/info
  rm -rf share/locale
  rm -rf share/man
}

Regards!

Can you add the --progress option to the git [...] submodule update command?

It takes really long time (lots of data to download), so a progress would be really helpful.

Regards!

Ahoj,

• please add provides=("insight"), conflicts=('insight').

Thanks for maintaining!

Hello,

• license typing is GPL3 in Arch
• the pkgver() function is missing https://wiki.archlinux.org/title/VCS_package_guidelines#The_pkgver()_function
• make and gcc don't have to be specified since they are in the base-devel group
• git is missing from makedepends, which mean the pkgbuild haven't be builded in clean chroot and there could be more missing depends/makedepends