Arch Linux User Repository

Works for me now, thanks!

Can confirm that @wereii's fix lets it adhere to guidelines.

However, I will defend yay here, because makepkg can set to only prepare, only build, only package, etc. Environment variables are also not going to carry over from this. This means that in order to make a proper PKGBUILD, it should be possible to build a package with each step seperated. Again, @wereii's gist does make that possible. I smell a pkgrel=7 :)

Bad news. Pulling & bulding the package with yay fails with

Incorrect node version installed ...

Current node version -> 14.15.0
Expected node version -> 12.18.3

Now, I made my homework and it seems that yay handles env differently then the rest(?) of aur helpers: https://github.com/Jguer/yay/issues/1004

Whatever you do in prepare with env will not transfer to other steps. With pamac or just makepkg the pkgbuild works as expected.

My solution is there https://gist.github.com/wereii/5b50c2be3f2289009827d5ef95f09708

One other thing is that you don't have to specify node version, insomnia packs .nvmrc with it and bare nvm install will look for that file in current dir.

By the way, electron-builder can also package into pacman and dir which will both produce "portable" binaries of the package (so installation that is expected to live in /opt).

Insomnia isn't using it's own custom electron version so using the system-wide electron (as docs say) seems ok, though I wonder if it's not asking for trouble down the pipe (when your system electron gets updated with breaking changes for example).

Thanks for your patience and your efforts maintaining this package!

It should be good with the new version, sorry for going back and forth, thanks for all the feedbacks.

I expected the previous comment to show up soon...

I think the init for the nvm folder can be configured to be inside srcdir.

This package leaves temporary files in $HOME/.nvm for the machine / user that builds the package.

PKGBUILDs should not alter the home directory of the user building, especially not leave litter behind.

@luxcem No, it modifies ~/.nvm, so it interferes with all new shells.

@kescherAUR I think makepkg uses its own shell so we don't need to restore node version after the build. The env variables are only local.

This fixes the build for people who haven't had nvm sourced before the build() function. Additionally, it only restores if the user hasn't changed the nvm version after the prepare() function.

diff --git a/.SRCINFO b/.SRCINFO
index d97d765..ba198a6 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,7 +1,7 @@
 pkgbase = insomnia
        pkgdesc = Cross-platform HTTP and GraphQL Client
        pkgver = 2020.4.2
-       pkgrel = 4
+       pkgrel = 5
        url = https://github.com/Kong/insomnia
        arch = any
        license = MIT
diff --git a/PKGBUILD b/PKGBUILD
index 24a23b0..f931ef9 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -4,7 +4,7 @@

 pkgname=insomnia
 pkgver=2020.4.2
-pkgrel=4
+pkgrel=5
 _nodeversion=12.18.3
 pkgdesc="Cross-platform HTTP and GraphQL Client"
 url="https://github.com/Kong/insomnia"
@@ -39,8 +39,11 @@ build() {
   npm run bootstrap
   GIT_TAG="core@${pkgver}" npm run app-package

-  # Restore the previous node version so as not to interfere with a user's picked node version on each build
-  nvm use "$(cat "/tmp/${pkgname}-nvm-current.tmp")"
+  # Restore the previous node version if user hasn't changed it
+  source /usr/share/nvm/init-nvm.sh || [ -n "$NVM_BIN" ]
+  oldcurrent="$(cat "/tmp/${pkgname}-nvm-current.tmp")"
+  newcurrent="$(nvm current)"
+  [ "$oldcurrent" = "$newcurrent" ] && ( nvm use "$oldcurrent" || true )
 }

 package() {