Arch Linux User Repository

Hi @The-Compiler,

Thanks for getting back to me so fast. You're right, my mistake I'm very sorry for the noise. I managed to muddle up the patch somehow in copy/pasting over from the machine 😑 Here it is as intended:

diff --git a/PKGBUILD b/PKGBUILD
index d9f9361..8afd159 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -9,17 +9,19 @@ arch=(any)
 url="https://pypi.python.org/pypi/journalwatch/"
 license=('GPL')
 depends=('python' 'python-systemd')
-makedepends=('python-setuptools')
+#makedepends=('python-setuptools')
+makedepends=(python-build python-installer python-wheel)
 options=(!emptydirs)
 source=("https://files.pythonhosted.org/packages/source/${pkgname::1}/${pkgname}/${pkgname}-${pkgver}.tar.gz")
 md5sums=('c06619d5ece24510d6ec334febfbdef9')

 build() {
-  cd "$srcdir/$pkgname-$pkgver"
-  python setup.py build
+    cd "$pkgname-$pkgver"
+    python -m build --wheel --no-isolation
 }

 package() {
-  cd "$srcdir/$pkgname-$pkgver"
-  python setup.py install --root="$pkgdir/" --optimize=1 --skip-build
+    cd "$pkgname-$pkgver"
+    python -m installer --destdir="$pkgdir" dist/*.whl
 }
+

And indeed, in a clean chroot, that fails to build, complaining of a missing setuptools! You're obviously on top of that one, and as you say, the current PKGBUILD's method is also perfectly documented and fine.

Thanks for maintaining the AUR package, and for the tool itself 😉

Hey @marcool04!

That it works now is unrelated to your changes - all you needed to do is rebuilding the existing package, as with every Python upgrade and any Python package you installed via the AUR.

Your patch also has various issues:

• It doesn't seem to apply at all, both git apply and patch complain about a corrupted patch file, even if I fix the indentation of lines such as pkgname, source or md5sums it still complains about it being corrupt.
• The changed cd commands can't possibly work because _name is not defined anywhere.
• Even after fixing all those issues, this won't work - as mentioned in the wiki, this requires that the package implements PEP 517, i.e. has a pyproject.toml, which journalwatch has not. As a consequence, building the package with your changes in a clean chroot fails due to a missing setuptools. I opened an issue to update to that, but until that's done, the curent PKGBUILD is correct (as also documented in the wiki).

@The-Compiler haha, no problem :) Still use the program every day and love it. Great to know you're keeping it up to date! All the best, Mark.

Better late than never :) Thank you!

@Arvedui I'm, like, 3 years late - but I finally included python-setuptools there.

@marcool04 Whoops, I split building/packaging but didn't actually include the building part... Fixed now.

Thanks and sorry for the delays!

Hi, Just tried to installing this, and it appears the last pkgrel bump commit messed something up; the installed script fails to run with:

# /usr/bin/journalwatch
Traceback (most recent call last):
  File "/usr/bin/journalwatch", line 33, in <module>
    sys.exit(load_entry_point('journalwatch==1.1.0', 'console_scripts', 'journalwatch')())
  File "/usr/bin/journalwatch", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/lib/python3.9/importlib/metadata.py", line 77, in load
    module = import_module(match.group('module'))
  File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 984, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'journalwatch'

It seems the extra --skip-build is not such a good idea :) Maybe it only works for upgrades? Reverting it works fine anyhow. All the best, Mark.

Please add python-setuptools to makedepends it fails to build in an clean chroot without it.