Arch Linux User Repository

here's the updated PKGBUILD:

# Maintainer Pol Marcet Sardà <polmarcetsarda@gmail.com>

pkgname=k8vavoom-git
_pkgver_base=build560718
pkgver=build560718.r15184.ec66b0680
pkgrel=1
epoch=1
pkgdesc="Source port of Doom"
arch=(x86_64)
url="https://repo.or.cz/k8vavoom.git"
license=('GPLv2')

depends=("zlib" "bzip2" "libpng" "libjpeg.so" "sdl2" "sdl2_mixer" "openal")
makedepends=("cmake" "git")
optdepends=("libmad")

source=("$pkgname"::"git+$url#tag=$_pkgver_base"
        "format-security.patch")

sha256sums=('SKIP'
            'SKIP')

pkgver() {
  cd "$pkgname"
  printf "$_pkgver_base.r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
}

prepare() {
    cd "$srcdir/$pkgname"
    patch -p1 -i "${srcdir}/format-security.patch"
}

build() {
    cd "$srcdir/$pkgname"
    cmake -DCMAKE_BUILD_TYPE=Release          \
          -DCMAKE_INSTALL_PREFIX=/usr         \
          -DCMAKE_POLICY_VERSION_MINIMUM=3.5  \
          -DCMAKE_C_STANDARD=17               \
          -DENABLE_MASTER=ON                  \
          -DENABLE_SERVER=ON                  \
          -DENABLE_VCCRUN=ON                  \
          -DWITH_SYS_LIBPNG=ON                \
          -DARCH_LINUX_SPECIAL=ON             \
          .
    make
}

package() {
    cd "$srcdir/$pkgname"
    make DESTDIR=$pkgdir install
}

and format-security.patch:

diff --git a/vccrun/modules/sdlgl/mod_sdlgl.cpp b/vccrun/modules/sdlgl/mod_sdlgl.cpp
index dd3ed0cb9..ecbba2c83 100644
--- a/vccrun/modules/sdlgl/mod_sdlgl.cpp
+++ b/vccrun/modules/sdlgl/mod_sdlgl.cpp
@@ -4778,10 +4778,10 @@ VFont::~VFont() {
 //==========================================================================
 VFont *VFont::LoadDF (VName aname, VStr fnameIni, VStr fnameTexture) {
   VOpenGLTexture *tex = VOpenGLTexture::Load(fnameTexture);
-  if (!tex) Sys_Error(va("cannot load font '%s' (texture not found)", *aname));
+  if (!tex) Sys_Error("%s", va("cannot load font '%s' (texture not found)", *aname));

   auto inif = fsysOpenFileAnyExt(fnameIni);
-  if (!inif) { tex->release(); tex = nullptr; Sys_Error(va("cannot load font '%s' (description not found)", *aname)); }
+  if (!inif) { tex->release(); tex = nullptr; Sys_Error("%s", va("cannot load font '%s' (description not found)", *aname)); }
   //GLog.Logf(NAME_Debug, "*** %d %d %d %d", (int)inif->AtEnd(), (int)inif->IsError(), inif->TotalSize(), inif->Tell());

   VStr currSection;
@@ -4793,7 +4793,7 @@ VFont *VFont::LoadDF (VName aname, VStr fnameIni, VStr fnameTexture) {
   // parse ini file
   while (!inif->AtEnd()) {
     VStr line = readLine(inif);
-    if (inif->IsError()) { delete inif; tex->release(); tex = nullptr; Sys_Error(va("cannot load font '%s' (error loading description)", *aname)); }
+    if (inif->IsError()) { delete inif; tex->release(); tex = nullptr; Sys_Error("%s", va("cannot load font '%s' (error loading description)", *aname)); }
     if (line.isEmpty() || line[0] == ';' || line.startsWith("//")) continue;
     if (line[0] == '[') { currSection = line; continue; }
     // fontmap?
@@ -4826,10 +4826,10 @@ VFont *VFont::LoadDF (VName aname, VStr fnameIni, VStr fnameTexture) {

   delete inif;

-  if (cwdt < 1 || chgt < 1) { tex->release(); tex = nullptr; Sys_Error(va("cannot load font '%s' (invalid description 00)", *aname)); }
+  if (cwdt < 1 || chgt < 1) { tex->release(); tex = nullptr; Sys_Error("%s", va("cannot load font '%s' (invalid description 00)", *aname)); }
   int xchars = tex->width/cwdt;
   int ychars = tex->height/chgt;
-  if (xchars < 1 || ychars < 1 || xchars*ychars < 128) { tex->release(); tex = nullptr; Sys_Error(va("cannot load font '%s' (invalid description 01)", *aname)); }
+  if (xchars < 1 || ychars < 1 || xchars*ychars < 128) { tex->release(); tex = nullptr; Sys_Error("%s", va("cannot load font '%s' (invalid description 01)", *aname)); }

   VFont *fnt = new VFont();
   fnt->name = aname;
@@ -4895,10 +4895,10 @@ VFont *VFont::LoadPCF (VName aname, VStr filename) {
 */

   auto fl = fsysOpenFile(filename);
-  if (!fl) { Sys_Error(va("cannot load font '%s'", *aname)); }
+  if (!fl) { Sys_Error("%s", va("cannot load font '%s'", *aname)); }

   PcfFont pcf;
-  if (!pcf.load(*fl)) { Sys_Error(va("invalid PCF font '%s'", *aname)); }
+  if (!pcf.load(*fl)) { Sys_Error("%s", va("invalid PCF font '%s'", *aname)); }

   VFont *fnt = new VFont();
   fnt->name = aname;

Ok, I'll have to take a look at the best approach to solve this (I'm doing finals, so I don't have much time), for the meantime, if you (whoever reads this) have an issue, use jose1711 solution: add -DCMAKE_CXX_FLAGS="-Wno-error=format-security" to the cmake arguments in the PKGBUILD. Sorry :/

hmm.. funny. no changes were made and i am building in a clean chroot.

/build/k8vavoom-git/src/k8vavoom-git/vccrun/modules/sdlgl/mod_sdlgl.cpp: In static member function ‘static VFont* VFont::LoadDF(VName, VStr, VStr)’:
/build/k8vavoom-git/src/k8vavoom-git/vccrun/modules/sdlgl/mod_sdlgl.cpp:4781:22: error: format not a string literal and no format arguments [-Werror=format-security]
/build/k8vavoom-git/src/k8vavoom-git/vccrun/modules/sdlgl/mod_sdlgl.cpp:4784:56: error: format not a string literal and no format arguments [-Werror=format-security]
/build/k8vavoom-git/src/k8vavoom-git/vccrun/modules/sdlgl/mod_sdlgl.cpp:4796:81: error: format not a string literal and no format arguments [-Werror=format-security]
/build/k8vavoom-git/src/k8vavoom-git/vccrun/modules/sdlgl/mod_sdlgl.cpp:4829:71: error: format not a string literal and no format arguments [-Werror=format-security]
/build/k8vavoom-git/src/k8vavoom-git/vccrun/modules/sdlgl/mod_sdlgl.cpp:4832:98: error: format not a string literal and no format arguments [-Werror=format-security]
/build/k8vavoom-git/src/k8vavoom-git/vccrun/modules/sdlgl/mod_sdlgl.cpp: In static member function ‘static VFont* VFont::LoadPCF(VName, VStr)’:
/build/k8vavoom-git/src/k8vavoom-git/vccrun/modules/sdlgl/mod_sdlgl.cpp:4898:23: error: format not a string literal and no format arguments [-Werror=format-security]
/build/k8vavoom-git/src/k8vavoom-git/vccrun/modules/sdlgl/mod_sdlgl.cpp:4901:34: error: format not a string literal and no format arguments [-Werror=format-security]

That's odd, it did not fail in my machine. Do you have by any chance any change regarding -Werror?

was failing to build so i fixed it by adding -DCMAKE_CXX_FLAGS="-Wno-error=format-security" to cmake arguments

This most certainly is my fault, it's been a good while since I updated it. I'll take a look at it shortly! I'm glad to see someone else check this project out.

I´m having issues compiling the PKGBUILD, but not with the actual k8vavoom repo itself. With the PKGBUILD, It fail each time at : [ 32%] Building CXX object utils/vlumpy/CMakeFiles/vlumpy.dir/vlumpy.cpp.o /home/pm/Téléchargements/k8vavoom-git/src/k8vavoom-git/utils/vlumpy/vlumpy.cpp: Dans la fonction « void AddToZip(const char*, void*, size_t) »: /home/pm/Téléchargements/k8vavoom-git/src/k8vavoom-git/utils/vlumpy/vlumpy.cpp:241:10: erreur: le format n'est pas une chaîne littérale et il n'y a pas d'arguments de format [-Werror=format-security] cc1plus : certains avertissements sont traités comme des erreurs make[2]: *** [utils/vlumpy/CMakeFiles/vlumpy.dir/build.make:314 : utils/vlumpy/CMakeFiles/vlumpy.dir/vlumpy.cpp.o] Erreur 1 make[1]: *** [CMakeFiles/Makefile2:972 : utils/vlumpy/CMakeFiles/vlumpy.dir/all] Erreur 2 make: *** [Makefile:136 : all] Erreur 2