Package Details: karton git20250905-1

Git Clone URL: https://aur.archlinux.org/karton.git (read-only, click to copy)
Package Base: karton
Description: A libvirt-based Virtual Machine Manager for KDE
Upstream URL: https://invent.kde.org/sitter/karton
Keywords: karton kde-applications libvirt
Licenses: GPL-3.0-or-later
Submitter: None
Maintainer: leanguedes
Last Packager: leanguedes
Votes: 6
Popularity: 1.05
First Submitted: 2018-03-12 16:48 (UTC)
Last Updated: 2025-09-05 13:58 (UTC)

Latest Comments

HurricanePootis commented on 2025-11-19 20:04 (UTC)

Hello I have a few recommendations for this package.

  1. Create a pkgver() function. I know that this is a stable point release software. However, your current pkgver is wrong. There should never be any words within the pkgver variable. Therefore, I think in this situation where there is a singular tag available for this software, is to use that tag plus the number of commits after this tag.

  2. Set the build type to None, and add the -DNDEBUG to the flags. This removes any build information from the resulting binary.

diff --git a/PKGBUILD b/PKGBUILD
index 70d35a0..a7532d3 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,7 +1,7 @@
 # Maintainer: Leandro Guedes <leanguedes at icloud dot com>

 pkgname=karton
-pkgver=git20250905
+pkgver=0.1.r52.g9c8cbfb
 pkgrel=1
 _commit=9c8cbfb0461e48e77d3ca46bd9311a02f333cb4d
 pkgdesc='A libvirt-based Virtual Machine Manager for KDE'
@@ -33,9 +33,17 @@ makedepends=(
 source=("git+https://invent.kde.org/sitter/karton#commit=$_commit")
 sha256sums=('1cc7eda6d66dd1055311b23a7ff2ea0032b14da6adbf5695f733329ce23c67b8')

+pkgver() {
+  cd "$srcdir/$pkgname"
+  git describe --long --tags --abbrev=7 | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g;s/prealpha.//g'
+}
+
 build() {
   cmake -B build -S $pkgname \
-    -DBUILD_TESTING=OFF
+    -DBUILD_TESTING=OFF \
+    -DCMAKE_BUILD_TYPE=None \
+    -DCMAKE_C_FLAGS="$CFLAGS -DNDEBUG" \
+    -DCMAKE_CXX_FLAGS="$CXXFLAGS -DNDEBUG"
   cmake --build build
 }

micwoj92 commented on 2021-05-10 16:26 (UTC)

Needs python in makedepends