Arch Linux User Repository

@JoaoMachado Totally forgot about it here. PKGBUILD looks very good. Keep up the good work ;-)

1. Renaming of the desktop file to avoid a conflict with the normal installation. So kdenlive-appimage.desktop would be better.

2. Agree. I don't use a launcher, therefore I didn't expect such a problem. And yeah, you have found way without an extra shell script ;-)

Greetings

Please note that this package is now dependent on breeze & breeze-icons packages. Depending on your system, it may be required to install them first.

@megavolt I have updated the PKGBUILD file using most of your changes, I think it is much better, plus I was able to remove the extra shell script.

Greetings @megavolt,

I finally got a chance to look at the patch. I have two questions.

1. The .desktop file was renamed from org.kde.kdenlive.desktop > kdenlive.deskop, is there a specific reason? As I understand it, the official package uses "org.kde.kdenlive.desktop".

2. The shell script has an entry to append the .desktop file with "StartupWMClass=kdenlive", now this piece I added because in some desktop environments if this is not there, the docks, panels, launchers etc., will create duplicate icons. Is there a way to add this without using the extra shell script?

Hello JoaoMachado ;-)

Here is a little patch to make it more compatible. No headache of the icons.

Works great on Manjaro.

Greetings

From 123345d21b78a6c18498aa7a0a6813c538e4501b Mon Sep 17 00:00:00 2001
From: Megavolt <max.megavolt@posteo.de>
Date: Sun, 15 May 2022 09:18:58 +0200
Subject: [PATCH] Improve Compatibility

---
 PKGBUILD    | 40 ++++++++++++++++++++++++----------------
 kdenlive.sh |  3 ---
 2 files changed, 24 insertions(+), 19 deletions(-)
 delete mode 100644 kdenlive.sh

diff --git a/PKGBUILD b/PKGBUILD
index 5722afa..887a9e9 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -10,25 +10,33 @@ arch=('x86_64')
 license=('GPL')
 provides=('kdenlive')
 conflicts=('kdenlive')
-source=("https://download.kde.org/stable/kdenlive/21.12/linux/${_pkgname}-${pkgver}-${arch}.appimage"
-        ${_pkgname}.sh)
-md5sums=('11a5ac0c0d68d5c68292c640c02e2394'
-         '9f6bcd19b67bd5efaf25ea902301968d')
+_filename="${_pkgname}-${pkgver}-${arch}.AppImage"
+source=("${_filename}::https://download.kde.org/stable/kdenlive/21.12/linux/${_pkgname}-${pkgver}-${arch}.appimage")
+md5sums=('11a5ac0c0d68d5c68292c640c02e2394')
 options=(!strip)
-_filename=./${_pkgname}-${pkgver}-${arch}.appimage
-
-prepare() {
+prepare()
+{
   cd "${srcdir}"
   chmod +x ${_filename}
-  ${_filename} --appimage-extract
-  rm ${srcdir}/squashfs-root/usr/share/icons/hicolor/icon-theme.cache
+  eval ./${_filename} --appimage-extract "*/*/*/*/*x*/apps/*.png"
+  eval ./${_filename} --appimage-extract "*/*/applications/*.desktop"
 }

-package() {
-  install -Dm755 "${srcdir}/${_filename}" "${pkgdir}/opt/appimages/${_pkgname}.AppImage"
-  install -Dm755 "${srcdir}/${_pkgname}.sh" "${pkgdir}/usr/bin/${_pkgname}"
+package()
+{
+  # Install AppImage
+  install -Dm755 "${srcdir}/${_filename}" "${pkgdir}/opt/appimages/${_filename}"
+
+  # Install Exec Script
+  ExecScript="#!/bin/sh\nexec /opt/appimages/${_filename} \"\$@\""
+  install -dm755 "${pkgdir}/usr/bin"
+  echo -e $ExecScript > "${pkgdir}/usr/bin/${_pkgname}"
+  chmod +x "${pkgdir}/usr/bin/${_pkgname}"

-  install -dm755 "${pkgdir}/usr/share/"
-  cp -r --no-preserve=mode,ownership "${srcdir}/squashfs-root/usr/share/icons" "${pkgdir}/usr/share/"
-  cp -r --no-preserve=mode,ownership "${srcdir}/squashfs-root/usr/share/applications" "${pkgdir}/usr/share/"
-  }
+  # Install global Desktop-Integration
+  _sizes=('256x256' '128x128' '64x64' '48x48' '32x32' '22x22' '16x16')
+  for _size in ${_sizes[@]}; do
+  install -Dm644 "${srcdir}/squashfs-root/usr/share/icons/hicolor/${_size}/apps/kdenlive.png" "${pkgdir}/usr/share/icons/hicolor/${_size}/apps/kdenlive.png"
+  done
+  install -Dm644 "${srcdir}/squashfs-root/usr/share/applications/org.kde.kdenlive.desktop" "${pkgdir}/usr/share/applications/kdenlive.desktop"
+}
diff --git a/kdenlive.sh b/kdenlive.sh
deleted file mode 100644
index 3f51f33..0000000
--- a/kdenlive.sh
+++ /dev/null
@@ -1,3 +0,0 @@
-#!/bin/sh
-/opt/appimages/./kdenlive.AppImage $@
-echo "StartupWMClass=kdenlive" >> /usr/share/applications/org.kde.kdenlive.desktop
-- 
2.36.1

Yes, you have to uninstall the breeze icons, then the icons are extracted from the appimage and installed. I am not really sure why the original Submitter did it this way instead of making breeze-icons a dependency but I suppose I should look into it.

Seems like it doesn't want to install because it wants to overwrite the breeze icons? Lots of errors like kdenlive-appimage: /usr/share/icons/breeze/places/16/folder-owncloud.svg exists in filesystem (owned by breeze-icons) kdenlive-appimage: /usr/share/icons/breeze/places/16/folder-picture.svg exists in filesystem (owned by breeze-icons) kdenlive-appimage: /usr/share/icons/breeze/places/16/folder-pictures.svg exists in filesystem (owned by breeze-icons) kdenlive-appimage: /usr/share/icons/breeze/places/16/folder-print.svg exists in filesystem (owned by breeze-icons) kdenlive-appimage: /usr/share/icons/breeze/places/16/folder-public.svg exists in filesystem (owned by breeze-icons)

Don't forget to vote for the package!

Thank you for letting me know, I have updated the package to 21.04.

md5sums for kdenlive-20.12.3a-x86_64.appimage is failing