...and one of your changes removes the patching that keeps yarn from downloading vendored Electron binaries. Your version isn't even using the system Electron at build time (it may or may not be at run time) and I didn't even check if you happen to package the vendored copy or not. But it shouldn't even be getting downloaded.
Search Criteria
Package Details: keybase-gui 6.4.0-1
Package Actions
| Git Clone URL: | https://aur.archlinux.org/keybase.git (read-only, click to copy) |
|---|---|
| Package Base: | keybase |
| Description: | GUI frontend for GPG with keybase.io |
| Upstream URL: | https://keybase.io |
| Licenses: | BSD-3-Clause |
| Submitter: | alerque |
| Maintainer: | alerque |
| Last Packager: | alerque |
| Votes: | 9 |
| Popularity: | 0.88 |
| First Submitted: | 2024-04-27 13:34 (UTC) |
| Last Updated: | 2024-08-31 14:21 (UTC) |
Dependencies (8)
- electron32 (electron32-binAUR)
- kbfsAUR (keybase-gitAUR, keybase-binAUR)
- keybaseAUR (keybase-gitAUR, keybase-binAUR)
- git (git-gitAUR, git-glAUR) (make)
- go (go-gitAUR, gcc-go-gitAUR, go-sylixosAUR, gcc-go-snapshotAUR, gcc-go) (make)
- jq (jq-gitAUR) (make)
- moreutils (moreutils-go-binAUR) (make)
- yarn (yarn-pnpm-corepackAUR, corepackerAUR, yarn-berryAUR) (make)
Required by (0)
Sources (4)
Latest Comments
alerque commented on 2024-05-03 20:24 (UTC)
alerque commented on 2024-05-03 19:27 (UTC)
I only removed the patches and eliminated some hardcoded electron22 usages.
...and changed every freaking line of the file with irrelevant style changes just so that the diff is useless to actually see what you did. Dude don't do that if you want to collaborate/contribute on stuff. Style changes have a place, but only when you are either solo, or the changes are agreed on, or the commits are completely isolated from functional changes.
I'll still work through this but it could have been a lot easier...
mhdi commented on 2024-04-29 22:47 (UTC) (edited on 2024-04-29 22:51 (UTC) by mhdi)
@alerque, I successfully built the latest version using this PKGBUILD. I managed to launch the GUI with electron26-bin, but I haven't yet tested it for any potential issues.
This PKGBUILD isn't significantly different from the current one; I only removed the patches and eliminated some hardcoded electron22 usages.
alerque commented on 2024-04-29 11:19 (UTC)
@mhdi Contributions welcome if you can get the current release to build against our electron26/electron26-bin package options. I have several failed attempts but I'm not even sure they are helpful as a starting point because its such a mess.
alerque commented on 2024-04-27 17:22 (UTC) (edited on 2024-07-30 08:13 (UTC) by alerque)
Given the build-from-source disaster, keybase-bin is basically the only viable way to use this at the moment. Contributions are welcome if you can make this build either this version or any newer stable tag. Any working PKGBUILD that follows Arch packaging guidelines, patches, or PRs against this repo are welcome.
alerque commented on 2024-04-27 14:34 (UTC)
This build is 10 forms of disaster. The biggest issue is that this version of electron doesn't build, and the v26 used in current releases is AUR only. Hence dropping to AUR for now.
https://github.com/keybase/client/issues/26791
If/when upstream gets their act together and uses an Electron version that isn't EOL and we get a working build again I'll re-evaluate moving this to official packaging.
Pinned Comments
alerque commented on 2024-08-03 09:28 (UTC)
With major thanks to @intelfx for this PR this package is up and running with Electron 31. Pre-built packages are available in my user repository as usual.
I will add a warning that this is not the version of Electron used in official upstream packaging. It is likely to work, but also likely to have edge cases or small behavioral glitches that are different from other builds. Use at your own risk.
I'll also note as a warning to the unaware that Keybase was purchased and taken over by Zoom Inc., and since then the development work quality has notably declined. For those that evaluated Keybase years ago you might do another evaluation of your threat model and what implications that may have for you.