Package Details: krunner-pass-git 1.3.0.r15.gce0fbda-1

Git Clone URL: https://aur.archlinux.org/krunner-pass-git.git (read-only, click to copy)
Package Base: krunner-pass-git
Description: A krunner plugin to retrieve a password from the password-store (https://www.passwordstore.org/)
Upstream URL: https://github.com/akermu/krunner-pass
Licenses: GPL
Conflicts: krunner-pass
Provides: krunner-pass
Submitter: Cadair
Maintainer: Cadair
Last Packager: Cadair
Votes: 4
Popularity: 0.001541
First Submitted: 2019-09-10 10:30 (UTC)
Last Updated: 2022-06-13 12:09 (UTC)

Latest Comments

1 2 Next › Last »

Cadair commented on 2022-06-13 12:10 (UTC)

I have pushed an update, let me know if there are any other issues!

Cadair commented on 2022-05-29 12:49 (UTC)

Thanks for all the comments everyone, this is my first cmake PKGBUILD so they are very welcome.

I should be able to push a new version soon.

dreieck commented on 2022-05-29 12:39 (UTC) (edited on 2022-05-29 12:40 (UTC) by dreieck)

I have uploaded → here a PKGBUILD that adresses the issues reported by @Thaodan and me (including use of pkgver()).

Feel free to take from that and from @Thaodan how it suits you.

Thanks for maintaining!

dreieck commented on 2022-05-29 12:36 (UTC) (edited on 2022-05-29 12:40 (UTC) by dreieck)

The patch https://github.com/akermu/krunner-pass/pull/21.patch does fix the build issue reported on 2022-05-12 by @ekollof. Thanks to @Thaodan.

dreieck commented on 2022-05-29 12:23 (UTC)

You are building a package from latest git checkout. But you use a fixed version number. Please utilise the pkgver() function to make sure to generate a strictly monotoneously increasing $pkgver, which is required. I.e., after each git commit, $pkgver must be increased.

A working pkgver() function could be this:

pkgver() {
  cd "${srcdir}/krunner-pass"

  _ver="$(git describe --tags | sed  's|^[vV]||' | sed 's|-[^-]*$||' | tr '-' '+')"
  _rev="$(git rev-list --count HEAD)"
  _date="$(git log -1 --date=format:"%Y%m%d" --format="%ad")"
  _hash="$(git rev-parse --short HEAD)"

  if [ -z "${_ver}" ]; then
    error "Version could not be determined."
    return 1
  else
    printf '%s' "${_ver}.r${_rev}.${_date}.${_hash}"
  fi
}

Thanks for maintaining.

dreieck commented on 2022-05-29 12:21 (UTC) (edited on 2022-05-29 12:22 (UTC) by dreieck)

Please use qtpath-calls instead of kf5-config as @Thaodan already suggested on 2022-05-27:

  • `kf5-config --prefix`"$(qtpaths --install-prefix)"
  • `kf5-config --qt-plugins`$(qtpaths --plugin-dir)"

Thanks for maintaining!

dreieck commented on 2022-05-29 12:08 (UTC)

qt5-tools and git are missing in makedepends; kcmutils is missing in depends. Please add.

Also, source url misses a .git at the end. Please append.

Thanks for maintaining!

dreieck commented on 2022-05-29 12:05 (UTC)

You compile a binary. So arch=('any') is wrong. Please specify all supported architectures.

Thanks for maintaining!

dreieck commented on 2022-05-29 12:02 (UTC)

Please change source protocol from git:// to git+https:// due to changes at github. As it is currently, no download is possible.

Thanks for maintaining!