Hi @ptr1337 i can do this change because people will use this package expected the kernel module to be included this will only create more confusion to the user, and dont make sense because the package not work without the kernel module. Nobara is the only distro that patch the kernel and most the times the module is outdated dont make sense in a arch base distro to have a kernel module completed outdated. You can clone the package and make the changes to not depend on dkms and included on your distro. Edit: I really dont know very well how provide work
Search Criteria
Package Details: lenovolegionlinux-git r255.a729683-0
Package Actions
Git Clone URL: | https://aur.archlinux.org/lenovolegionlinux-git.git (read-only, click to copy) |
---|---|
Package Base: | lenovolegionlinux-git |
Description: | LenovoLegionLinux (LLL) brings additional drivers and tools for Lenovo Legion series laptops to Linux. PLEASE READ THE REPO BEFORE INSTALL THIS PACKAGE!!! |
Upstream URL: | https://github.com/johnfanv2/LenovoLegionLinux |
Licenses: | GPL |
Conflicts: | legion-fan-utils-linux-git |
Submitter: | MrDuartePT |
Maintainer: | MrDuartePT (XenHat) |
Last Packager: | MrDuartePT |
Votes: | 7 |
Popularity: | 0.014871 |
First Submitted: | 2023-03-14 18:40 (UTC) |
Last Updated: | 2024-04-07 01:46 (UTC) |
Dependencies (13)
- acpid
- polkit (polkit-gitAUR, polkit-consolekitAUR)
- python-argcomplete (python-argcomplete-gitAUR)
- python-darkdetect
- python-pyqt6
- python-wheel
- git (git-gitAUR) (make)
- libinih (libinih-gitAUR) (make)
- python-build (make)
- python-installer (python-installer-gitAUR) (make)
- python-setuptools (make)
- python-yaml (python-yaml-gitAUR) (make)
- lenovolegionlinux-dkms-gitAUR (optional) – DKMS module (install if your distro dosent patch in the kernel our you are not sure to haveit)
Required by (1)
Sources (1)
MrDuartePT commented on 2023-04-29 13:14 (UTC) (edited on 2023-04-29 13:22 (UTC) by MrDuartePT)
ptr1337 commented on 2023-04-29 11:07 (UTC)
Hi,
I think you should remove the depend on lenovolegionlinux-dkms-git. This would make force you to use the dkms package, even if you have patched this module to your kernel. This really makes not much sense.
The only good solution I see, would be to add a provide like this: 'LENOVOLEGION-MODULE'
This can be then added to kernels, which provide the patchset included and the package above does not depend all time on the dkms package.
MrDuartePT commented on 2023-04-28 23:27 (UTC) (edited on 2023-04-28 23:37 (UTC) by MrDuartePT)
@ptr1337 i fix the sed command. Well i made the chnage now this only have the python package and dkms is seperate.
ptr1337 commented on 2023-04-28 21:11 (UTC)
Another thing:
Why is this required in the non(dkms) version which provides only the GUI?
install -Dm644 kernel_module/*.ko "${pkgdir}/usr/lib/modules/$(uname -r)/kernel/drivers/platform/x86"
The module should be provided from the patch itself and not copied to the package
ptr1337 commented on 2023-04-28 21:08 (UTC)
@MrDuartePT
One more issue:
Cloning into 'lenovolegionlinux'...
done.
==> Starting prepare()...
error: pathspec '.84de130' did not match any file(s) known to git
==> ERROR: A failure occurred in prepare().
Aborting...
Is happening when trying to build in a (docker) chroot. Did not tested locally
ptr1337 commented on 2023-04-28 18:09 (UTC)
@MrDuartePT
Thank you very much for providing it correctly! :)
One issue I found is that "linux-headers" can be removed from the depends, as well as base-devel. :)
yochananmarqos commented on 2023-04-28 03:20 (UTC)
@MrDuartePT: Since you split off the DKMS package, that should only contain the DKMS module and this package should only include the GUI.
MrDuartePT commented on 2023-04-28 00:09 (UTC) (edited on 2023-04-29 22:09 (UTC) by MrDuartePT)
@ptr1337 is done Now dkms package is: lenovolegionlinux-dkms-git
ptr1337 commented on 2023-04-19 17:56 (UTC)
Hi,
Would you please rename this package or provide it correctly with named dkms? On CachyOS we will provide the patch directly into the kernel. Also the current package does not fit the correct packaging rules.
So please Create a new package for dkms and make this package without dkms.
Would be nice. Thanks for maintaining this.
Pinned Comments
MrDuartePT commented on 2023-04-29 22:08 (UTC) (edited on 2023-04-29 22:08 (UTC) by MrDuartePT)
if you disto dosent patch the kernel with the module pls install lenovolegionlinux-dkms-git NOTE: For now only CachyOS does
MrDuartePT commented on 2023-04-28 00:09 (UTC) (edited on 2023-04-29 22:09 (UTC) by MrDuartePT)
@ptr1337 is done Now dkms package is: lenovolegionlinux-dkms-git