Package Details: lf 13-2

Git Clone URL: https://aur.archlinux.org/lf.git (read-only)
Package Base: lf
Description: A terminal file manager inspred by ranger written in Go
Upstream URL: https://github.com/gokcehan/lf
Licenses: MIT
Submitter: dmarcoux
Maintainer: nvllsvm
Last Packager: nvllsvm
Votes: 6
Popularity: 0.666964
First Submitted: 2016-10-06 21:37
Last Updated: 2019-10-04 00:43

Dependencies (2)

Required by (1)

Sources (1)

Latest Comments

1 2 Next › Last »

rumpelsepp commented on 2019-10-05 06:49

Using a non-GOPATH build resulted in build sources being placed in my ~/go directory. I do not think that is appropriate.

Yes it is, since this is how it works, and it is the default. Also, I think, you skip upstream's dependency versioning by changing the built to the deprecated GOPATH build. If you do not want the build system to create files in your homedir, then set GOPATH outside of the PKGBUILD to /tmp or something.

Requiring go-pie to build this is too opinionated - especially when it requires someone to uninstall their existing go installation.

This needs to be discussed with the arch team.

nvllsvm commented on 2019-10-05 05:11

  • Using a non-GOPATH build resulted in build sources being placed in my ~/go directory. I do not think that is appropriate.
  • Requiring go-pie to build this is too opinionated - especially when it requires someone to uninstall their existing go installation. There is no harm in requiring the regular go package as the go-pie package can be used as a drop-in replacement (provides).

rumpelsepp commented on 2019-10-04 05:32

Thank you!

nvllsvm commented on 2019-10-03 22:41

Package fixed.

@rumpelsepp - I didn't use your patch, but I did add -trimpath to the build arguments. Also - why did you make go-pie an explicit requirement when go is more than sufficient?

kronikpillow commented on 2019-09-27 16:37

still fails to build :-/ please fix the package

rumpelsepp commented on 2019-09-18 18:46

Here is an update. Mind me adding as a co maintainer? :-)

edit: I added completions and everything as well.

diff --git a/PKGBUILD b/PKGBUILD
index e3c68c2..d038e0e 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,33 +1,38 @@
+# Maintainer: Andrew Rabert <ar@nullsum.net>
 # Contributor: Ian Beringer <ian@ianberinger.com>
 # Contributor: Stefan Husmann <stefan-husmann@t-online.de>
-# Maitainer: Andrew Rabert <ar@nullsum.net>
+# Contributor: Stefan Tatschner <stefan@rumpelsepp.org>

 pkgname=lf
 pkgver=13
 pkgrel=1
 license=('MIT')
 pkgdesc="A terminal file manager inspred by ranger written in Go"
-depends=("glibc")
-makedepends=('git' 'go')
+makedepends=('go-pie')
 arch=('armv7h' 'i686' 'x86_64')
 url="https://github.com/gokcehan/lf"
 source=("$pkgname-r$pkgver.tar.gz::https://github.com/gokcehan/$pkgname/archive/r$pkgver.tar.gz")
 sha256sums=('fe99ed9785fbdc606835139c0c52c854b32b1f1449ba83567a115b21d2e882f4')
-_srcname=${pkgname}-r$pkgver

 build() {
-  export GOPATH=${srcdir}
-  mkdir -p ${GOPATH}/src
-  rm -rf ${GOPATH}/src/${_srcname} 
-  mv ${_srcname} ${GOPATH}/src
-  cd ${GOPATH}/src/${_srcname}
-  go get
-  version=r$pkgver ./gen/build.sh
+   cd $pkgname-r$pkgver
+   go build \
+    -trimpath \
+    -ldflags "-X main.gVersion=$version -extldflags $LDFLAGS" \
+    -o $pkgname .
 }

 package() {
-  cd ${GOPATH}/src/${_srcname}
-  install -Dm755 lf-r$pkgver "${pkgdir}"/usr/bin/lf
-  install -Dm644 ./LICENSE "${pkgdir}"/usr/share/licenses/${pkgname}/LICENSE
-  install -Dm644 ./README.md "${pkgdir}"/usr/share/doc/${pkgname}/README.md
+  cd $pkgname-r$pkgver
+
+  install -Dm755 lf "${pkgdir}"/usr/bin/lf
+  install -Dm644 LICENSE "${pkgdir}"/usr/share/licenses/${pkgname}/LICENSE
+  install -Dm644 README.md "${pkgdir}"/usr/share/doc/${pkgname}/README.md
+
+  install -Dm644 etc/lfrc.example "${pkgdir}"/usr/share/doc/${pkgname}/lfrc.example
+  install -Dm644 etc/lf.vim "${pkgdir}"/usr/share/vim/vimfiles/plugin/lf.vim
+  install -Dm644 etc/lf.fish "${pkgdir}"/usr/share/fish/vendor_completions.d/lf.fish
+  install -Dm644 etc/lfcd.fish "${pkgdir}"/usr/share/fish/vendor_functions.d/lfcd.fish
+  install -Dm644 etc/lfcd.sh "${pkgdir}"/usr/share/${pkgname}/lfcd.sh
+  install -Dm644 lf.1 "${pkgdir}"/usr/share/man/man1/lf.1
 }

nvllsvm commented on 2018-11-14 00:30

This package needs some love. It fails to build currently.

Recommended changes:

  • build dependencies are missing. Use dep to install these
  • requires go-pie when go is sufficient
  • add armv7h support

Here's a working version:

# Contributor: Ian Beringer <ian@ianberinger.com>
# Maintainer: Stefan Husmann <stefan-husmann@t-online.de>

pkgname=lf
pkgver=8
pkgrel=2
license=('MIT')
pkgdesc="A terminal file manager inspred by ranger written in Go"
depends=("glibc")
makedepends=('dep' 'git' 'go')
arch=('armv7h' 'i686' 'x86_64')
url="https://github.com/gokcehan/lf"
source=("$pkgname-r$pkgver.tar.gz::https://github.com/gokcehan/$pkgname/archive/r$pkgver.tar.gz")
sha256sums=('b92bfba41cc1b4054c44bf615907380482c66694fc9eaf4affe185b39cb9bb26')
_srcname=${pkgname}-r$pkgver

build() {
  export GOPATH=${srcdir}
  mkdir -p ${GOPATH}/src
  rm -rf ${GOPATH}/src/${_srcname} 
  mv ${_srcname} ${GOPATH}/src
  cd ${GOPATH}/src/${_srcname}
  dep ensure -v
  go build
}

package() {
  cd ${GOPATH}/src/${_srcname}
  install -Dm755 lf-r$pkgver "${pkgdir}"/usr/bin/lf
  install -Dm644 ./LICENSE "${pkgdir}"/usr/share/licenses/${pkgname}/LICENSE
  install -Dm644 ./README.md "${pkgdir}"/usr/share/doc/${pkgname}/README.md
}

obreitwi commented on 2018-09-28 09:31

There are two missing go dependencies, causing the package build to fail if not present.

Workaround is to go get the two dependencies manually beforehand:

go get github.com/mattn/go-runewidth
go get github.com/nsf/termbox-go

Could you add them? Thank you!

benneti commented on 2017-04-20 07:55

Could you add armv7h to the arch list and the sources? I just tested it, works flawless on armv7h with the linux-arm build

anika200 commented on 2017-04-11 13:04

Checksums need updated again, thanks.