Arch Linux User Repository

@reaperx7 do you by any chance have -Wl,z,now in LDFLAGS from makepkg.conf? When I inherited this package there has always been a dubious export LDFLAGS=${LDFLAGS/,-z,now}, which would leave an empty -Wl in place as can be seen in the command that it executes.

Please try this patch to see if that solves it for you:

diff --git a/PKGBUILD b/PKGBUILD
index 77358b0..3915192 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -40,7 +40,7 @@ prepare() {
 build() {
   export CFLAGS="${CFLAGS/-fno-plt}"
   export CXXFLAGS="${CXXFLAGS/-fno-plt}"
-  export LDFLAGS="${LDFLAGS/,-z,now}"
+  export LDFLAGS="${LDFLAGS/-Wl,-z,now}"

   build_xgl() {
     bitness=$1

This bogus op was introduced in 2673045952a4 for a missing symbol; perhaps that has long been addressed and these overrides can all be removed; I'll check that out before pushing a fix to the repo.

Thanks for reporting!

Package build fails with the following error:

-- Check for working C compiler: /usr/bin/cc - broken CMake Error at /usr/share/cmake/Modules/CMakeTestCCompiler.cmake:67 (message): The C compiler "/usr/bin/cc" is not able to compile a simple test program. It fails with the following output: Change Dir: '/home/james/.cache/yay/amdvlk-git/src/builds/Release64/CMakeFiles/CMakeScratch/TryCompile-eq4mCw' Run Build Command(s): /usr/bin/ninja -v cmTC_d50a0 [1/2] /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -flto=auto -o CMakeFiles/cmTC_d50a0.dir/testCCompiler.c.o -c /home/james/.cache/yay/amdvlk-git/src/builds/Release64/CMakeFiles/CMakeScratch/TryCompile-eq4mCw/testCCompiler.c [2/2] : && /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -flto=auto -Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl -Wl,-z,pack-relative-relocs -flto=auto CMakeFiles/cmTC_d50a0.dir/testCCompiler.c.o -o cmTC_d50a0 && : FAILED: cmTC_d50a0 : && /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -flto=auto -Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl -Wl,-z,pack-relative-relocs -flto=auto CMakeFiles/cmTC_d50a0.dir/testCCompiler.c.o -o cmTC_d50a0 && : cc: error: unrecognized command-line option ‘-Wl’; did you mean ‘-W’? ninja: build stopped: subcommand failed. CMake will not be able to correctly generate this project. Call Stack (most recent call first): CMakeLists.txt:46 (project) -- Configuring incomplete, errors occurred! ==> ERROR: A failure occurred in build(). Aborting... -> error making: amdvlk-git-exit status 4

@SkylerLinux this is a -git package that always builds the latest version from git, and will automatically update its version when built locally via the pkgver() function defined in PKGBUILD.

I will only push a version update when there is an accompanying code change in PKGBUILD.

If you do think there is an incompatibility with the latest amdvlk release from git, do click the Flag package out-of-date button on the top-right and describe what upstream change caused a conflict and requires a code change in PKGBUILD.

Version 2023.Q4 yet extra/multilib is 2024.Q2 and seemingly was updated this year. Kinda odd

@RAMChYLD ouch it looks like their main branch was force-pushed, changing the context of that pull request and hence the patch contents that are downloaded: https://github.com/GPUOpen-Drivers/pal/pull/94#event-9326017384

Guess I'll use an immediate hash to the commit the next time around, or check the patch in to this package repo for simplicity. For now you can replace the source link with https://github.com/GPUOpen-Drivers/pal/commit/935599d77310f1b6968d69c229301fb43f38e11d.patch, I'll push a fix for that soon.

Getting a build error:

==> Making package: amdvlk-git 2023.Q2.2.r0.ec40bda-1 (Thu 25 May 2023 11:20:34 PM +08)
==> Retrieving sources...
  -> Found 94.patch
==> Validating source files with sha256sums...
    94.patch ... FAILED
==> ERROR: One or more files did not pass the validity check!
 -> error downloading sources: /home/leecy/.cache/yay/amdvlk-git 
         context: exit status 1 


:: (1/1) Parsing SRCINFO: amdvlk-git
==> Making package: amdvlk-git 2023.Q2.2.r0.ec40bda-1 (Thu 25 May 2023 11:20:36 PM +08)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found 94.patch
==> Validating source files with sha256sums...
    94.patch ... FAILED
==> ERROR: One or more files did not pass the validity check!
 -> error making: amdvlk-git-exit status 1
 -> Failed to install the following packages. Manual intervention is required:
amdvlk-git - exit status 1

@bio3c thanks for reporting! I've ran into the same error here and in other codebases after upgrading to gcc-13. This requires the following upstream fix to the PAL repository:

https://github.com/GPUOpen-Drivers/pal/pull/94

If necessary I can push a temporary workaround to the PKGBUILD that applies this patch before commencing the build.

i'm having errors building it, pretty much all errors are as such:

[59/2700] Building CXX object pal/src/core/imported/rdf/rdf/CMakeFiles/amdrdf.dir/src/amdrdf.cpp.o
FAILED: pal/src/core/imported/rdf/rdf/CMakeFiles/amdrdf.dir/src/amdrdf.cpp.o
/usr/bin/c++ -DRDF_BUILD_LIBRARY -DRDF_BUILD_STATIC=1 -DRDF_PLATFORM_UNIX=1 -I/var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/rdf/inc -I/var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/imported/zstd/inc -march=x86-64 -mtune=generic -O2 -pipe  -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -O3 -DNDEBUG -std=c++11 -fPIC   -flto -fuse-linker-plugin -Wno-odr -fPIC -MD -MT pal/src/core/imported/rdf/rdf/CMakeFiles/amdrdf.dir/src/amdrdf.cpp.o -MF pal/src/core/imported/rdf/rdf/CMakeFiles/amdrdf.dir/src/amdrdf.cpp.o.d -o pal/src/core/imported/rdf/rdf/CMakeFiles/amdrdf.dir/src/amdrdf.cpp.o -c /var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/rdf/src/amdrdf.cpp
In file included from /var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/rdf/src/amdrdf.cpp:25:
/var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/rdf/inc/amdrdf.h:112:39: error: ‘int64_t’ in namespace ‘std’ does not name a type
  112 |     int (*Read)(void* ctx, const std::int64_t count, void* buffer, std::int64_t* bytesRead);
      |                                       ^~~~~~~
/var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/rdf/inc/amdrdf.h:112:73: error: ‘std::int64_t’ has not been declared
  112 |     int (*Read)(void* ctx, const std::int64_t count, void* buffer, std::int64_t* bytesRead);
      |                                                                         ^~~~~~~

@marijns - if there's no need to bump then it's okay. I still do not really understand how the git thing works and thought it will still pull the 2022.Q4.4 tree only.

Thanks, and sorry.

@RAMChYLD this is a git package and the latest source is automatically fetched on build: pkgver() also updates the version in PKGBUILD. I just built the package with Q1.3 and see the extension in vulkaninfo for this device/driver, without making any manual changes to PKGBUILD. Can you clarify what "refactor" you are expecting, is there a specific build/runtime error?

Consequently pushing new PKGBUILD just to bump pkgver is uncommon for git/vcs packages, pkgver() is supposed to prevent such churn. Unless there's a request to bump it on tagged releases just to show compatibility with the latest version here on the AUR?