Package Details: libcommuni 3.5.0-1

Git Clone URL: https://aur.archlinux.org/libcommuni.git (read-only)
Package Base: libcommuni
Description: A cross-platform IRC framework written with Qt.
Upstream URL: https://communi.github.io/
Licenses: custom
Conflicts: libcommuni
Provides: libcommuni
Submitter: brenns10
Maintainer: brenns10
Last Packager: brenns10
Votes: 5
Popularity: 0.101870
First Submitted: 2015-11-08 17:00
Last Updated: 2017-02-22 16:05

Required by (5)

Sources (1)

Latest Comments

Arvedui commented on 2019-01-06 17:39

After a quick look a found a few other suboptimal things about the PKGBUILD

  • There is no need to conflict and provide itself
  • Build libs had rpaths set, which can be a security problem. I'm removing them with chrpath (normally the build system clears these on install)
  • License should be BSD, not custom

You can apply this patch with patch patch -p1 < $path_to_patch

diff --git a/PKGBUILD b/PKGBUILD
index [`8625712`](https://aur.archlinux.org/cgit/aur.git/commit/?h=libcommuni&id=8625712)..066ce88 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,28 +1,18 @@
 # Maintainer: Stephen Brennan <smb196@case.edu>
+# Contributor: Arvedui <arvedui@posteo.de>
+
+
 pkgname=libcommuni
 pkgver=3.5.0
-pkgrel=1
-epoch=
+pkgrel=2
 pkgdesc="A cross-platform IRC framework written with Qt."
-arch=('any')
+arch=('x86_64' 'i686' 'aarch64' 'arm' 'armv6h' 'armv7h')
 url="<https://communi.github.io/>"
-license=('custom')
-groups=()
+license=('BSD')
 depends=('qt5-declarative')
-makedepends=()
-checkdepends=()
-optdepends=()
-provides=($pkgname)
-conflicts=($pkgname)
-replaces=()
-backup=()
-options=()
-install=
-changelog=
+makedepends=('chrpath')
 source=("libcommuni-v$pkgver.tar.gz::<https://github.com/communi/>$pkgname/archive/v$pkgver.tar.gz")
-noextract=()
-md5sums=(2b62f599800962b2350cbd7ca2fc05ae)
-validpgpkeys=()
+md5sums=('2b62f599800962b2350cbd7ca2fc05ae')

 build() {
    cd "$pkgname-$pkgver"
@@ -41,4 +31,8 @@ package() {
     mkdir -p "$pkgdir/usr/share/licenses/${pkgname}/"
     install -m644 LICENSE \
         "$pkgdir/usr/share/licenses/${pkgname}/"
+
+   chrpath -d "${pkgdir}/usr/lib/libIrc"{Model,Util}".so.3.5.0"
+   chrpath -d "${pkgdir}/usr/lib/qt/qml/Communi/libcommuniplugin.so"
+
 }

Arvedui commented on 2019-01-06 17:07

Please do not use "any" in arch for compiled software. The arch array is not about the possible target systems it is about the compiled state of the software.

You would be able to install the resulting package on any system, but if I build it on my x86 system you could not use in on arm, which is supposed to be the case for "any" packages.

brenns10 commented on 2017-02-22 15:54

I'm updating PKGBUILD to 3.5.0 right now, and setting arch=('any').

Neraeh commented on 2017-02-22 15:05

Is it still maintained ?
Latest version is 3.5.0 now

monojp commented on 2016-10-20 08:10

+1 for changing the architecture to 'any'

lord_rel commented on 2016-09-14 11:16

Does not pass the check phase of building the packages for me
fails on

Config: Using QtTest library 5.7.0, Qt 5.7.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 6.1.1 20160707)
PASS : tst_IrcCommand::initTestCase()
INFO : tst_IrcCommand::testDefaults() Did not receive message: "Reimplement IrcCommand::toString() for IrcCommand::Custom"
FAIL! : tst_IrcCommand::testDefaults() Not all expected messages were received
INFO : tst_IrcConnection::testEncoding(null) Did not receive message: "IrcConnection::setEncoding(): unsupported encoding "" "
FAIL! : tst_IrcConnection::testEncoding(null) Not all expected messages were received
INFO : tst_IrcConnection::testEncoding(empty) Did not receive message: "IrcConnection::setEncoding(): unsupported encoding "" "
FAIL! : tst_IrcConnection::testEncoding(empty) Not all expected messages were received
INFO : tst_IrcConnection::testEncoding(space) Did not receive message: "IrcConnection::setEncoding(): unsupported encoding " " "
FAIL! : tst_IrcConnection::testEncoding(space) Not all expected messages were received
INFO : tst_IrcConnection::testEncoding(invalid) Did not receive message: "IrcConnection::setEncoding(): unsupported encoding "invalid" "
FAIL! : tst_IrcConnection::testEncoding(invalid) Not all expected messages were received
INFO : tst_IrcCommand::testEncoding(null) Did not receive message: "IrcCommand::setEncoding(): unsupported encoding "" "
FAIL! : tst_IrcCommand::testEncoding(null) Not all expected messages were received
PASS : tst_Irc::initTestCase()
INFO : tst_IrcCommand::testEncoding(empty) Did not receive message: "IrcCommand::setEncoding(): unsupported encoding "" "
FAIL! : tst_IrcCommand::testEncoding(empty) Not all expected messages were received
INFO : tst_IrcCommand::testEncoding(space) Did not receive message: "IrcCommand::setEncoding(): unsupported encoding " " "
FAIL! : tst_IrcCommand::testEncoding(space) Not all expected messages were received
INFO : tst_IrcCommand::testEncoding(invalid) Did not receive message: "IrcCommand::setEncoding(): unsupported encoding "invalid" "
FAIL! : tst_IrcCommand::testEncoding(invalid) Not all expected messages were received

and others

fanningert commented on 2016-07-21 11:14

@brenns10: Can ypu please change the arch from "('x86' 'x86_64')" to "('any')", because it is a cross-platform framework and with this change it is usable also on ARM systems.