Arch Linux User Repository

Why are you stomping static libs and causing conflicts with upstream packages like, for example, zlib? They're not necessary for running the .so.

diff --git a/PKGBUILD b/PKGBUILD
index 3dc3f92..61d85f8 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -26,9 +26,6 @@ md5sums_armv7h=('9521ccbf2eb32c6925f5524b0254c6f6')

 package () {
   mkdir -p "${pkgdir}/usr/lib/"
-  for lib in $(find -L . -maxdepth 1 -type f -name "lib*" -iname "lib*" ! -name "*.tar.gz")
-  do
-    cp -a "${lib}" "${pkgdir}/usr/lib/"
-  done
+  find -L -type f -iname "lib*.so*" -print0 | xargs -0r -I@ -- cp -a "@" "${pkgdir}/usr/lib/"
   chown -R root:root "${pkgdir}/usr/lib/"
 }

Ah yes, let's remove the tar.gz before trying to cp it... https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=libcurl-impersonate-bin#n29

Swap those lines, please. Also, cp is not happy with glob, so the correct package should be:

package () {
  mkdir -p "${pkgdir}/usr/lib/"
  cp -a libcurl-impersonate_x86_64.tar.gz "${pkgdir}/usr/lib/"
  rm libcurl-impersonate*.tar.gz
  chown -R root:root "${pkgdir}/usr/lib/"
}

Why upgrade to a release candidate anyways? We should stick to stable releases unless something is broken.

Doesn't build, the filenames changed and there's no libcurl-impersonate-chrome.* anymore.

Thanks for the comment @gesh

UPDATE: ignore the below suggestion, TIL install resolves symlinks, making it unsuitable for copying shared libs like this https://stackoverflow.com/a/39295609

As @cspr mentioned, had to change from install to cp

Did update description, added new architeture armv7h and fixed the duplication.

Thanks for packaging this!

UPDATE: ignore the below suggestion, TIL install resolves symlinks, making it unsuitable for copying shared libs like this https://stackoverflow.com/a/39295609

In re the package() trouble, how about

package () {
-  mkdir -p "${pkgdir}/usr/lib/"
-  rm libcurl-impersonate*.tar.gz
-  cp -a libcurl-impersonate-* "${pkgdir}/usr/lib/"
-  chown -R root:root "${pkgdir}/usr/lib/"
+    install -o root -g root -D -t "${pkgdir}/usr/lib/" \
+        libcurl-impersonate-*.{a,la,so}*
 }

? Also, checksums are duplicated in the PKGBUILD. Personally dislike md5sums, but that may be cargo-culting on my part. Finally, pkgdesc is pretty long, how about A build of Libcurl designed to impersonate Firefox and Chrome?

Thanks for your suggestion @cspr and sorry for taking so long to respond. Check if the current implementation makes more sense and works for you.

After I install this package, every pacman operation I run gives me this warning:

ldconfig: /usr/lib/libcurl-impersonate-chrome.so.4 is not a symbolic link ldconfig: /usr/lib/libcurl-impersonate-ff.so.4 is not a symbolic link

I think the 'install' command you use does not preserve symlinks and simply makes copies of the .so. I'm not sure what the idiomatic thing to do here is, maybe cp --preserve=links, or manually installing each symlink with ln -s ?