Arch Linux User Repository

Give me a minute. I’ll go have a look.

Edit: Patched and done. Please clear your yay cache or pull the latest pkgbuild and srcinfo before rebuilding. Thanks.

Made a quick test; fails to build but work if using gcc14 (export CC=/usr/bin/gcc-14 CXX=/usr/bin/g++-14), tested that since gcc have just been updated to v15.1

Warnings and a build error when trying to update to libquicktime-1.2.4 this morning. Sorry they scrolled past the terminal buffer so I've only got some examples.

Error (context beneath): lqtplay.c:1480:11: error: too many arguments to function 'decode_audio'; expected 0, have 1 @ 1480 | decode_audio(AUDIO_BLOCK_SIZE);

/bin/sh ../libtool  --tag=CC   --mode=link gcc -DLOCALE_DIR=\"/usr/share/locale\" -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -finline-functions -Wall -Winline -Wmissing-declarations -Wdeclaration-after-statement -fvisibility=hidden
-Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now          -Wl,-z,pack-relative-relocs -o qtstreamize qtstreamize.o ../src/libquicktime.la -lm -lz -ldl  -lfaad -lm
gen_colorspace_tables.c: In function 'main':
gen_colorspace_tables.c:29:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
29 |   if(v<min) v=min; if(v>max) v=max;
    |   ^~
gen_colorspace_tables.c:138:5: note: in expansion of macro 'RECLIP'
138 |     RECLIP(tmp_int, 0, 255);
    |     ^~~~~~
gen_colorspace_tables.c:29:20: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'                                                                                       29 |   if(v<min) v=min; if(v>max) v=max;                                                                                                                                                                                |                    ^~
gen_colorspace_tables.c:138:5: note: in expansion of macro 'RECLIP'
138 |     RECLIP(tmp_int, 0, 255);
    |     ^~~~~~
gen_colorspace_tables.c:29:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
29 |   if(v<min) v=min; if(v>max) v=max;
    |   ^~
gen_colorspace_tables.c:153:5: note: in expansion of macro 'RECLIP'
153 |     RECLIP(tmp_int, 0, 255);
    |     ^~~~~~
lqtplay.c: In function 'qt_alsa_audio_write':
gen_colorspace_tables.c:29:20: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
29 |   if(v<min) v=min; if(v>max) v=max;
    |                    ^~
gen_colorspace_tables.c:153:5: note: in expansion of macro 'RECLIP'
153 |     RECLIP(tmp_int, 0, 255);
    |     ^~~~~~
lqtplay.c:1480:11: error: too many arguments to function 'decode_audio'; expected 0, have 1
1480 |           decode_audio(AUDIO_BLOCK_SIZE);
    |           ^~~~~~~~~~~~
lqtplay.c:1420:12: note: declared here
1420 | static int decode_audio()
    |            ^~~~~~~~~~~~
lqtplay.c: In function 'qt_sndio_audio_write':
lqtplay.c:1518:7: error: too many arguments to function 'decode_audio'; expected 0, have 1
1518 |       decode_audio(AUDIO_BLOCK_SIZE);
    |       ^~~~~~~~~~~~
lqtplay.c:1420:12: note: declared here
1420 | static int decode_audio()
    |            ^~~~~~~~~~~~
lqtplay.c: In function 'qt_oss_audio_write':
lqtplay.c:1560:7: error: too many arguments to function 'decode_audio'; expected 0, have 1
1560 |       decode_audio(AUDIO_BLOCK_SIZE);
    |       ^~~~~~~~~~~~
lqtplay.c:1420:12: note: declared here
1420 | static int decode_audio()
    |            ^~~~~~~~~~~~
make[3]: *** [Makefile:742: lqtplay.o] Error 1
make[3]: *** Waiting for unfinished jobs

Also, I couldn't quickly find a good place to report bugs upstream. Maybe downgrade this until the build is fixed?

Ok, that took a while, but I finally have access to my computers again, I finally have some free time again, and have pushed the requested patches.

Hope this helps!

Ah nuts, I missed this message and my next window to update my AUR is end of Febuary next year... So sorry...

And here are the changes needed to compile against ffmpeg7 which just recently landed:

diff -ru libquicktime-1.2.4.orig/plugins/ffmpeg/audio.c libquicktime-1.2.4/plugins/ffmpeg/audio.c
--- libquicktime-1.2.4.orig/plugins/ffmpeg/audio.c  2024-07-09 12:18:11.919376601 +0200
+++ libquicktime-1.2.4/plugins/ffmpeg/audio.c   2024-07-09 12:10:53.297276614 +0200
@@ -971,7 +971,11 @@
   if(!codec->initialized)
     {
     /* Set some mandatory variables */
+#if LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(61, 0, 0)
+    codec->avctx->ch_layout.nb_channels = quicktime_track_channels(file, track);
+#else
     codec->avctx->channels        = quicktime_track_channels(file, track);
+#endif
     codec->avctx->sample_rate     = quicktime_sample_rate(file, track);

     if(track_map->track->mdia.minf.stbl.stsd.table[0].version == 1)
@@ -1202,7 +1206,11 @@
   if(!codec->initialized)
     {
     codec->avctx->sample_rate = track_map->samplerate;
+#if LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(61, 0, 0)
+    codec->avctx->ch_layout.nb_channels = channels;
+#else
     codec->avctx->channels = channels;
+#endif

     codec->avctx->codec_id = codec->encoder->id;
     codec->avctx->codec_type = codec->encoder->type;
@@ -1229,7 +1237,11 @@
     /* One frame is: bitrate * frame_samples / (samplerate * 8) + 1024 */
     codec->chunk_buffer_alloc = ( codec->avctx->frame_size
                                   * sizeof( int16_t )
+#if LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(61, 0, 0)
+                                  * codec->avctx->ch_layout.nb_channels);
+#else
                                   * codec->avctx->channels);
+#endif
     codec->chunk_buffer = malloc(codec->chunk_buffer_alloc);

     if(trak->strl)

@RAMChYLD, this needs a minor touchup in qtpng.c to compile with gcc14:

diff -ru libquicktime-1.2.4.orig/plugins/png/qtpng.c libquicktime-1.2.4/plugins/png/qtpng.c
--- libquicktime-1.2.4.orig/plugins/png/qtpng.c 2011-01-07 15:40:46.000000000 +0100
+++ libquicktime-1.2.4/plugins/png/qtpng.c  2024-06-19 11:04:51.460483842 +0200
@@ -26,6 +26,7 @@
 #include <quicktime/colormodels.h>
 #include <png.h>
 #include <stdlib.h>
+#include <string.h>
 #include "qtpng.h"

 typedef struct

You can also grab the updated PKGBUILD and patch here: https://build.opensuse.org/package/show/home:aggraef:test/libquicktime

@RAMChYLD, seems to work fine with Gem for me. Thanks a bunch for taking over maintenance of the package, and for adding the necessary patches for modern ffmpeg support, I really appreciate it!

Integrated patch for ffmpeg5. Let me know if it works.