Package Details: librenms 1.43-1

Git Clone URL: https://aur.archlinux.org/librenms.git (read-only)
Package Base: librenms
Description: Autodiscovering PHP/MySQL-based network monitoring system.
Upstream URL: https://www.librenms.org/
Licenses: GPL3
Submitter: freaknils
Maintainer: dvzrv
Last Packager: Anthony25
Votes: 3
Popularity: 0.000587
First Submitted: 2015-12-14 12:03
Last Updated: 2018-10-07 19:08

Latest Comments

1 2 3 Next › Last »

dvzrv commented on 2018-11-24 14:40

Please note: I'm on updating the package, but want to try some other/new approaches to make using this application more safe. This might require a few more days depending on how fast I am. Sorry for the delay.

Anthony25 commented on 2018-10-07 21:35

@dvzrv: great, thanks!

dvzrv commented on 2018-10-07 21:28

@Anthony25: Yeah, I'd be up for it!

lukyjay commented on 2018-07-25 04:44

Build fails as dependency for freetype-config is not found.

Any idea how to fix this? Looks like freetype-config is an outdated package and should be replaced with pkg-config but I'm unsure how?

HeyCitizen commented on 2018-04-26 15:45

this PKGBUILD tries to install a package named php-mcrypt which does not exist, rather than selecting an existing package that provides 'php-mcrypt'

dvzrv commented on 2018-03-10 01:18

@Anthony25:

ln -sf /var/log/${pkgname} logs

should be in package() (not install(), sorry):

ln -sf "/var/log/${pkgname}" "${pkgdir}/usr/share/webapps/${pkgname}/logs"

Plus, you can add yourself as maintainer! ;-)

Anthony25 commented on 2018-03-09 23:29

@dvzrv: Thanks for the review.

I tried to fix it as much as I could. I just don't see what you mean by Do that in install() and use ${pkgdir}!.

dvzrv commented on 2018-03-05 11:53

@Anthony25: You're welcome. That's what I'm here for ;-) Sometimes it's easier to just start from scratch.

However, there are still some things to fix:

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=librenms#n8

Should be GPL3 (pacman -Ql licenses).

You can switch to https for url.

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=librenms#n11

source has to be unique ("${pkgname}-${pkgver}.tar.gz::<https://github.com/>${pkgname}/${pkgname}/archive/${pkgver}.tar.gz")

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=librenms#n33

Do that in install() and use ${pkgdir}!

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=librenms#n37

You can just install them in one go: install -d "$pkgdir"/{etc/{webapps/$pkgname,logrotate.d},usr/share/webapps/$pkgname,var/log/$pkgname} and fix the permissions using tmpfiles.d. Also, 775 is probably too permissive for the logs of such an application.

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=librenms#n42

All PKGBUILD functions are in ${srcdir} initially. No need to use it again. Still, cd should be the first thing to do, unless you have weird sources.

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=librenms#n45

If you are symlinking this file later on anyways, but it's just the default (an example file, I suppose?), why not just leave it there, or is the user supposed to modify this file? Also, use install -Dm644 instead of cp.

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=librenms#n56

A cleaner way would be to install this as a separate file.

P.S.: You got tab-poisening ;-)

https://aur.archlinux.org/cgit/aur.git/tree/librenms.sysusers?h=librenms#n3

I think it's not a good choice to set /usr/share/webapps/librenms as the user's $HOME. Leaving it empty is a better choice. https://www.freedesktop.org/software/systemd/man/sysusers.d.html#Home%20Directory

https://aur.archlinux.org/cgit/aur.git/tree/librenms.tmpfile?h=librenms#n2

Is that really needed? Does the application or the webserver need to modify files on your filesystem, apart from the logs? If not, don't use this!

Sorry for the many edits of this post. The new Markdown support still bugs me ;-)

Anthony25 commented on 2018-03-05 00:06

@dvzrv: thanks a lot for your review.

For my defense, all comments you've made were about something I've not written, but it is not an excuse as I did not change them.

I began to fix a lot of the issues your pointed, only the pear packages are still badly installed at the pkg installation. When I will find some time to create the 2 AUR packages needed for those, I will be able to add them as dependencies and remove the usage of pear. However, if anyone has some free time to create those packages, tell me and I will handle the changes on the librenms side as soon as possible.

dvzrv commented on 2018-03-04 17:31

"I changed the versioning system, so please force the package installation to upgrade."

@Anthony25: That's where you usually introduce an epoch: https://wiki.archlinux.org/index.php/PKGBUILD#epoch

Please re-read the Arch packaging standards: https://wiki.archlinux.org/index.php/Arch_packaging_standards