Arch Linux User Repository

I couldn't build this as of today because the path to the source tarball contains the repository name twice. Also, while wernerd/zrtpcpp works because project names on GitHub are apparently case-insensitive, the repo name is canonically uppercase, which I corrected as well.

With this patch applied it builds for me, just incase it's useful to anyone else before eventually probably getting updated by @pmattern:

diff --git a/PKGBUILD b/PKGBUILD
index c064a63..4ad36b5 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -9,11 +9,11 @@ pkgver=4.7.0
 pkgrel=3
 pkgdesc="A C++ implementation of Phil Zimmermann's ZRTP specification"
 arch=('i686' 'x86_64' 'aarch64')
-url='https://github.com/wernerd/zrtpcpp'
+url='https://github.com/wernerd/ZRTPCPP'
 license=('Apache-2.0')
 depends=('ccrtp')
 makedepends=('cmake')
-source=("$pkgname-$pkgver.tar.gz::${url}/ZRTPCPP/archive/$pkgver.tar.gz"
+source=("$pkgname-$pkgver.tar.gz::${url}/archive/$pkgver.tar.gz"
         type_fix.patch
         fix-emoji-handling.patch)
 b2sums=('ffa8bb3c4a18cacf5aa0da08dcbbef225564bece3f282308352d7c3dffc2265815fac287fe219d991acde2a4745fefb750bc634708f1fe26866dd2cb4f5ebc56'

The package/source url is broken for me and returns a HTTP 404 since this commit: https://aur.archlinux.org/cgit/aur.git/commit/?h=libzrtpcpp&id=672621c8bd171c571d68966e022a7fd41da64b17

Shouldn't it be:

source=("$pkgname-$pkgver.tar.gz::${url}/archive/$pkgver.tar.gz"

and:

source = libzrtpcpp-4.7.0.tar.gz::https://github.com/wernerd/zrtpcpp/archive/4.7.0.tar.gz

because zrtpcpp is already part of $url and is therefore added twice to the source url?

@pmattern is all yours now

I've got commits fixing the build and providing some more tiny improvements in a local clone and would be happy to push them.

For the time being I would surely maintain the package alongside ucommon, ccrtp and twinkle{,-git}. (I'm not really sure for how long, given that the whole GNU Telephony stack seems more or less dead. But I could make sure to hand the packages over to a proper maintainer in case I want to step down from maintaining them at some point.)

@dreieck do you plan to adopt and fix this package? There's a pending request and I'm searching a new maintainer for it

The compilation is currently broken. To fix it, you need to make changes to PKGBUILD:

diff --git a/PKGBUILD b/PKGBUILD
index 1744d96..b295d33 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -13,24 +13,27 @@ license=('GPL3')
 depends=('ccrtp')
makedepends=('cmake')
 source=("$pkgname-$pkgver.tar.gz::https://github.com/wernerd/ZRTPCPP/archive/$pkgver.tar.gz"
-        type_fix.patch)
+        type_fix.patch
+        EmojiBase32-fix.patch)
 b2sums=('ffa8bb3c4a18cacf5aa0da08dcbbef225564bece3f282308352d7c3dffc2265815fac287fe219d991acde2a4745fefb750bc634708f1fe26866dd2cb4f5ebc56'
-        '6c599f893815aa550d5c3de41470e0b7f72b76dd259baa918b1269353b387ef8732a6b8c0fb0d014f4e6b68f07284dbf8e0388b51cc1ba17c875671076c8dc56')
+        '6c599f893815aa550d5c3de41470e0b7f72b76dd259baa918b1269353b387ef8732a6b8c0fb0d014f4e6b68f07284dbf8e0388b51cc1ba17c875671076c8dc56'
+        'SKIP')

 prepare() {
   sed 's/lib64/lib/g' -i ZRTPCPP-${pkgver}/CMakeLists.txt
   patch -Np2 -i type_fix.patch
+  patch -Np2 -i EmojiBase32-fix.patch
 }

 build() {
   mkdir -p build
   cd build
  cmake ../ZRTPCPP-${pkgver} \
     -DCMAKE_INSTALL_PREFIX=/usr \
-     -DCMAKE_BUILD_TYPE=Release
+     -DCMAKE_BUILD_TYPE=Release \
+     -DCMAKE_POLICY_VERSION_MINIMUM=3.5
  cmake --build .
 }

 package() {
  cmake --install build --prefix "${pkgdir}"/usr
 }

And also create EmojiBase32-fix.patch:

diff --git a/zrtp/EmojiBase32.cpp b/zrtp/EmojiBase32.cpp
index 2bbde97..6835c9d 100644
--- a/src/ZRTPCPP-4.7.0/zrtp/EmojiBase32.cpp
+++ b/src/ZRTPCPP-4.7.0/zrtp/EmojiBase32.cpp
@@ -7,6 +7,8 @@

 #include <libzrtpcpp/EmojiBase32.h>

+#include <cstdint>
+
 // I used the information on this Unicode page http://unicode.org/emoji/charts/full-emoji-list.html
 /*
 Some technical details:

@svenihoney valid point. Thank you for taking your time to help, fixed.

If you are using cmake to build the packet, you should be aware that your package build fails if CMAKE_GENERATOR is set to something different than "Unix Makefiles", e.g. "Ninja".

To build your packet correctly in such a case, either add -G"Unix Makefiles" to the cmake call or let CMake handle the build correctly. A possible solution may be this:

diff --git a/PKGBUILD b/PKGBUILD
index 4554ee9..1744d96 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -28,10 +28,9 @@ build() {
   cmake ../ZRTPCPP-${pkgver} \
     -DCMAKE_INSTALL_PREFIX=/usr \
     -DCMAKE_BUILD_TYPE=Release
-  make
+  cmake --build .
 }

 package() {
-  cd build
-  make DESTDIR="${pkgdir}" install
+  cmake --install build --prefix "${pkgdir}"/usr
 }

@jonathon thank you very much. Applied the diff and learned about patch. For bigger packages I find makeflags useful to speed them up, but for this one you may be right.Cheers!

Here's a git diff that removes the implicit makedepend on git and puts type_fix.patch into the source array. It also removes the unnecessary make arguments:

diff --git a/PKGBUILD b/PKGBUILD
index e25e4d2..4554ee9 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -12,12 +12,14 @@ url='https://github.com/wernerd/ZRTPCPP'
 license=('GPL3')
 depends=('ccrtp')
 makedepends=('cmake')
-source=("$pkgname-$pkgver.tar.gz::https://github.com/wernerd/ZRTPCPP/archive/$pkgver.tar.gz")
-md5sums=('24bcaa5ee64083e9da76ee3cb68c90a3')
+source=("$pkgname-$pkgver.tar.gz::https://github.com/wernerd/ZRTPCPP/archive/$pkgver.tar.gz"
+        type_fix.patch)
+b2sums=('ffa8bb3c4a18cacf5aa0da08dcbbef225564bece3f282308352d7c3dffc2265815fac287fe219d991acde2a4745fefb750bc634708f1fe26866dd2cb4f5ebc56'
+        '6c599f893815aa550d5c3de41470e0b7f72b76dd259baa918b1269353b387ef8732a6b8c0fb0d014f4e6b68f07284dbf8e0388b51cc1ba17c875671076c8dc56')

 prepare() {
   sed 's/lib64/lib/g' -i ZRTPCPP-${pkgver}/CMakeLists.txt
-  git -C "${srcdir}/ZRTPCPP-${pkgver}" apply -v "${srcdir}/.."/*patch || git apply -v -p2 ../*.patch
+  patch -Np2 -i type_fix.patch
 }

 build() {
@@ -26,7 +28,7 @@ build() {
   cmake ../ZRTPCPP-${pkgver} \
     -DCMAKE_INSTALL_PREFIX=/usr \
     -DCMAKE_BUILD_TYPE=Release
-  make ${MAKEFLAGS:--j1}
+  make
 }

 package() {