Package Details: linux-thermaltake-rgb 0.2.0-1

Git Clone URL: https://aur.archlinux.org/linux-thermaltake-rgb.git (read-only, click to copy)
Package Base: linux-thermaltake-rgb
Description: Python usb daemon and controller for thermaltake rgb watercooling devices
Upstream URL: https://github.com/chestm007/linux_thermaltake_riing
Licenses: GPL2
Submitter: chestm007
Maintainer: chestm007
Last Packager: chestm007
Votes: 2
Popularity: 0.000000
First Submitted: 2018-12-02 10:42 (UTC)
Last Updated: 2019-03-06 11:03 (UTC)

Latest Comments

« First ‹ Previous 1 2

chestm007 commented on 2019-02-20 21:33 (UTC)

Hey, i've addressed everything except:

the whole $pkgdir/usr/share directory could be deleted from the package since files are deployed to their proper location anyway

I'm still a little new to packaging and cant find any documentation stating the correct way of doing that - if you can point me somewhere that would be amazing!

nicoulaj commented on 2019-02-15 13:30 (UTC) (edited on 2019-02-15 13:32 (UTC) by nicoulaj)

Thanks for packaging !

I have a few requests:

  • Can you add backup=('etc/linux_thermaltake_rgb/config.yml') ? otherwise the config will be overwritten with every update
  • A makedepends on git is needed, or it can't build in a clean chroot
  • Actually it would be even better to fetch a source tarball instead of using git to avoid a full clone of the repository, eg: source=('<https://github.com/chestm007/linux_thermaltake_riing/archive/>${pkgver}.tar.gz')
  • Last minor thing: the whole $pkgdir/usr/share directory could be deleted from the package since files are deployed to their proper location anyway