Package Details: liquidwar 5.6.5-2

Git Clone URL: https://aur.archlinux.org/liquidwar.git (read-only, click to copy)
Package Base: liquidwar
Description: A unique multiplayer wargame
Upstream URL: https://www.ufoot.org/liquidwar/
Licenses: GPL
Submitter: ilpianista
Maintainer: zaza
Last Packager: zaza
Votes: 15
Popularity: 0.000000
First Submitted: 2015-01-24 11:16
Last Updated: 2021-05-13 21:45

Latest Comments

zaza commented on 2021-02-14 17:19

Package doesn't compile now, at least on my machine. I've tried to fix it.

First problem is GCC10 and compile errors. It was fixed in Debian, so patch may be taken from them: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=957493 https://salsa.debian.org/games-team/liquidwar/-/blob/17a6f01fddc33eaa9abe348b8f6182a306cc2917/debian/patches/gcc10.patch (patch) https://github.com/ufoot/liquidwar5/pull/3 (merged pull request in upstream)

Second one is about building docs. For some reason doc building fails, so package can't be built, although technically compiled properly. Python fails on finding dtd file in doc/makedoc.py, looks like 3.7.1 change is the reason: https://docs.python.org/3/library/xml.sax.html "Changed in version 3.7.1: The SAX parser no longer processes general external entities by default to increase security. Before, the parser created network connections to fetch remote files or loaded local files from the file system for DTD and entities. The feature can be enabled again with method setFeature() on the parser object and argument feature_external_ges."

So, there are ways of fixing it: 1) disabling doc building (are they really required?), looks like setting PYTHON=no in build() helps. 2) patching doc/makedoc.py to ignore external references: parser=xml.sax.make_parser() + parser.setFeature(xml.sax.handler.feature_external_ges, False) parser.setContentHandler(handler) 3) fixing dtd issue properly, but I can't easily find a way to do it

I've made own pkgbuild with gcc10 fix and doc fix (method 2, with patching), but maybe disabling doc build may be better solution: https://gist.github.com/vladimir-g/85a0f4720e51d437d9b77cb0cb824b75 It builds, although I didn't test it completely

ilpianista commented on 2015-01-24 11:16

Moved from [extra]