Package Details: lite-xl 2.0.5-1

Git Clone URL: https://aur.archlinux.org/lite-xl.git (read-only, click to copy)
Package Base: lite-xl
Description: A lightweight text editor written in Lua
Upstream URL: https://lite-xl.github.io
Keywords: editor lua text
Licenses: MIT
Conflicts: lite
Provides: lite
Submitter: Terence
Maintainer: Terence (jgmdev)
Last Packager: jgmdev
Votes: 11
Popularity: 1.46
First Submitted: 2020-11-29 15:41 (UTC)
Last Updated: 2022-02-03 06:13 (UTC)

Latest Comments

yochananmarqos commented on 2022-04-12 18:05 (UTC)

Please do not enable wrap mode. All required dependencies are either in the repos or AUR:

# Comment to build non-jit version
_commit=bd36b44d615304b26e32fd11dc8b0f788fa795bf
if [ "$_commit" = "" ]; then
  depends=('agg' 'freetype2' 'lua52' 'pcre2' 'reproc' 'sdl2')
  source=("$pkgname-$pkgver.tar.gz::https://github.com/lite-xl/lite-xl/archive/v$pkgver.tar.gz")
  md5sums=('d7e0b2141a67725f75e93d45bd2d53f7')
else
  depends=('agg' 'freetype2' 'luajit' 'pcre2' 'reproc' 'sdl2')
  source=("$pkgname-$_commit.tar.gz::https://github.com/lite-xl/lite-xl/archive/${_commit}.zip")
  md5sums=('69a59c34ce201ec9071732b0f994a11c')
fi

Working PKGBUILD

alerque commented on 2022-02-03 12:39 (UTC) (edited on 2022-02-03 12:43 (UTC) by alerque)

My previous comment has still not been addressed, this is still missing dependencies to build.

alerque commented on 2021-12-25 10:58 (UTC)

This package is missing some dependencies, it does not build in a clean chroot with the dependencies listed. First it complains about cmake, which may be optional — but then it dies on not finding libagg. As a fallback it looks like it tries to download libagg via git, but that isn't a makedepends so it doesn't have that either.

redtide commented on 2021-10-25 10:10 (UTC)

@daurnimator reproc is part of the dependencies, it was introduced primarily to make work the LSP plugin and to provide sub-processes handling. There is a work in progress pull request to replace it with own code, so it will probably be removed in a next version.

daurnimator commented on 2021-09-27 13:58 (UTC)

Seems like the reproc dependency isn't used?

djmattyg007 commented on 2021-04-29 08:10 (UTC)

You should remove gendesk as a make dependency now :)

Terence commented on 2021-03-23 15:39 (UTC)

Thanks for all your input! The package is now using the repo's icon and I'm waiting for a new release to use its .desktop as well.

djmattyg007 commented on 2021-03-22 22:09 (UTC)

The .desktop entry has now also been committed as a standalone file to the repository:

https://github.com/franko/lite-xl/commit/30cdc35df5254c174b41f544118286ea670ccc91

djmattyg007 commented on 2021-03-22 02:19 (UTC)

As part of 1.16.5, an icon is now bundled with lite-xl:

https://github.com/franko/lite-xl/commit/12aeac3d2c9dc8fd7b54159b20734b3ff07c7c2e

It would be great if this could be used in the PKGBUILD so that the dependency on the original lite can be removed.

There is also now a defacto default .desktop entry. Unfortunately it's not stored as a standalone file in the repository, so we can't use it yet:

https://github.com/franko/lite-xl/commit/8567f6a7ee159ff29f72214328c73d8740c41036

I'm communicating with upstream to hopefully resolve this.

djmattyg007 commented on 2020-12-07 23:52 (UTC)

v1.13 has been released with some important path handling changes:

https://github.com/franko/lite-xl#building

Most noticebly, the path fix patch should hopefully no longer be necessary.

Terence commented on 2020-12-04 12:06 (UTC)

Do you reckon you'd be able to update the PKGBUILD to add the license file?

Of course, I was waiting for your answer to make sure I understood. It's updated now.

djmattyg007 commented on 2020-12-04 03:59 (UTC)

Yeah, I don't expect it to be an issue unless you do need to update it. If you do, you'll need to make sure the on-disk filename changes.

Do you reckon you'd be able to update the PKGBUILD to add the license file?

Terence commented on 2020-12-02 16:46 (UTC)

@djmattyg007 Really appreciate your detailed input :)

Ok so I get what you mean now. The thing is I don't expect this file to get updated. It's more of a workaround until the svg variant gets included into the project, in which case I will not have to download it this way.

Maybe it'd be more suiting to save it under $pkgname.svg.zip in case the lite packager also decides to add it.

djmattyg007 commented on 2020-12-01 01:33 (UTC)

Apparently my previous message was very long, so I just wanted to make sure you don't miss the second half. Please don't forget to click the "Show More" button!

djmattyg007 commented on 2020-12-01 01:32 (UTC)

Thanks for making those updates so quickly, I really appreciate it!

The trick with the non-versioned filename is to make use of the download filename prefix technique listed here, in the red warning box:

https://wiki.archlinux.org/index.php/PKGBUILD#source

So for example, instead of putting in the sources list:

"https://github.com/rxi/lite/files/4716765/lite.svg.zip"

You'd put this:

"4716765-lite.svg.zip::https://github.com/rxi/lite/files/4716765/lite.svg.zip"

This is assuming that a new version of the file would result in a new file ID in the github URL, and therefore it only needs to be re-downloaded whenever that changes. You'll then of course need to make sure that the rest of the PKGBUILD understands the change.

For some files, using the package's version number is prudent, even if it results in it being re-downloaded for each update. Separately-downloaded license files are an example of this.

Speaking of license files, I noticed that the software's license file isn't being installed into '/usr/share/licenses'. While usually unnecessary for most non-custom licenses, it is recommended for MIT and a few others, as noted here:

https://wiki.archlinux.org/index.php/PKGBUILD#license

It would be great if you could add that in too.

And yeah, I'll see what I can do about getting the maintainer of the 'lite' PKGBUILD to make some similar changes. It would be great to have them mostly consistent.

Terence commented on 2020-11-30 12:16 (UTC)

@djmattyg007 Thanks for your remarks, I included lua52 and gendesk (weird that lua52 wasn't in the original lite PKGBUILD I copied).

About the icon source, I think github doesn't save a file under the same url twice even if it was updated but please let me know if I'm wrong.

djmattyg007 commented on 2020-11-30 00:34 (UTC)

I was also unable to get this package to build without having 'lua52' installed. I added it as a core dependency, not just a make dependency, because I'm assuming it's also needed at runtime.

Another suggestion I have is to version the download filename for this source:

https://github.com/rxi/lite/files/4716765/lite.svg.zip

Right now, if the contents of that file ever change makepkg won't re-download it (because the file already exists on disk after the first run), and will just complain that the checksum doesn't match and abort. By versioning the filename on disk, you can increment the version as necessary and makepkg will re-download it as necessary.

djmattyg007 commented on 2020-11-30 00:27 (UTC)

Looks like this is missing a make dependency on 'gendesk'.