Package Details: llpp 42-1

Git Clone URL: https://aur.archlinux.org/llpp.git (read-only, click to copy)
Package Base: llpp
Description: opengl accelerated pdf viewer based on mupdf
Upstream URL: https://github.com/criticic/llpp
Keywords: mupdf opengl pdf viewer
Licenses: GPL3
Submitter: polyzen
Maintainer: stek
Last Packager: stek
Votes: 8
Popularity: 0.48
First Submitted: 2022-05-14 17:01 (UTC)
Last Updated: 2023-11-14 16:51 (UTC)

Dependencies (17)

Required by (0)

Sources (1)

Pinned Comments

cynik commented on 2022-11-10 19:17 (UTC)

it has been fixed: https://github.com/criticic/llpp/compare/fix-2

cynik commented on 2022-11-10 18:22 (UTC) (edited on 2022-11-10 18:42 (UTC) by cynik)

hmmm, i cannot reproduce @urldog 's problem, it seems to be using basically as much as it did before.

as far as the other issue goes, i remember mupdf updated last week, so maybe something changed again...

EDIT: yeah the API changed again: https://github.com/ArtifexSoftware/mupdf/commit/8aca9504370b68836da4fdae4de299df71945774

cynik commented on 2022-09-18 07:05 (UTC)

I have updated it to my fork at: https://github.com/criticic/llpp

Latest Comments

1 2 3 Next › Last »

txtsd commented on 2023-12-26 08:29 (UTC)

@urldog Could you post the entire log please?

urldog commented on 2023-12-26 05:07 (UTC) (edited on 2023-12-26 05:10 (UTC) by urldog)

trying to install this on arch running inside podman (distrobox) fails with this error:

(...)    
    : Running post-transaction hooks...
    (1/3) Arming ConditionNeedsUpdate...
    (2/3) Distrobox hook /etc/distrobox-post-hook.sh...
    (3/3) Distrobox hook /usr/share/libalpm/scripts/distrobox_post_hook.sh...
    ==> ERROR: Running makepkg as root is not allowed as it can cause permanent,
    catastrophic damage to your system.
     -> error making: ocaml-lablgl-exit status 10
    ==> ERROR: Running makepkg as root is not allowed as it can cause permanent,
    catastrophic damage to your system.
     -> error making: llpp-exit status 10
    error: target not found: ocaml-lablgl
     -> Failed to install the following packages. Manual intervention is required:
    ocaml-lablgl - exit status 10
    llpp - exit status 10
    exit status 1

It might be because podman is rootless and the install seems to be wanting to install things as root.

txtsd commented on 2023-11-10 17:28 (UTC)

Good job @temhelk!

@stek: I created a patch for you to apply so this package builds again. It's co-authored by @temhelk and credited as such. You could also add me as co-maintainer, and I can take care of updating this package. I maintain a bunch at ankylosaurus.

From d19e0fa02e3c7500dc2bb9da8f13f01e7b1bf8bc Mon Sep 17 00:00:00 2001
From: txtsd <code@ihavea.quest>
Date: Fri, 10 Nov 2023 22:52:56 +0530
Subject: [PATCH] upgpkg: llpp 41-4

Add patch to allow building

Co-authored-by: temhelk <temhelk@gmail.com>
Signed-off-by: txtsd <code@ihavea.quest>
---
 .SRCINFO                            |  4 +++-
 0001-fix-Allow-building-again.patch | 30 +++++++++++++++++++++++++++++
 PKGBUILD                            | 14 +++++++++++---
 3 files changed, 44 insertions(+), 4 deletions(-)
 create mode 100644 0001-fix-Allow-building-again.patch

diff --git a/.SRCINFO b/.SRCINFO
index 81bebe3..a84e0ad 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,7 +1,7 @@
 pkgbase = llpp
    pkgdesc = opengl accelerated pdf viewer based on mupdf
    pkgver = 41
-   pkgrel = 3
+   pkgrel = 4
    url = https://github.com/criticic/llpp
    arch = x86_64
    license = GPL3
@@ -24,6 +24,8 @@ pkgbase = llpp
    optdepends = unoconv: for llppac office conversion
    options = !strip
    source = git+https://github.com/criticic/llpp#branch=latest
+   source = 0001-fix-Allow-building-again.patch
    b2sums = SKIP
+   b2sums = 3d74eea6f6ac29ecae5a3055b70205b1e2601027f1f4473dadab595170d9f57a3d5948d6d6f9897ef5d60417998ef788d8242ea18612e8bd0e921520b2fc93df

 pkgname = llpp
diff --git a/0001-fix-Allow-building-again.patch b/0001-fix-Allow-building-again.patch
new file mode 100644
index 0000000..518126b
--- /dev/null
+++ b/0001-fix-Allow-building-again.patch
@@ -0,0 +1,30 @@
+From f12488495f8d562d63a745c036e9ae4c757f7bf1 Mon Sep 17 00:00:00 2001
+From: txtsd <code@ihavea.quest>
+Date: Fri, 10 Nov 2023 22:45:59 +0530
+Subject: [PATCH] fix: Allow building again
+
+Signed-off-by: txtsd <code@ihavea.quest>
+---
+ build.bash | 6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/build.bash b/build.bash
+index 0db5fbb..7830f6c 100755
+--- a/build.bash
++++ b/build.bash
+@@ -37,7 +37,11 @@ mudeps=('freetype2' 'gumbo' 'harfbuzz' 'libjpeg' 'libopenjp2' 'x11' 'zlib')
+ 
+ mkdir -p $outd/{$wsid,lablGL}
+ 
+-isfresh() { test "$(<$1.past)" = "$2"; } 2>/dev/null
++isfresh() {
++    test -f "$1.past" || return 1
++    test "$(<$1.past)" = "$2"
++} 2>/dev/null
++
+ 
+ mbt=${mbt:-release}
+ test -n "${gmk:-}" && gmk=false || gmk=true
+-- 
+2.42.1
+
diff --git a/PKGBUILD b/PKGBUILD
index bd28248..7d8fb1a 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,4 +1,5 @@
 # Maintainer: Florian Stecker <oss@florianstecker.net>
+# Contributor: txtsd <aur.archlinux@ihavea.quest>
 # Contributor: Sagnik Mandal <criticic>
 # Contributor: Daniel M. Capella <polyzen@archlinux.org>
 # Contributor: Eli Schwartz <eschwartz@archlinux.org>
@@ -6,7 +7,7 @@

 pkgname=llpp
 pkgver=41
-pkgrel=3
+pkgrel=4
 pkgdesc='opengl accelerated pdf viewer based on mupdf'
 arch=('x86_64')
 url=https://github.com/criticic/llpp
@@ -21,8 +22,15 @@ optdepends=('djvulibre: for llppac djvu conversion'
             'librsvg: for llppac svg conversion'
             'unoconv: for llppac office conversion')
 options=('!strip')
-source=("git+$cloneurl#branch=latest")
-b2sums=('SKIP')
+source=("git+$cloneurl#branch=latest"
+        "0001-fix-Allow-building-again.patch")
+b2sums=('SKIP'
+        '3d74eea6f6ac29ecae5a3055b70205b1e2601027f1f4473dadab595170d9f57a3d5948d6d6f9897ef5d60417998ef788d8242ea18612e8bd0e921520b2fc93df')
+
+prepare() {
+    cd $pkgname
+    patch -Np1 -i "../0001-fix-Allow-building-again.patch"
+}

 build() {
   cd $pkgname
-- 
2.42.1

temhelk commented on 2023-11-10 16:40 (UTC) (edited on 2023-11-10 16:41 (UTC) by temhelk)

I also have this "build failed" problem. I tried to investigate this (even though I'm not that familiar with bash) and I think I found what causes that issue.

The call to this function makes the script exit:

isfresh() { test "$(<$1.past)" = "$2"; } 2>/dev/null

And if I understand correctly it happens because it tries to read the content of the file "$1.past" that doesn't exist when you build it the first time.

After changing the function to that:

isfresh() {
    test -f "$1.past" || return 1
    test "$(<$1.past)" = "$2"
} 2>/dev/null

it seems to work and builds the application.

txtsd commented on 2023-11-09 03:27 (UTC)

Same error as @rvalles when building.

When trying to run the exiting installed version I get: cannot create context: incompatible header (1.23.4) and library (1.23.5) versions

rvalles commented on 2023-11-09 02:46 (UTC)

build failed

Seems to be near the top of the build script. Quite the useless choice of error string.

urldog commented on 2023-10-25 08:46 (UTC)

It installs fine, but when running it I get:

$ llpp llpp: error while loading shared libraries: libmupdf.so: cannot open shared object file: No such file or directory

Any idea why?

stek commented on 2023-09-30 01:39 (UTC)

The upstream patch https://github.com/criticic/llpp/pull/5 didn't work for me, so instead I made the minimal changes necessary to make it compile again (with ocaml 5.0.0-1 and libmupdf 1.23.3-4). It works for me now, but the fix did include ignoring some warnings, so your mileage may vary.

jooch commented on 2023-09-25 09:57 (UTC) (edited on 2023-09-25 09:58 (UTC) by jooch)

Build fails:

generating build/confstruct.ml keys.cmi wsi/x11/wsi.cmi File "_none_", line 1: Error (alert ocaml_deprecated_auto_include): OCaml's lib directory layout changed in 5.0. The unix subdirectory has been automatically added to the search path, but you should add -I +unix to the command-line to silence this alert (e.g. by adding unix to the list of libraries in your dune file, or adding use_unix to your _tags file for ocamlbuild, or using -package unix for ocamlfind). ocamlc -I build -I build/wsi/x11 -g -strict-sequence -strict-formats -alert @all -warn-error @A -c -o build/wsi/x11/wsi.cmi ./wsi/x11/wsi.mli failed build failed

otakutyrant commented on 2022-11-11 11:49 (UTC)

The bug is fixed. Good job!