New version, tagged 1.0, removes that feature, so that it remains "simple", unix-like :P
Search Criteria
Package Details: lockx 20080829-1
Package Actions
| Package Base: | lockx |
|---|---|
| Description: | A simple X locker, heavily based on slock. |
| Upstream URL: | http://bugflux.org/category/dev/ |
| Category: | x11 |
| Licenses: | |
| Submitter: | nDray |
| Maintainer: | None |
| Last Packager: | None |
| Votes: | 8 |
| First Submitted: | 2008-03-16 23:43 |
| Last Updated: | 2008-09-06 10:15 |
Dependencies (1)
Required by (0)
Sources
Latest Comments
Comment by nDray
Comment by delroth
Newer versions of slock seem to already use DPMS anyway:
if(len == 0 && DPMSCapable(dpy)) {
DPMSEnable(dpy);
DPMSForceLevel(dpy, DPMSModeOff);
}
(from slock-0.9)
Comment by nDray
I called myself dumb, I wasn't assuming you regarded me as such, though it's perfectly in place! :P
No offense taken whatsoever, that is a really stupid mistake... And it indeed will easily cause a segfault in i686 as well in x86_64.
I would guess no one was (should be) using this, though! It is easy to solve, but that code is not very polished anyway. I stopped using this because, with my new laptop, setting DPMS programmatically seems to be problematic...
Comment by delroth
Did not mean to offense you btw, was just a bit alarmed after discovering this :P . Also, the segfault only happened in lockx compiled for x86_64 so far, but I'm pretty sure that with enough backspace presses it could happen with the i686 version too (enough to make buffer[len] go below the top of the stack.
Comment by nDray
I am the dumb dev, and I agree with delroth, twice. First because there is a bug, in fact, and also beucase I no longer use/mantain this program!
Comment by delroth
Anyone who cares about the security of their locked session should not use this software. Simply press backspace, then any key. Boom, lockx segfaults.
This happens because the author of lockx does not seem to compile his software with warnings enabled. gcc easily detects that "--len < 0" is always false when "len" is an unsigned int.
Please use slock or xtrlock instead of this program.