Arch Linux User Repository

@Ppjet6: Thanks for your contribution. I'm back from vacation and applied your patches.

Hi there, is there any way somebody looks at my patches? Can I get feedback on these? I also don't mind being granted commit rights if you don't have time to do it yourself. Thanks!

eimis, the source package has been updated, you should probably use this one.

I do have other patches though, it seems the stages submodule wasn't included correctly, (that find command is copying every file to the same folder). Also it is apparently missing lua-argparse as a dependency.

From ddb83d5a1ea5816ea4c5c085216980ecab99a9a8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maxime=20=E2=80=9Cpep=E2=80=9D=20Buquet?= <archlinux@bouah.net>
Date: Sun, 23 Sep 2018 20:42:16 +0100
Subject: [PATCH 1/2] Fix stages submodule not being created
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maxime “pep” Buquet <archlinux@bouah.net>
---
 .SRCINFO | 2 +-
 PKGBUILD | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/.SRCINFO b/.SRCINFO
index 19f438f..8e56ca0 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,7 +1,7 @@
 pkgbase = luacheck
        pkgdesc = A tool for linting and static analysis of Lua code.
        pkgver = 0.23.0
-       pkgrel = 1
+       pkgrel = 2
        url = https://github.com/mpeterv/luacheck
        arch = any
        license = MIT
diff --git a/PKGBUILD b/PKGBUILD
index b26bfd3..9ecc452 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,7 +3,7 @@

 pkgname=luacheck
 pkgver=0.23.0
-pkgrel=1
+pkgrel=2
 pkgdesc="A tool for linting and static analysis of Lua code."
 arch=('any')
 url="https://github.com/mpeterv/luacheck"
@@ -15,8 +15,9 @@ sha256sums=('b4edf3a7702519502696d4ac7372ed1bd6a82ded63bf81f2b1d7e9b37711be2b')

 package() {
   cd "$pkgname-$pkgver"
-  mkdir -p "$pkgdir/usr/share/lua/5.3/luacheck"
-  install -Dm644 $(find "src/luacheck" -type f) "$pkgdir/usr/share/lua/5.3/luacheck"
+  mkdir -p "$pkgdir/usr/share/lua/5.3/luacheck/stages"
+  find src/luacheck -maxdepth 1 -type f -exec install -Dm644 {} "$pkgdir/usr/share/lua/5.3/luacheck" \;
+  find src/luacheck/stages -maxdepth 1 -type f -exec install -Dm644 {} "$pkgdir/usr/share/lua/5.3/luacheck/stages" \;
   install -Dm755 "bin/luacheck.lua" "$pkgdir/usr/bin/luacheck"
   install -Dm644 LICENSE "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
 }
-- 
2.19.0

From ace5ceaa8527dd469d92218a36513ecd80772637 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maxime=20=E2=80=9Cpep=E2=80=9D=20Buquet?= <archlinux@bouah.net>
Date: Sun, 23 Sep 2018 20:43:25 +0100
Subject: [PATCH 2/2] Add lua-argparse as dependency
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maxime “pep” Buquet <archlinux@bouah.net>
---
 .SRCINFO | 3 ++-
 PKGBUILD | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/.SRCINFO b/.SRCINFO
index 8e56ca0..f7d221e 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,12 +1,13 @@
 pkgbase = luacheck
        pkgdesc = A tool for linting and static analysis of Lua code.
        pkgver = 0.23.0
-       pkgrel = 2
+       pkgrel = 3
        url = https://github.com/mpeterv/luacheck
        arch = any
        license = MIT
        depends = lua
        depends = lua-filesystem
+       depends = lua-argparse
        optdepends = lua-lanes: for parallel checking
        source = https://github.com/mpeterv/luacheck/archive/0.23.0.tar.gz
        sha256sums = b4edf3a7702519502696d4ac7372ed1bd6a82ded63bf81f2b1d7e9b37711be2b
diff --git a/PKGBUILD b/PKGBUILD
index 9ecc452..5e4f431 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,12 +3,12 @@

 pkgname=luacheck
 pkgver=0.23.0
-pkgrel=2
+pkgrel=3
 pkgdesc="A tool for linting and static analysis of Lua code."
 arch=('any')
 url="https://github.com/mpeterv/luacheck"
 license=('MIT')
-depends=('lua' 'lua-filesystem')
+depends=('lua' 'lua-filesystem' 'lua-argparse')
 optdepends=('lua-lanes: for parallel checking')
 source=("https://github.com/mpeterv/$pkgname/archive/$pkgver.tar.gz")
 sha256sums=('b4edf3a7702519502696d4ac7372ed1bd6a82ded63bf81f2b1d7e9b37711be2b')
-- 
2.19.0

Ppjet6 after your patch it won't launch

$ luacheck 
lua: /usr/share/lua/5.3/luacheck/bin/luacheck.lua:2: module 'luacheck.main' not found:
    no field package.preload['luacheck.main']
    no file '/tmp/luacheck/pkg/luacheck/usr/share/lua/5.3/luacheck/src/luacheck/main.lua'
    no file '/tmp/luacheck/pkg/luacheck/usr/share/lua/5.3/luacheck/src/luacheck/main/init.lua'
    no file '/usr/share/lua/5.3/luacheck/main.lua'
    no file '/usr/share/lua/5.3/luacheck/main/init.lua'
    no file '/usr/lib/lua/5.3/luacheck/main.lua'
    no file '/usr/lib/lua/5.3/luacheck/main/init.lua'
    no file './luacheck/main.lua'
    no file './luacheck/main/init.lua'
    no file '/usr/lib/lua/5.3/luacheck/main.so'
    no file '/usr/lib/lua/5.3/loadall.so'
    no file './luacheck/main.so'
    no file '/usr/lib/lua/5.3/luacheck.so'
    no file '/usr/lib/lua/5.3/loadall.so'
    no file './luacheck.so'
stack traceback:
    [C]: in function 'require'
    /usr/share/lua/5.3/luacheck/bin/luacheck.lua:2: in main chunk
    [C]: in ?

Patches for you!

I am not entirely sure why the sh dependency is required. It's provided by bash which is available in base. Maybe somebody can point me to the place that says such a package is not assumed to be present?

The second one is an update to 0.22.1.

From b9bd580c4ee4bf954fe46df8cec97b14383310ae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maxime=20=E2=80=9Cpep=E2=80=9D=20Buquet?= <archlinux@bouah.net>
Date: Sun, 9 Sep 2018 18:39:11 +0100
Subject: [PATCH 1/2] Remove sh dependency
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maxime “pep” Buquet <archlinux@bouah.net>
---
 .SRCINFO | 1 -
 PKGBUILD | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/.SRCINFO b/.SRCINFO
index cd680b4..67b4643 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -7,7 +7,6 @@ pkgbase = luacheck
        license = MIT
        depends = lua
        depends = lua-filesystem
-       depends = sh
        source = https://github.com/mpeterv/luacheck/archive/0.21.1.tar.gz
        source = luacheck
        sha256sums = 88e0c1c9106a4f8c2995b1ee6e83ce8b02ec2796557e8603235dd160b2fb5eb4
diff --git a/PKGBUILD b/PKGBUILD
index e85513e..ce6f83f 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -7,7 +7,7 @@ pkgdesc="A tool for linting and static analysis of Lua code."
 arch=('any')
 url="https://github.com/mpeterv/luacheck"
 license=('MIT')
-depends=('lua' 'lua-filesystem' 'sh')
+depends=('lua' 'lua-filesystem')
 source=("https://github.com/mpeterv/$pkgname/archive/$pkgver.tar.gz"
         "luacheck")
 sha256sums=('88e0c1c9106a4f8c2995b1ee6e83ce8b02ec2796557e8603235dd160b2fb5eb4'
-- 
2.18.0

From 5aed25fd0a7979445e7babd6223f43457482d661 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maxime=20=E2=80=9Cpep=E2=80=9D=20Buquet?= <archlinux@bouah.net>
Date: Sun, 9 Sep 2018 18:40:36 +0100
Subject: [PATCH 2/2] Update to 0.22.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maxime “pep” Buquet <archlinux@bouah.net>
---
 .SRCINFO | 6 +++---
 PKGBUILD | 7 ++++---
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/.SRCINFO b/.SRCINFO
index 67b4643..6d271b3 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,15 +1,15 @@
 pkgbase = luacheck
        pkgdesc = A tool for linting and static analysis of Lua code.
-       pkgver = 0.21.1
+       pkgver = 0.22.1
        pkgrel = 1
        url = https://github.com/mpeterv/luacheck
        arch = any
        license = MIT
        depends = lua
        depends = lua-filesystem
-       source = https://github.com/mpeterv/luacheck/archive/0.21.1.tar.gz
+       source = https://github.com/mpeterv/luacheck/archive/0.22.1.tar.gz
        source = luacheck
-       sha256sums = 88e0c1c9106a4f8c2995b1ee6e83ce8b02ec2796557e8603235dd160b2fb5eb4
+       sha256sums = 46fef6860f5cd1c432cb4ae760f231f09aa286193271f0c550d9323e451da3af
        sha256sums = fefc290dbea67b126b2fbdc0ae08f990b6561ec97f0c86bb53fbdd5cb27de201

 pkgname = luacheck
diff --git a/PKGBUILD b/PKGBUILD
index ce6f83f..086871e 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,7 +1,7 @@
 # Maintainer: Pieter Goetschalckx <3.14.e.ter at gmail dot com>

 pkgname=luacheck
-pkgver=0.21.1
+pkgver=0.22.1
 pkgrel=1
 pkgdesc="A tool for linting and static analysis of Lua code."
 arch=('any')
@@ -10,8 +10,6 @@ license=('MIT')
 depends=('lua' 'lua-filesystem')
 source=("https://github.com/mpeterv/$pkgname/archive/$pkgver.tar.gz"
         "luacheck")
-sha256sums=('88e0c1c9106a4f8c2995b1ee6e83ce8b02ec2796557e8603235dd160b2fb5eb4'
-            'fefc290dbea67b126b2fbdc0ae08f990b6561ec97f0c86bb53fbdd5cb27de201')

 package() {
   cd "$pkgname-$pkgver"
@@ -21,3 +19,6 @@ package() {
   install -Dm755 "$srcdir/luacheck" "$pkgdir/usr/bin/luacheck"
   install -Dm644 LICENSE "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
 }
+
+sha256sums=('46fef6860f5cd1c432cb4ae760f231f09aa286193271f0c550d9323e451da3af'
+            'fefc290dbea67b126b2fbdc0ae08f990b6561ec97f0c86bb53fbdd5cb27de201')
-- 
2.18.0

Ok, done.

Could you please fix the package to install under /usr/share/lua/5.3, like other lua packages? It's also missing sh dependency and the licence (MIT and BSD licences must always be installed due to unique copyright notices).

http://pastebin.com/9aRqSL4J