Arch Linux User Repository

Done. Thx for the note @Elmar !

Hey, maltego have a new version, 4.3.1, it's possible to update de PKGBUILD ? (de new hash for deb file is 9f7493a557522b72e12fd6390001be6f882a0be1f25872eef2bcdf082bbef5c6)

Hi @theguy147,

thanks a lot for this !

AS for the chmod g-w - if I recall correctly - I've included that command because at the time I've noticed that excatly those affected folders were group writeable, but TBH I've never checked that again. I've changed the command to what you're suggesting.

I've also removed the Windows specific files you've mentioned. makepkg itself can care about removing the empty directories, so the last find was not necessary.

Thanks again for your help in improving the package. Cheers !

Thx for this package! I do have two comments though:

1) Group Permissions not set correctly

chmod g-w "$pkgdir"/usr{,/bin,/share{,/applications,"/$pkgname",/pixmaps}}

While that line looks pretty fancy, it doesn't do everything what it's supposed to IMHO. It does correctly remove the group writing permissions from the expanded directories but not from the files inside like:

- ./usr/share/pixmaps/maltego.png
- ./usr/share/applications/maltego.desktop
- ./usr/bin/maltego
- ./usr/bin/maltego_memory_config

All these files are still group writable after the installation.

Is there any reason not to use the following line instead? Are there any files that should be group- or world writable in the package?

chmod -R go-w "$pkgdir"

2) Unnecessary Files included in package

I do understand that this package is based on the deb-Archive by Paterva themselves. Unfortunately it seems like they just include everything inside like e.g. all the files only needed for Microsoft Windows. Surely the Windows files don't have to be included in this package and on every machine installing it (unless Paterva does some weird loadlibrary stuff or similar that I haven't detected yet). IMO at least the dll- and exe-Files should be excluded (and also empty directories that result from it):

- ./maltego/usr/share/maltego/platform/lib/nbexec.exe
- ./maltego/usr/share/maltego/platform/lib/nbexec64.exe
- ./maltego/usr/share/maltego/platform/lib/nbexec.dll
- ./maltego/usr/share/maltego/platform/lib/nbexec64.dll
- ./maltego/usr/share/maltego/platform/modules/lib/amd64/jnidispatch-nb.dll
- ./maltego/usr/share/maltego/platform/modules/lib/x86/jnidispatch-nb.dll
- ./maltego/usr/share/maltego/ide/modules/lib/extbrowser64.dll
- ./maltego/usr/share/maltego/ide/modules/lib/extbrowser.dll
- ./maltego/usr/share/maltego/bin/maltego.exe

Maybe something like this could be included to remove them?

find "$pkgdir" -regex ".*\.\(exe\|dll\)$" -type f -delete
find "$pkgdir" -type d -empty -delete

Thx for flagging @bekedbeans; I totally missed that :)

Hey @Kr1ss, no worries, I'm glad someone takes care of this!

Since I'm not using this package much these days, I don't think I would be much help in the maintenance. But thanks for the offer, if anything changes I'd be happy to help out in the future. :)

Thank you very much @imrehg, also for noticing me of the new release.

I wasn't aware of your package. If you're interested in co-maintaining this one, I'd be happy to give you access. :)

PS I just read your merge request. This has been accepted amazingly fast, so hat tip @freswa.

While updating my "casefile" package (https://aur.archlinux.org/packages/casefile/) just noticed this one. It seems like it's now the same stuff (basically the same package was done twice). I will submit a merge request, to delete my (older) one and transfer the votes to this, as it seems more popular. Cheers!

No worries @Kr1ss; thanks for taking over :)

Thx for maintaining so far @DescartesHorse !

Cheers !