Arch Linux User Repository

Please use a checksum. It's not good to use a SKIP whenever there is a tarball release

diff --git a/PKGBUILD b/PKGBUILD
index 51cb919..ab3865b 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -32,7 +32,7 @@ optdepends=(

 options=(!debug)
 source=($url/archive/refs/tags/$pkgver.tar.gz)
-b2sums=(SKIP)
+b2sums=('c2e1255f02899a6a3cd9fbfb7097859a69ce3f660510d9e411c4856286a9d42f9a02ae3338e109f49c724415415a2bc9303840b3d0216a1db89ec6574e839c61')

 build() {
   arch-meson ${pkgname}-$pkgver build

The latest update replaces the fixed b2sums with SKIP while still using a tagged GitHub release tarball.

Is there a specific reason for dropping the checksum? Re-adding it would improve integrity verification.

very good package, congratulations to the maintainer!

@radiolin

Please change the arch from any to x86_64 as there is an ELF produced. Also, please add glibc, hicolor-icon-theme, and pango; these were discovered using namcap. Also, please remove the meson configure line. No need to configure meson with a setup and therefore no need for the --no-pager.

diff --git a/PKGBUILD b/PKGBUILD
index 9cef402..c7746d2 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -2,16 +2,19 @@

 pkgname=mangojuice
 pkgver=0.8.6
-pkgrel=1
+pkgrel=2
 pkgdesc="A convenient alternative to GOverlay for configuring MangoHud"
-arch=(any)
+arch=(x86_64)
 url="https://github.com/radiolamp/${pkgname}"
 license=(GPL-3.0-or-later)
 depends=(
   glib2
+  glibc
   gtk4
+  hicolor-icon-theme
   libadwaita
   libgee
+  pango
   mangohud
   fontconfig
 )
@@ -33,7 +36,6 @@ b2sums=(29e4f4ebfdd54204fb7c20831212f9e4724bc90feb1bcdbedf4a8efdf85baadd25608d19

 build() {
   arch-meson ${pkgname}-$pkgver build
-  meson configure  build --no-pager
   meson compile -C build
 }

I apologize that this happened with the update, now I’m solving the problem of making it look beautiful not only in gnome and I’m in a hurry to make a tag, since it’s possible that the package will be compiled today by the maintainer from Alt Linux.

Thanks, fixed it

==> WARNING: Skipping verification of source file PGP signatures.

==> Validating source files with b2sums...

    0.6.1.tar.gz ... FAILED

==> ERROR: One or more files did not pass the validity check!

error: failed to download sources for 'mangojuice-0.6.1-1': 

error: packages failed to build: mangojuice-0.6.1-1

Спасибо за совет, поправил. Да я разрабочик, на данный момент в аур добавил по сути по быстрому для тестов и по этому не заморачивался с правельными конструкциями. Но на данный момент уже сделал тег и теперь должно работать как задуманно

Please don't invent a pkgver. See PKGBUILD: pkgver and VCS package guidelines: The pkgver() function. Use a static commit. If you're the developer, add a tag and use that. Otherwise, if you want the package to pull the latest commit, submit a VCS package called mangojuice-git.

This is missing the dependency on mangohud and fails to build as vala is missing from makedepends(). There's also a dependency on vulkan-tools for running vkcube via the Test button that could be optional.

The license is 'GPL-3.0-or-later'. See PKGBUILD: license

Users should not normally have the debug option enabled in their makepkg.conf. Do not explicitly do it in a PKGBUILD.

The url array is invalid as the variable used does not exist. I do not use variables in the url array so it can be copied and pasted into a browser.

It seems English may not be your first language. I translated the Russian and came up with the following for the pkgdesc: "A convenient alternative to GOverlay for configuring MangoHud"

PKGBUILD diff:

diff --git a/PKGBUILD b/PKGBUILD
index 049b7ea..1f2482b 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,25 +1,34 @@
-# Maintainer: Radiolin <anton.osi2011@gmail.com>
+# https://aur.archlinux.org/packages/mangojuice
+groups=('modified')

 pkgname=mangojuice
-pkgver=0.4.4.78dd5a0
+pkgver=r27.78dd5a0
 pkgrel=1
-pkgdesc="Gui settings mangohud"
+pkgdesc="A convenient alternative to GOverlay for configuring MangoHud"
 arch=(x86_64)
-url="https://github.com/radiolamp/${_pkgname%-git}"
-license=(GPL-3.0)
+url="https://github.com/radiolamp/mangojuice"
+license=(GPL-3.0-or-later)
 depends=(
   glib2
   gtk4
   libadwaita
   libgee
+  mangohud
+  vulkan-tools
 )
 makedepends=(
   git
   meson
+  vala
 )
-options=(!debug)
-source=("git+https://github.com/radiolamp/mangojuice.git") #tag=$pkgver
-b2sums=(SKIP)
+_commit=78dd5a0dff6a59c952b221ee581e90c06651edde
+source=("git+https://github.com/radiolamp/mangojuice.git#commit=${_commit}")
+b2sums=('84e7077bc47d42bfe7a049311bdb20d438d325cdfc4d4ea2c05af6f092466a90c3123ce57512653c50a3c9efaf6905436fe366d493e4d2d97f1f2e5ea780f706')
+
+pkgver() {
+  cd "$pkgname"
+  printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
+}

 build() {
   arch-meson "$pkgname" build