Arch Linux User Repository

@ChrisMorgan: Thanks for the feedback, I've updated my Github repo. Mind having a look at it before I push it to AUR?

• The conduit-archlinux git source is superfluous: it’s an exact copy of this repository (same Git ref), so you’ve already got those files and should use them directly; just enumerate them in source array (and the checksumss).

• CARGO_INCREMENTAL=1 is an extremely odd thing to specify. If anything (though I wouldn’t bother), you might want to go out of your way to disable incremental compilation.

• The environment variables file seems to be mostly obsolete and super misleading because of the conflicts between it and config.toml. I think that CONDUIT_CONFIG is the only variable in it that is still doing anything. I recommend (a) removing /etc/conduit/config; (b) setting CONDUIT_CONFIG in the service file; and (c) considering renaming /etc/conduit/config.toml to /etc/conduit.toml, in line with the upstream suggestion when you run Conduit without CONDUIT_CONFIG set.

• You’re trying to use /var/conduit/db as the database path (ineffectively, I think, per the previous point, though I haven’t yet started this thing to confirm). This is not a good path: per the Filesystem Hierarchy Standard, “Applications must generally not add directories to the top level of /var. Such directories should only be added if they have some system-wide implication, and in consultation with the FHS mailing list.” It should be within /var/lib, and indeed config.toml (which comes from upstream) contains the value /var/lib/conduit, a much better path.

• Strongly consider normalising everything on either “conduit” (which requires just renaming this package, the name conduit isn’t claimed) or “matrix-conduit” (which requires renaming quite a few things; see in part conduit/debian/).

• Consider replacing the service file in this repository with a patch against conduit/debian/matrix-conduit.service; or at the least, copy the improvements made in that location.

• Might be nice to use a DynamicUser, though it might be a better idea there to wait until Conduit adopts that style as a recommendation. (I’m not sure what changes this might entail in sysusers and tmpfiles config.)

• Weakly consider not copying the sample config TOML file in, but rather shipping it in /usr/share/doc/conduit/ (including “example” in its basename), leaving the file in /etc as a more minimal stub with a reference to that path. server_name and database_path are all that are required, but the sample config also overrides port (from 8000 to 6167), max_request_size (from 20MiB to 20MB) and trusted_servers (from [] to ["matrix.org"]).

Some of my suggestions are mutually incompatible, I know.

Thanks! I've added config.toml to the backup list.

Hey there! The config.toml file currently gets overwritten by every update to this package. Since it is meant to contain configuration, it should probably keep user-made changes to it. It looks like the "backup" entry already contains "config", but not "config.toml"