Package Details: mdbook-git 0.4.12.r0.ge6629cd7-2

Git Clone URL: https://aur.archlinux.org/mdbook-git.git (read-only, click to copy)
Package Base: mdbook-git
Description: Create book from markdown files, like Gitbook but implemented in Rust
Upstream URL: https://github.com/rust-lang-nursery/mdBook
Licenses: MPL2
Conflicts: mdbook
Provides: mdbook
Submitter: FabioLolix
Maintainer: flipee
Last Packager: flipee
Votes: 1
Popularity: 0.000000
First Submitted: 2018-06-03 15:18 (UTC)
Last Updated: 2021-08-11 21:37 (UTC)

Dependencies (3)

Required by (20)

Sources (1)

Latest Comments

alerque commented on 2021-08-12 07:34 (UTC)

Looks great to me now, thanks for the fixes.

I don't think it matters for this yet because nothing out there specifies a minimum version of mdbook as a dependency, but one thing you can always do in VCS packages is set provides=("${pkgname%-git}=$pkgver"). This way they provide an actual version, not just the package name. Then if/when something comes along that needs a newer version than the stable package they will actually be able to find it in the -git packages via depends=('mdbook>=x.y.z'). Again may or may not be useful for this one someday because Arch's rolling style usually means the latest versions are assumed, just a tip you can always use for VCS and bin packages that provide something other than themselves.

flipee commented on 2021-08-11 21:38 (UTC)

I fixed an issue one of the other packagers added just before dropping the comment here.

Yeah... I rewrote it now just following the new guidelines.

Ooo one more thing. I just noticed you stuffed the cargo fetch in the pkgver() function!

copy/paste distraction. =P

Thanks again.

alerque commented on 2021-08-10 07:12 (UTC)

Ooo one more thing. I just noticed you stuffed the cargo fetch in the pkgver() function! Please don't do that. It needs to be in prepare().

alerque commented on 2021-08-10 07:05 (UTC) (edited on 2021-08-10 07:05 (UTC) by alerque)

Hey Flipee, you seem to have looked at an old version of the [community] mdbook package. I fixed an issue one of the other packagers added just before dropping the comment here. The link I provided is to the current trunk version. The notable difference is that need to avoid using cargo run like that in the build. That is causing a complete rebuild of the entire app from scratch—just after having built it.

Additionally there are two two variables you can export (both of them for build() and one of them again for check() that will make the PKGBUILD much more robust as an AUR package. Again see the Wiki link. The variables are not needed for [community] packages because they are always built in chroots, but many AUR users and even package helpers don't do that and the fixing those two env vars will save quite a few failures for people that have their user environment customized (such as defaulting to the nightly toolchain).

Lastly, having a makedepends on cargo instead of rust is just a wee bit more future-proof.

flipee commented on 2021-08-09 21:41 (UTC)

@alerque Done. Thanks.

alerque commented on 2021-08-05 21:17 (UTC)

P.S. If you want help getting this fixed up please feel free to add me as a co-maintainer.

alerque commented on 2021-08-05 21:16 (UTC)

There is now quite a bit of info in Rust package guidelines including quite a few details skipped over in this packaging.

While you are at review the [community] package for differences like the shell completion functions you are missing here.

FabioLolix commented on 2020-08-18 17:14 (UTC)

Nope, it is not my fault, both pkgbuild and .srcinfo have 0.4.2.r0.gf6768b816-1 as version https://aur.archlinux.org/cgit/aur.git/commit/?h=mdbook-git&id=6b11007fdee1f1aad85991498c8fb53f03d71104

You have this issue because upstream developers made the 0.4.2, then deleted it and made it again, and git use hash instead of sequential revisions.

Force install version 0.4.2.r0.gf6768b816-1

a172 commented on 2020-08-18 14:12 (UTC)

The committed PKGFILE has pkgver=0.4.2.r0.gf6768b816, but the pkgver() only produces 0.4.2.r0.gf6768b8 (an additional byte in the hash). This throws off AUR helpers. For example:

$ auracle sync
mdbook-git 0.4.2.r0.gf6768b8-1 -> 0.4.2.r0.gf6768b816-1