Arch Linux User Repository

Hello,

The build with x86_64-w64-mingw32-gcc (GCC) 11.2.0 fails. This is the diff I used in the pkgbuild to fix to compilation error for unknown symbols M_PI and M_SQRT1_2. This caused by the -std=c++14 compile option.

diff --git a/PKGBUILD b/PKGBUILD
index cca8e57..7fa3c0a 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -24,7 +24,7 @@ prepare() {
sed -i "s|IMPORTLIB = \$(TARGET).lib|IMPORTLIB = \$(TARGET).dll.a|g" Makefile.mingw
sed -i 's/#include "..\\x86\\x86.h"/#include "..\/x86\/x86.h"/' Source/LibJXR/image/sys/strcodec.h
rm Source/LibJXR/common/include/guiddef.h
-  sed -i "s,WIN32_CFLAGS =,WIN32_CFLAGS = -fpermissive -D__MINGW64_TOOLCHAIN__," Makefile.mingw
+  sed -i "s,WIN32_CFLAGS =,WIN32_CFLAGS = -fpermissive -D__MINGW64_TOOLCHAIN__ -D_USE_MATH_DEFINES," Makefile.mingw
sed -i "58iWIN32_CXXFLAGS += -std=c++14" Makefile.mingw
sed -i -e "s,#ifdef __GNUC__,#ifdef WHATEVER," -e "s,_MSC_VER,WINVER," Source/OpenEXR/IlmImf/ImfSystemSpecific.h
}

hello,

the import lib is unusable partly because you build the static and shared lib in the same folder and different defines are needed to export the symbols

I could successfully link with the .dll.a with the following diff:

also the patch from community to unbundle libs is interesting because it could speed up the build

diff --git a/PKGBUILD b/PKGBUILD
index acde8f1..92502e6 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -31,9 +31,9 @@ prepare() {
 build() {
   for _arch in ${_architectures}; do
     rm -rf FreeImage-${_arch}
-    cp -r FreeImage FreeImage-${_arch}
-    pushd FreeImage-${_arch}
-    make \
+    cp -r FreeImage FreeImage-${_arch}-static
+    pushd FreeImage-${_arch}-static
+    make libFreeImage.a \
       CC=${_arch}-gcc \
       CXX=${_arch}-g++ \
       LD=${_arch}-g++ \
@@ -41,8 +41,12 @@ build() {
       AR=${_arch}-ar \
       DLLTOOL=${_arch}-dlltool \
       FREEIMAGE_LIBRARY_TYPE="STATIC" \
+      LDFLAGS="-static" \
       -f Makefile.mingw
-    make \
+    popd
+    cp -r FreeImage FreeImage-${_arch}
+    pushd FreeImage-${_arch}
+    make FreeImage.dll \
       CC=${_arch}-gcc \
       CXX=${_arch}-g++ \
       LD=${_arch}-g++ \
@@ -50,6 +54,7 @@ build() {
       AR=${_arch}-ar \
       DLLTOOL=${_arch}-dlltool \
       FREEIMAGE_LIBRARY_TYPE="SHARED" \
+      LDFLAGS="-shared -Wl,--out-implib,libFreeImage.dll.a" \
       -f Makefile.mingw
     popd
   done  
@@ -58,12 +63,13 @@ build() {

 package() {
   for _arch in ${_architectures}; do
-    cd ${srcdir}/FreeImage-${_arch}
     install -d "${pkgdir}"/usr/${_arch}/{lib,bin,include}
-    install -m755 Dist/FreeImage.dll "${pkgdir}"/usr/${_arch}/bin/
-    install -m644 Dist/FreeImage.dll.a "${pkgdir}"/usr/${_arch}/lib/libFreeImage.dll.a
-    install -m644 Dist/libFreeImage.a "${pkgdir}"/usr/${_arch}/lib/
-    install -m644 Dist/FreeImage.h   "${pkgdir}"/usr/${_arch}/include/
+    cd ${srcdir}/FreeImage-${_arch}-static
+    install -m644 libFreeImage.a "${pkgdir}"/usr/${_arch}/lib/
+    cd ${srcdir}/FreeImage-${_arch}
+    install -m755 FreeImage.dll "${pkgdir}"/usr/${_arch}/bin/
+    install -m644 FreeImage.dll.a "${pkgdir}"/usr/${_arch}/lib/libFreeImage.dll.a
+    install -m644 Source/FreeImage.h   "${pkgdir}"/usr/${_arch}/include/
     ${_arch}-strip --strip-unneeded "$pkgdir"/usr/${_arch}/bin/*.dll
     ${_arch}-strip -g "$pkgdir"/usr/${_arch}/lib/*.a
   done

hello, I need a patch. ps: I think the values shouldn't exceed the char range in the first place, what you're doing is just accepting them and truncate from the int to char range.

Fix can be found here: https://sourceforge.net/p/freeimage/bugs/267/

I'm getting this error during build. Anyone has any ideas how to fix this? ==================================== ------------------------------------ Source/LibRawLite/./internal/dcraw_common.cpp: In member function ‘void LibRaw::vng_interpolate()’: Source/LibRawLite/./internal/dcraw_common.cpp:3964:3: error: narrowing conversion of ‘128’ from ‘int’ to ‘signed char’ inside { } [-Wnarrowing] }, chood[] = { -1,-1, -1,0, -1,+1, 0,+1, +1,+1, +1,0, +1,-1, 0,-1 }; ^ Source/LibRawLite/./internal/dcraw_common.cpp:3964:3: error: narrowing conversion of ‘136’ from ‘int’ to ‘signed char’ inside { } [-Wnarrowing] Source/LibRawLite/./internal/dcraw_common.cpp:3964:3: error: narrowing conversion of ‘128’ from ‘int’ to ‘signed char’ inside { } [-Wnarrowing] Source/LibRawLite/./internal/dcraw_common.cpp:3964:3: error: narrowing conversion of ‘136’ from ‘int’ to ‘signed char’ inside { } [-Wnarrowing] Source/LibRawLite/./internal/dcraw_common.cpp:3964:3: error: narrowing conversion of ‘128’ from ‘int’ to ‘signed char’ inside { } [-Wnarrowing] Source/LibRawLite/./internal/dcraw_common.cpp:3964:3: error: narrowing conversion of ‘136’ from ‘int’ to ‘signed char’ inside { } [-Wnarrowing] Source/LibRawLite/./internal/dcraw_common.cpp: In member function ‘void LibRaw::adobe_coeff(const char*, const char*)’: Source/LibRawLite/./internal/dcraw_common.cpp:7269:3: error: narrowing conversion of ‘65535’ from ‘int’ to ‘short int’ inside { } [-Wnarrowing] }; ^ Source/LibRawLite/./internal/dcraw_common.cpp:7269:3: error: narrowing conversion of ‘65535’ from ‘int’ to ‘short int’ inside { } [-Wnarrowing] make: *** [Makefile.mingw:107: Source/LibRawLite/./internal/dcraw_common.o] Error 1 ==> ERROR: A failure occurred in build(). Aborting...

Thanks, but I'm getting an odd error and the only thing makepkg says is it happens in package()

@Schala Sorry for the late response, but you're right, the PKGBUILD now renames FreeImage.dll.a to libFreeImage.dll.a.

Should be libFreeImage.dll.a, not FreeImage.dll.a

mingw-w64-crt should be listed as depends instead of mingw-w64-gcc which should be added to makedepends