Arch Linux User Repository

Thank you, should be fixed now

check() fails for minify 2.23.9-1:

==> Starting check()...
go: downloading github.com/tdewolff/test v1.0.11
ok      github.com/tdewolff/minify/v2   0.035s
# github.com/tdewolff/minify/v2/bindings/js
bindings/js/minify.go:131:31: cannot use aspMinifier (variable of struct type "github.com/tdewolff/minify/v2/html".Minifier) as minify.Minifier value in argument to m.Add: "github.com/tdewolff/minify/v2/html".Minifier does not implement minify.Minifier (method Minify has pointer receiver)
bindings/js/minify.go:135:35: cannot use phpMinifier (variable of struct type "github.com/tdewolff/minify/v2/html".Minifier) as minify.Minifier value in argument to m.Add: "github.com/tdewolff/minify/v2/html".Minifier does not implement minify.Minifier (method Minify has pointer receiver)
bindings/js/minify.go:139:30: cannot use tmplMinifier (variable of struct type "github.com/tdewolff/minify/v2/html".Minifier) as minify.Minifier value in argument to m.Add: "github.com/tdewolff/minify/v2/html".Minifier does not implement minify.Minifier (method Minify has pointer receiver)
bindings/js/minify.go:140:36: cannot use tmplMinifier (variable of struct type "github.com/tdewolff/minify/v2/html".Minifier) as minify.Minifier value in argument to m.Add: "github.com/tdewolff/minify/v2/html".Minifier does not implement minify.Minifier (method Minify has pointer receiver)
bindings/js/minify.go:141:38: cannot use tmplMinifier (variable of struct type "github.com/tdewolff/minify/v2/html".Minifier) as minify.Minifier value in argument to m.Add: "github.com/tdewolff/minify/v2/html".Minifier does not implement minify.Minifier (method Minify has pointer receiver)
FAIL    github.com/tdewolff/minify/v2/bindings/js [build failed]
?       github.com/tdewolff/minify/v2/bindings/py   [no test files]
ok      github.com/tdewolff/minify/v2/cmd/minify    0.004s
ok      github.com/tdewolff/minify/v2/css   0.008s
ok      github.com/tdewolff/minify/v2/html  0.008s
ok      github.com/tdewolff/minify/v2/js    0.042s
ok      github.com/tdewolff/minify/v2/json  0.004s
ok      github.com/tdewolff/minify/v2/minify    0.003s
ok      github.com/tdewolff/minify/v2/svg   0.007s
ok      github.com/tdewolff/minify/v2/xml   0.004s
FAIL
==> ERROR: A failure occurred in check().    ==> Starting check()...

@tdewolff Works now, thanks for fixing!

Thanks marek22k, should be fixed now!

Mhh, after the update I cannot build it anymore:

==> Making package: minify 2.23.2-1 (Di 29 Apr 2025 13:00:43 UTC)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Downloading v2.23.2.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 7569k    0 7569k    0     0  4180k      0 --:--:--  0:00:01 --:--:--  9.8M
==> Validating source files with sha256sums...
    v2.23.2.tar.gz ... Passed
==> Extracting sources...
  -> Extracting v2.23.2.tar.gz with bsdtar
==> Starting prepare()...
==> Starting build()...
==> Starting check()...
ok      github.com/tdewolff/minify/v2   0.060s
?       github.com/tdewolff/minify/v2/bindings/js   [no test files]
?       github.com/tdewolff/minify/v2/bindings/py   [no test files]
--- FAIL: TestCreateTasks (0.00s)
    --- FAIL: TestCreateTasks/a.js_=>_ (0.00s)
    main_test.go:53: unexpected a.js => a.js
    --- FAIL: TestCreateTasks/dir/b.js_=>_ (0.00s)
    main_test.go:53: unexpected dir/b.js => dir/b.js
    --- FAIL: TestCreateTasks/dir_=>_ (0.00s)
    main_test.go:53: unexpected dir/b.js => dir/b.js
FAIL
FAIL    github.com/tdewolff/minify/v2/cmd/minify    0.004s
ok      github.com/tdewolff/minify/v2/css   0.010s
ok      github.com/tdewolff/minify/v2/html  0.009s
ok      github.com/tdewolff/minify/v2/js    0.048s
ok      github.com/tdewolff/minify/v2/json  0.004s
ok      github.com/tdewolff/minify/v2/minify    0.004s
ok      github.com/tdewolff/minify/v2/svg   0.009s
ok      github.com/tdewolff/minify/v2/xml   0.004s
FAIL
==> ERROR: A failure occurred in check().
    Aborting...

Thanks Nestor, this should be fixed now :-)

Hi since your last change, I got a

go: downloading golang.org/x/sys v0.16.0
-linkmode requires external (cgo) linking, but cgo is not enabled
==> ERROR: A failure occurred in build().
Aborting...

Any clue on how to solve this ?

thanks alot, that fix worked =) the default seems to be 1, so we didn't needed to set CGO_ENABLED=1 explicitly, we just had problems with it being set to 0.

I've pushed out a fix, can you please test it @ahoehne?

Hi @ahoehne, there is no C code in this library and thus CGO is not required to build this package. Disabling CGO has some benefits I forgot...

The problem is that using the PIE buildmode on a Raspberry requires CGO regardless. Is there a way to use an if-statement in makepkg depending on the platform? Or we could just enable CGO anyways...