Package Details: minigalaxy 1.3.1-1

Git Clone URL: https://aur.archlinux.org/minigalaxy.git (read-only, click to copy)
Package Base: minigalaxy
Description: A simple GOG client for Linux
Upstream URL: https://sharkwouter.github.io/minigalaxy
Keywords: client galaxy games gaming GOG
Licenses: GPL-3.0-or-later AND CC-BY-3.0
Submitter: sharkwouter
Maintainer: yochananmarqos
Last Packager: yochananmarqos
Votes: 31
Popularity: 1.11
First Submitted: 2019-12-25 12:18 (UTC)
Last Updated: 2024-12-13 02:38 (UTC)

Latest Comments

1 2 3 Next › Last »

yochananmarqos commented on 2022-10-04 16:09 (UTC)

@Deewiant @Anagastes: I'll just skip the tests for now.

Anagastes commented on 2022-10-04 11:42 (UTC)

@yochananmarqos

I can confirm the behaviour.

I also had en_US commented out in locale.gen.

I have now commented it in and the build works.

Deewiant commented on 2022-10-04 09:24 (UTC)

@yochananmarqos It's not about whether the locale is currently set in the environment, but about whether it's available on the system at all. If en_US.UTF-8 is commented out in /etc/locale.gen then it won't work.

Anyway it's an upstream issue, though you can patch some workaround here if you wish.

Der_Chefkoch commented on 2022-10-03 19:10 (UTC)

I can confirm, the enabled locale en_US.UTF-8 allows the build.

yochananmarqos commented on 2022-10-02 16:11 (UTC) (edited on 2022-10-02 16:12 (UTC) by yochananmarqos)

@Deewiant: Try adding this to the check() function:

export LC_ALL=C.UTF-8

or

export LANG=en_US.UTF-8

Deewiant commented on 2022-10-02 15:52 (UTC)

These tests all set:

config.locale = "en_US.UTF-8"

If that locale is not present on the system, the tests fail.

Anagastes commented on 2022-09-30 14:13 (UTC) (edited on 2022-09-30 14:13 (UTC) by Anagastes)

@yochananmarqos

I have now looked at some documentation and this error regarding the locale should only occur if no locale is set.

But in my environment it is set correctly.

#locale
LANG=de_DE.UTF-8
LC_CTYPE="de_DE.UTF-8"
LC_NUMERIC=de_DE.UTF-8
LC_TIME=de_DE.UTF-8
LC_COLLATE="de_DE.UTF-8"
LC_MONETARY=de_DE.UTF-8
LC_MESSAGES="de_DE.UTF-8"
LC_PAPER=de_DE.UTF-8
LC_NAME=de_DE.UTF-8
LC_ADDRESS=de_DE.UTF-8
LC_TELEPHONE=de_DE.UTF-8
LC_MEASUREMENT=de_DE.UTF-8
LC_IDENTIFICATION=de_DE.UTF-8
LC_ALL=

And even if I modify the said file and directly deposit "de_DE.UTF-8", there is the error.

    def __init__(self, config: Config, api: 'Api', download_manager: DownloadManager, name="Minigalaxy"):
        current_locale = config.locale
        default_locale = locale.getdefaultlocale()[0]
        if current_locale == '':
            locale.setlocale(locale.LC_ALL, (default_locale, 'de_DE.UTF-8'))
        else:
            try:
                locale.setlocale(locale.LC_ALL, (current_locale, 'de_DE.UTF-8'))
            except NameError:
                locale.setlocale(locale.LC_ALL, (default_locale, 'de_DE.UTF-8'))
        Gtk.ApplicationWindow.__init__(self, title=name)

Once again the result

ERROR: test3_init (test_ui_window.TestWindow)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/andre/.cache/yay/minigalaxy/src/minigalaxy-1.2.2/tests/test_ui_window.py", line 92, in test3_init
    test_window = Window(api=api, config=config, download_manager=MagicMock())
  File "/home/andre/.cache/yay/minigalaxy/src/minigalaxy-1.2.2/tests/test_ui_window.py", line 22, in passthrough2
    return func(*args, **kwargs)
  File "/home/andre/.cache/yay/minigalaxy/src/minigalaxy-1.2.2/minigalaxy/ui/window.py", line 36, in __init__
    locale.setlocale(locale.LC_ALL, (current_locale, 'de_DE.UTF-8'))
  File "/usr/lib/python3.10/locale.py", line 620, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting

Anagastes commented on 2022-09-29 08:31 (UTC)

@yochananmarqos

Hm, I have now gone through the individual branches, testing, unstable and stable... (whereby unstable corresponds most closely to Arch) the same error everywhere.

I know it's a lot to ask, but maybe test it in a manjaro vm? :S

yochananmarqos commented on 2022-09-28 18:20 (UTC)

@Anagastes @Der_Chefkoch: I can't reproduce that in a clean chroot.

Der_Chefkoch commented on 2022-09-28 18:15 (UTC)

@Anagastes - Same Error