Package Details: minikube-git 0.28.2.r55.gbed9aabaf-1

Git Clone URL: https://aur.archlinux.org/minikube-git.git (read-only)
Package Base: minikube-git
Description: Minikube is a tool that makes it easy to run Kubernetes locally.
Upstream URL: https://github.com/kubernetes/minikube
Keywords: kubernetes minikube
Licenses: Apache
Conflicts: minikube
Provides: minikube
Submitter: petertrotman
Maintainer: petertrotman
Last Packager: petertrotman
Votes: 0
Popularity: 0.000000
First Submitted: 2018-03-20 12:10
Last Updated: 2018-09-20 12:17

Required by (1)

  • skaffold (requires minikube) (optional)

Sources (1)

Latest Comments

intelfx commented on 2018-10-03 13:49

How do you suggest completions should be installed?

I provided a patch to PKGBUILD that performs it in a standard way. Please take a look. Also there are quite a few improvements to the build process that you could take advantage of.

What's the reason for not including it?

The Arch packaging guidelines tell so: https://wiki.archlinux.org/index.php/PKGBUILD#license

If the license changes for whatever reason, you will have to change the license=() line anyway.

petertrotman commented on 2018-09-20 12:32

Hi @intelfx

Thanks for the feedback. I've make the top three changes you suggested.

How do you suggest completions should be installed? I personally get them from sourcing minikube completion zsh in my .zshrc but I don't want to be managing rc files from an aur package.

Regarding the license, I personally don't see the harm in including it and means that it will be properly updated if the license changes for whatever reason. What's the reason for not including it?

Cheers

intelfx commented on 2018-09-05 17:52

Hey.

Please:

  • strip v from $pkgver
  • drop make from makedeps and glibc from deps (they are in base-devel and base respectively)
  • replace kubectl-bin with kubectl in optdepends
  • install completions
  • do not install a copy of the license (the Apache license is a common one)

Or, preferably, apply a patch with above-mentioned fixes and a few improvements: http://ix.io/1m2S

petertrotman commented on 2018-03-23 12:37

Thank you for your feedback - I have made the appropriate changes.

The sources were all in the source array, however the build step requires the repository to be in a folder src/k8s.io/minikube (for GOPATH reasons), so the PKGBUILD was using git to clone from already-downloaded source into that path. I have changed it so we're using standard copies and moves to make the intent more obvious.

I have moved the build step into the build() function as you suggested.

Svenstaro commented on 2018-03-23 11:26

A couple of notes:

1) You should put all sources into the sources array. Don't run git clone manually inside prepare. 2) Have a separate build() step where you run make.