Package Details: mmconneqt-git 0.1.1.r7.g66ac6a5-1

Git Clone URL: https://aur.archlinux.org/mmconneqt-git.git (read-only, click to copy)
Package Base: mmconneqt-git
Description: A simple qt based wrapper gui for ModemManager
Upstream URL: https://gitlab.com/Antiquete/mmconneqt
Keywords: modem modemmanager qt sms telephony
Licenses: GPL3
Conflicts: mmconneqt
Provides: mmconneqt
Submitter: Antiquete
Maintainer: Antiquete
Last Packager: Antiquete
Votes: 1
Popularity: 0.000000
First Submitted: 2023-04-15 00:38 (UTC)
Last Updated: 2023-04-21 10:18 (UTC)

Latest Comments

Antiquete commented on 2023-04-16 02:34 (UTC)

@yochananmarqos: Thanks for advice. Fixed.

yochananmarqos commented on 2023-04-15 20:13 (UTC) (edited on 2023-04-15 20:19 (UTC) by yochananmarqos)

PKGBUILD critique:

  • This is not an 'any' package, it contains ELF files
  • Do not use unnecessary variables. Keep it simple
  • There are no optional dependencies. Do not leave unused arrays
  • If this is a ModemManager GUI, would it not follow that it depends on modemmanager?
  • Remove the leading 'v' in the pkgver. See VCS package guidelines
  • Create the build directory in a prepare function. Always use mkdir -p so there is no error if it exists
  • Do not build in the package function, it uses a fakeroot environment and is only used for installing files. Use a build function instead
  • Do not install icons directly in /usr/share/icons/. There are subfolders for a reason. The icon should only be installed in /usr/share/pixmaps/ since there are no separate sizes

Improved PKGBUILD (will self-destruct in one month)