Arch Linux User Repository

Hi everyone,

I think the path for 'ambfor' and 'surf' has changed. I get the following error during packaging:

cannot stat 'src/ambfor/ambfor': No such file or directory
cannot stat 'src/surf/surf': No such file or directory

Both these subfolders are not created by the build-process. I found binaries with these filenames in the same folders as molden, though.

I was having a bunch of problems unrelated to GCC 10; here's the diff for the changes:

diff --git a/PKGBUILD b/PKGBUILD
index f3eeaf7..6325166 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,57 +1,44 @@
 # Maintainer: Dan Maftei <dan.maftei@gmail.com>
 pkgname="molden"
 pkgver=6.5
-pkgrel=1
+pkgrel=2
 pkgdesc="A program for molecular and electronic structure visualization"
 arch=('i686' 'x86_64')
 url="http://www.cmbi.ru.nl/molden/"
 license=('custom')
-groups=()
-depends=('mesa' 'glu')
-makedepends=(
-    'vi'
-    'gcc-fortran'
-    'xorgproto'
-    'libx11'
-    'mesa'
-    'glu'
-)
+depends=('gcc-libs' 'glu' 'libx11' 'libxmu')
+makedepends=('gcc-fortran' 'xorgproto' 'vi')
 optdepends=(
    'openbabel: to create 2D images of the molecules in a .sdf file'
    'wget: to fetch PDB from rcsb.org'
 )
 provides=('molden')
-conflicts=()
-replaces=()
-backup=()
-options=()
-install=
-changelog=
 source=(
     "ftp://ftp.cmbi.umcn.nl/pub/molgraph/molden/$pkgname$pkgver.tar.gz"
 )
-noextract=()
 md5sums=('97bfffd55e166ca3a9fbddee111993ff')

-build() {
+prepare() {
   cd "molden$pkgver"
-  # Patch Makefile for surf utility to reflect 
-  # the replacement of missing makedepend 
+  # Patch Makefile for surf utility to reflect
+  # the replacement of missing makedepend
   sed -i 's/@.*makedepend.*$/@ \$(CC) \$(INCLUDE) -M \$(SRCS) \> makedep/' src/surf/Makefile
-  
+
   # Patch to compile with gfortran 10
   # Contributed by Panadestein on 5/31/2020
   sed -i 's/FFLAGS = -g ${AFLAG}/& -fallow-argument-mismatch/g' makefile
   sed -i 's/FFLAGS = -c -g -ffast-math -funroll-loops -O3/& -fallow-argument-mismatch/g' src/ambfor/makefile
+}
+
+build() {
+  cd "molden$pkgver"
   make
 }

 package() {
   cd "molden$pkgver"
   install -t "$pkgdir/usr/bin/"  -Dm755 bin/{molden,gmolden}
-  install -t "$pkgdir/usr/lib/$pkgname/" -Dm755 src/ambfor/ambfor src/ambfor/ambmd src/surf/surf  
-  install -t "$pkgdir/usr/share/doc/$pkgname" -Dm755 doc/figures.ps.Z  doc/manual.ps.Z doc/manual.txt.Z  
-  install -t "$pkgdir/usr/share/licenses/$pkgname/" -Dm755 CopyRight COMMERCIAL_LICENSE REGISTER     
+  install -t "$pkgdir/usr/lib/$pkgname/" -Dm755 bin/{ambfor,ambmd,surf}
+  install -t "$pkgdir/usr/share/doc/$pkgname" -Dm755 doc/figures.ps.Z  doc/manual.ps.Z doc/manual.txt.Z
+  install -t "$pkgdir/usr/share/licenses/$pkgname/" -Dm755 CopyRight COMMERCIAL_LICENSE REGISTER
 }
-
-

Hi everyone.

In case you are facing compilations errors due to some new features introduced in GCC 10, I suggest you to add the -fallow-argument-mismatch compilation flag to gfortran. This action needs to be performed in the main makefile and in the ambfor makefile. The issue is partially explained in the GCC 10 release notes:

https://gcc.gnu.org/gcc-10/changes.html

I guess a patch to the PKGBUILD file can be written, parsing both makefiles and adding the compilation flag.

Nice day to all of you.

Edit

These are the lines that need to be added to the build() function of the PKGBUILD:

sed -i 's/FFLAGS = -g ${AFLAG}/& -fallow-argument-mismatch/g' makefile

sed -i 's/FFLAGS = -c -g -ffast-math -funroll-loops -O3/& -fallow-argument-mismatch/g' ambfor/makefile

Hi, Dan!

xproto is now called xorgproto. Could you please change?

Thanks a bunch!

Package just upgraded, Thank you!

Hello, It's seems that the md5sum of the package for version 6.1 it's wrong:

md5sum molden6.1.tar.gz 7bc693baddd615f554a08f452c5282dd molden6.1.tar.gz

if download fails, s/ftp.cmbi.ru.nl/ftp.cmbi.umcn.nl/ might help.

New version in the upstream (5.8) is fixed. I do not know if anybody wrote to the developers but they've released it 2018-05-24. Flagging "out of date." Tested the build. Only thing that is needed is to change pkgver and pkgrel to 5.8 and 1 respectively in the PKGBUILD.

arjun_karol - thx, solution works. Did anybody wrote to the Molden developer team?

Thanks arjun_karol I did as suggested and it is now working. I patched the original source.