Arch Linux User Repository

This package doesn't support people who have failed to read the wiki page https://wiki.archlinux.org/index.php/Makepkg, or cannot interpret error messages.

@ntfc thanks!

I ran into compilation errors in src/Log.cxx like

[38/45] Compiling C++ object mpdscribble.p/src_Log.cxx.o
FAILED: mpdscribble.p/src_Log.cxx.o
c++ -Impdscribble.p -I. -I.. -Isrc -I../src -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Wpedantic -std=c++17 -O0 -g -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Wmissing-declarations -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wundef -fno-threadsafe-statics -fmerge-all-constants -Wcomma-subscript -Wextra-semi -Wmismatched-tags -Woverloaded-virtual -Wsign-promo -Wvolatile -Wvirtual-inheritance -Wno-non-virtual-dtor -fvisibility=hidden -pthread -MD -MQ mpdscribble.p/src_Log.cxx.o -MF mpdscribble.p/src_Log.cxx.o.d -o mpdscribble.p/src_Log.cxx.o -c ../src/Log.cxx
../src/Log.cxx: In function ‘const char* log_date()’:
../src/Log.cxx:48:13: error: ‘time’ was not declared in this scope
   48 |         t = time(nullptr);
      |             ^~~~
../src/Log.cxx:35:1: note: ‘time’ is defined in header ‘<ctime>’; did you forget to ‘#include <ctime>’?
   34 | #include <syslog.h>
  +++ |+#include <ctime>
   35 | #endif
../src/Log.cxx:49:15: error: ‘localtime’ was not declared in this scope
   49 |         tmp = localtime(&t);
      |               ^~~~~~~~~
../src/Log.cxx:49:15: note: ‘localtime’ is defined in header ‘<ctime>’; did you forget to ‘#include <ctime>’?
../src/Log.cxx:55:14: error: ‘strftime’ was not declared in this scope
   55 |         if (!strftime(buf, sizeof(buf), "%Y-%m-%dT%H:%M:%S%z", tmp)) {
      |              ^~~~~~~~
../src/Log.cxx:55:14: note: ‘strftime’ is defined in header ‘<ctime>’; did you forget to ‘#include <ctime>’?
[44/45] Compiling C++ object mpdscribble.p/src_Scrobbler.cxx.o
ninja: build stopped: subcommand failed.

Turns out a #include <ctime> is missing in src/Log.cxx:

--- a/PKGBUILD  2022-08-23 18:28:06.857963493 +0200
+++ b/PKGBUILD  2022-08-23 18:30:07.367832734 +0200
@@ -23,6 +23,7 @@

 prepare() {
   cd "${pkgname}"-"${pkgver}"
+  sed -i "27i #include <ctime>" src/Log.cxx
   DESTDIR="${pkgdir}" meson build \
      --prefix=/usr \
      --sysconfdir=/etc

@BachoSeven - thanks for testing! I'll add it to the next version.

That error on the -git build doesn't suggest anything immediately, but I'll try and reproduce over the weekend.

Edit - I can't reproduce. Building in a clean chroot works fine for me.

That works as expected on this package, thanks!

However, when I tried to add it to mpdscribble-git, which I created since upstream had recently added unreleased support for the XDG specification, it gave me the following error:

gen 12 23:56:01 thinkfra mpdscribble[359728]: basic_string::_M_construct null not valid

Perhaps there is something with the -git version that somehow requires the home directory to be set to something else than /? I mention this because when I instead add manually the user with sudo useradd -r -s /usr/bin/nologin mpdscribble, it works, and that command generates this in /etc/passwd:

mpdscribble:x:969:969::/home/mpdscribble:/usr/bin/nologin

while the default chosen by leaving it up to sysusers appears to be

mpdscribble:x:969:969::/:/usr/bin/nologin

@BachoSeven do you want to test?

u mpdscribble - - -
m mpdscribble audio

@jasonwryan I have two mpd instances set up, one as user and one as system since the user one is for local music while the system one connects via WebDAV to a homeserver, as described in the wiki. I don't think I would be able to do so with two user instances, I tried but there were some issues iirc.

@BachoSeven is the instance not sufficient to run as a user?

@jasonwryan since the system-wide .service file requires an mpdscribble user, could adding a .sysusers file to this package be useful?

Great little program, thanks for packaging it!

One note for people coming from older versions (0.22 especially), you have to modify your configuration a tiny bit. Remove the two header lines that begin with [, namely:

[mpdscribble]
and 
[last.fm]

No other changes are required.

I got the confirmation of what I said by at least two TU:

• https://lists.archlinux.org/pipermail/aur-general/2021-July/036436.html
• https://lists.archlinux.org/pipermail/aur-general/2021-July/036437.html