Package Details: mycorrhiza-git 1.15.1.r4.gda84a76-3

Git Clone URL: https://aur.archlinux.org/mycorrhiza-git.git (read-only, click to copy)
Package Base: mycorrhiza-git
Description: Filesystem and git-based wiki engine written in Go using mycomarkup (development version)
Upstream URL: https://github.com/bouncepaw/mycorrhiza
Keywords: git mycomarkup wiki
Licenses: AGPL-3.0-or-later
Conflicts: mycorrhiza
Provides: mycorrhiza
Submitter: kseistrup
Maintainer: kseistrup
Last Packager: kseistrup
Votes: 1
Popularity: 0.90
First Submitted: 2023-08-25 13:26 (UTC)
Last Updated: 2025-04-22 11:34 (UTC)

Dependencies (3)

Required by (0)

Sources (1)

Latest Comments

novenary commented on 2025-01-06 15:52 (UTC)

Yep, it builds now. The rest is pretty inconsequential to be fair.

Thank you!

kseistrup commented on 2025-01-06 15:47 (UTC)

@novenary Thanks for your comments, let's see if you can live with the newly pushed PKGBUILD.

novenary commented on 2025-01-06 15:37 (UTC) (edited on 2025-01-06 15:40 (UTC) by novenary)

Hi!

There are a few problems with your PKGBUILD:

  • test -t 1 causes the build to fail when stdout is not a TTY (for example, it's been failing in aurto for me); to be honest, I'm not sure why it's even there, did you encounter an issue that warranted its introduction?
  • Your use of && after mkdir is redundant: if that failed, then the error would be caught and the build would abort anyway (which is what's happening with test -t right now); if && was working as expected, non-zero status codes would be ignored which is definitely not what we want here.
  • It makes no sense to implement RFC-0023 here—that linker flag is already in the default makepkg.conf. In general doing this in individual PKGBUILDs without a very good reason doesn't seem like a good idea (also, it handles i386, but that isn't listed in $arch).
  • There are no tests, so right now all go test does is waste CPU cycles.

Thanks for packaging this, looking forward to at least the first point being fixed.