Package Details: ncspot-git 1.2.0-2

Git Clone URL: https://aur.archlinux.org/ncspot-git.git (read-only, click to copy)
Package Base: ncspot-git
Description: Cross-platform ncurses Spotify client written in Rust, inspired by ncmpc and the likes.
Upstream URL: https://github.com/hrkfdn/ncspot
Keywords: curses spotify
Licenses: BSD-2-Clause
Conflicts: ncspot
Provides: ncspot
Submitter: nicoulaj
Maintainer: gugylucky
Last Packager: gugylucky
Votes: 10
Popularity: 0.83
First Submitted: 2019-03-12 18:47 (UTC)
Last Updated: 2024-11-12 01:42 (UTC)

Required by (0)

Sources (1)

Latest Comments

1 2 Next › Last »

ykelvis commented on 2024-11-19 15:41 (UTC)

hi there, a small thing: you forgot git (makedepends) in recent commit.

HurricanePootis commented on 2024-11-11 23:11 (UTC)

Hello, this package could do with the following changes:

  1. Follow the Rust package guidelines. This means removing rust from makepends() setting the propper RUSTUP_TOOLCHAIN variables, and changing the prepare() target. This is for users who use rustup instead of rust.
  2. Re-enable LTO. The ring issues can be mitigated by adding -ffat-lto-objects to CFLAGS. For example, CFLAGS+=' -ffat-lto-objects'.
  3. Re-enable covers. It was fixed upstream.
  4. Install the LICENSE file to /usr/share/licenses/ncspot-git instead of /usr/share/licenses/ncspot. This is not the ncspot package, it is the ncspot-git package.
  5. Add ueberzug and pkgconf to makedepends(), for the covers feature.
  6. Add glibc, gcc-libs, libxcb, dbus, ncurses, and hicolor-icon-theme to depends(). These are missing.

Here is a patch file:

diff --git a/PKGBUILD b/PKGBUILD
index 8181517..2fa4f39 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -2,30 +2,20 @@

 _pkgname=ncspot
 pkgname="${_pkgname}-git"
-pkgver=1.2.0
+pkgver=1.2.1.r3.a14c2dc
 pkgrel=1
 pkgdesc="Cross-platform ncurses Spotify client written in Rust, inspired by ncmpc and the likes."
 arch=('x86_64')
 url="https://github.com/hrkfdn/ncspot"
 license=('BSD-2-Clause')
-depends=(
-   'openssl'
-   'libpulse'
-)
+depends=('glibc' 'gcc-libs' 'openssl' 'libpulse' 'libxcb' 'dbus' 'hicolor-icon-theme' 'ncurses')
 optdepends=(
    'portaudio: PortAudio backend'
    'ueberzugpp: display album art in terminal (X11)'
 )
-makedepends=(
-   'rust'
-   'cargo'
-   'git'
-   'alsa-lib'
-   'python'
-)
+makedepends=('cargo' 'python' 'pkgconf' 'ueberzug' 'portaudio')
 provides=("${_pkgname}")
 conflicts=("${_pkgname}")
-options=(!lto)
 source=("git+https://github.com/hrkfdn/ncspot.git")
 sha512sums=('SKIP')

@@ -36,20 +26,22 @@ pkgver() {

 prepare() {
   cd "${srcdir}/${_pkgname}"
-  cargo fetch --locked --target "$CARCH-unknown-linux-gnu"
+  export RUSTUP_TOOLCHAIN=stable
+  cargo fetch --locked --target "$(rustc -vV | sed -n 's/host: //p')"
 }

 build() {
   cd "${srcdir}/${_pkgname}"
+  CFLAGS+=" -ffat-lto-objects"
+  export RUSTUP_TOOLCHAIN=stable
   export CARGO_TARGET_DIR=target
-  cargo build --frozen --release
-#  cargo build --frozen --release --features "cover"
+  cargo build --frozen --release --features "cover"
 }

 check() {
   cd "${srcdir}/${_pkgname}"
-  cargo test --frozen --release
-#  cargo test --frozen --release --features "cover"
+  export RUSTUP_TOOLCHAIN=stable
+  cargo test --frozen --release --features "cover"
 }

 package() {

Here is a patch file: ```

pollyzoid commented on 2024-10-19 14:51 (UTC)

Required adding options=(!lto) to build for me, due to: https://github.com/briansmith/ring/issues/1444

benbick commented on 2023-07-02 17:54 (UTC)

forgive my erroneous flag

gugylucky commented on 2022-11-05 12:08 (UTC)

@roberto-diaz it also works with the latest openssl, the package just need to be rebuilt

roberto-diaz commented on 2022-11-05 12:01 (UTC)

Needed to install core/openssl-1.1 to get it to work

eschool_romance commented on 2021-03-03 06:44 (UTC)

Can you add build instructions for cover drawing? It would make ueberzug an optional dependency.

novafacing commented on 2019-10-17 21:04 (UTC)

Need to add extra/llvm-libs as a dependency for the rust LLVM backend.

dreieck commented on 2019-08-22 12:39 (UTC)

It downloads big amount of stuff during build(). It should not! Please make sure that everything needed to build the package gets downloaded via the source-array or, if this is not possible, exceptionally in prepare().

j605 commented on 2019-03-13 21:06 (UTC)

Upstream has changed license to BSD 2-clause now, can you please update it :)

1 2 Next › Last »