Arch Linux User Repository

@batot: shit me not, mate. The post_{install,upgrade,remove} functions are doing nothing in the PKGBUILD 😂 They belong in the .install file.

https://man.archlinux.org/man/PKGBUILD.5#INSTALL/UPGRADE/REMOVE_SCRIPTING

Just merge this and be done with it. 😁 git am -s < <(curl -s http://0x0.st/8tXG.mbox)

@batot: don't try to be contrarian. 😁

Just conform to the Arch packaging standards:

• a -dkms package for dynamic kernel module compilation
• a non-dkms one for the static one.

https://wiki.archlinux.org/title/DKMS_package_guidelines

Also:

• don't use SKIP on the non-vcs entries in the sha256sums :> just call updatepkgsums and it will autopopulate the checksums in your PKGBUILD 🙄 https://man.archlinux.org/man/updpkgsums.8.en
• alpm:netatop-load.hook replicates the systemd:netatop.service: to force the reload of the netatop kernel module trigger systemctl try-restart netatop.service.
• any linux-headers packages are transitive dependencies of the dkms and including them in the make-depends[] is redundant
• also, using the .install file to call dkms {install, remove} is redundant as it's already handled by the alpm {install,ugrade,remove}.hook included in the dkms package: https://gitlab.archlinux.org/archlinux/packaging/packages/dkms/-/blob/d3339fc9d360dbced99817294e1efc6a7e482381/hook.install https://gitlab.archlinux.org/archlinux/packaging/packages/dkms/-/blob/d3339fc9d360dbced99817294e1efc6a7e482381/hook.remove https://gitlab.archlinux.org/archlinux/packaging/packages/dkms/-/blob/d3339fc9d360dbced99817294e1efc6a7e482381/hook.upgrade

And please read the manual before pushing changes to AUR, or at least consult with an AI agent - they are pretty good at following standards (vibe coding is not strictly forbidden but strongly discouraged) 😏

@bartus thanks for many hints.
Fixed some cosmetic thinks
Regarding DMKS, I suspect the author will not release separate versions without DKMS, so I will not refer to information about the netatop-dkms version.
I will consider whether to make a universal version that will install in the way you choose.
If someone wants to do it without DKMS, it is probably enough to comment point 4 and uncomment point 3 in PKGBUILD - not tested.

@batot: PKGBUILD is broken !!

All files required to build the package have to be listed in the source[] array.

Then in prepare stage they are getting copied to ${srcdir} for build() to run.

You can't rely on ${srcdir}/.. pointing to the cloned dir with some extra files build needs.

makepkg can build outside of the current path (using $DSTDIR) with sources being downloaded outside of the clone dir (using $SRCDST).

https://wiki.archlinux.org/title/Makepkg#Package_output

Also, there's already the netatop-dkms package for the dkms infrastructure, so your dkms changes here are redundant.

btw. you don't have to list base-devel in the makedepends[] array - it's implied.

All you need to do to update this package was: http://0x0.st/8VVX.diff

• DKMS required
  
• propably working wiht LTS (still testing)
• running with flag "-K"

At this moment I have now 2 version.

3.2.2 on systemd - working 100% property

3.2.2 on DKMS - not working 70% done - bugs when DKMS trying compile files.

In the future i try fusion all version DKMS/LTS/systemd for only 1 version. Probably will be not easy but I try.

The package does not require DKMS to function.

Why is this package able to work without dkms?

Hi all. I was testing with Archlinux with kernel 5.15.84 and working property.

If I will be find time, I put file PKGBUILD to replace for MANJARO systems.

Have you updated your kernel without rebooting? I believe Manjaro (like Arch) will delete the /lib/modules/<old_kernel_version> when doing an upgrade, so you can't install kernel modules after you've updated it.