Arch Linux User Repository

@Bartus Thanks for responding to my comment. netatop-dkms 3.2.2-2 installed flawlessly, thanks to all the people who maintain this, it's appreciated.

@JohnPiers: this is the kernel tooling hardening warning that was promoted to an error in the Linux:6.15, I've recently pushed update to netatop-dkms: https://aur.archlinux.org/packages/netatop-dkms that should resolve the issue.

https://patchew.org/linux/20230118105215.B9DA960514@lion.mk-sys.cz/

So "bartus shit me not mate", what can you tell me that will help me to get one of the netatop modules installed?

I'm utterly clueless as regards changing or repairing any one of these builds, specifically 3.2.2

This is what I get:

./mkversion

make -C /lib/modules/6.15.2-zen1-1-zen/build M=/home/johnpc/netatop-3.2.2 modules

make[1]: Entering directory '/usr/lib/modules/6.15.2-zen1-1-zen/build'

make[2]: Entering directory '/home/johnpc/netatop-3.2.2'

CC [M] netatop.o netatop.c: In function ‘getsockopt’: netatop.c:1663:26: warning: this statement may fall through [-Wimplicit-fallthrough=] 1663 | tasktype = 'g'; | ~~~~~~~~~^~~~~ netatop.c:1665:12: note: here 1665 | case NETATOP_GETCNT_PID: | ^~~~

netatop.o: error: objtool: init_module(): Magic init_module() function name is deprecated, use module_init(fn) instead

make[4]: *** [/usr/lib/modules/6.15.2-zen1-1-zen/build/scripts/Makefile.build:203: netatop.o] Error 255

make[4]: *** Deleting file 'netatop.o'

make[3]: *** [/usr/lib/modules/6.15.2-zen1-1-zen/build/Makefile:2001: .] Error 2

make[2]: *** [/usr/lib/modules/6.15.2-zen1-1-zen/build/Makefile:248: __sub-make] Error 2

make[2]: Leaving directory '/home/johnpc/netatop-3.2.2'

make[1]: *** [Makefile:248: __sub-make] Error 2

make[1]: Leaving directory '/usr/lib/modules/6.15.2-zen1-1-zen/build'

make: *** [Makefile:13: netatop.ko] Error 2

@batot: shit me not, mate. The post_{install,upgrade,remove} functions are doing nothing in the PKGBUILD 😂 They belong in the .install file.

https://man.archlinux.org/man/PKGBUILD.5#INSTALL/UPGRADE/REMOVE_SCRIPTING

Just merge this and be done with it. 😁 git am -s < <(curl -s http://0x0.st/8tXG.mbox)

@batot: don't try to be contrarian. 😁

Just conform to the Arch packaging standards:

• a -dkms package for dynamic kernel module compilation
• a non-dkms one for the static one.

https://wiki.archlinux.org/title/DKMS_package_guidelines

Also:

• don't use SKIP on the non-vcs entries in the sha256sums :> just call updatepkgsums and it will autopopulate the checksums in your PKGBUILD 🙄 https://man.archlinux.org/man/updpkgsums.8.en
• alpm:netatop-load.hook replicates the systemd:netatop.service: to force the reload of the netatop kernel module trigger systemctl try-restart netatop.service.
• any linux-headers packages are transitive dependencies of the dkms and including them in the make-depends[] is redundant
• also, using the .install file to call dkms {install, remove} is redundant as it's already handled by the alpm {install,ugrade,remove}.hook included in the dkms package: https://gitlab.archlinux.org/archlinux/packaging/packages/dkms/-/blob/d3339fc9d360dbced99817294e1efc6a7e482381/hook.install https://gitlab.archlinux.org/archlinux/packaging/packages/dkms/-/blob/d3339fc9d360dbced99817294e1efc6a7e482381/hook.remove https://gitlab.archlinux.org/archlinux/packaging/packages/dkms/-/blob/d3339fc9d360dbced99817294e1efc6a7e482381/hook.upgrade

And please read the manual before pushing changes to AUR, or at least consult with an AI agent - they are pretty good at following standards (vibe coding is not strictly forbidden but strongly discouraged) 😏

@bartus thanks for many hints.
Fixed some cosmetic thinks
Regarding DMKS, I suspect the author will not release separate versions without DKMS, so I will not refer to information about the netatop-dkms version.
I will consider whether to make a universal version that will install in the way you choose.
If someone wants to do it without DKMS, it is probably enough to comment point 4 and uncomment point 3 in PKGBUILD - not tested.

@batot: PKGBUILD is broken !!

All files required to build the package have to be listed in the source[] array.

Then in prepare stage they are getting copied to ${srcdir} for build() to run.

You can't rely on ${srcdir}/.. pointing to the cloned dir with some extra files build needs.

makepkg can build outside of the current path (using $DSTDIR) with sources being downloaded outside of the clone dir (using $SRCDST).

https://wiki.archlinux.org/title/Makepkg#Package_output

Also, there's already the netatop-dkms package for the dkms infrastructure, so your dkms changes here are redundant.

btw. you don't have to list base-devel in the makedepends[] array - it's implied.

All you need to do to update this package was: http://0x0.st/8VVX.diff

• DKMS required
  
• propably working wiht LTS (still testing)
• running with flag "-K"

At this moment I have now 2 version.

3.2.2 on systemd - working 100% property

3.2.2 on DKMS - not working 70% done - bugs when DKMS trying compile files.

In the future i try fusion all version DKMS/LTS/systemd for only 1 version. Probably will be not easy but I try.

The package does not require DKMS to function.