Package Details: netatop-dkms 3.1-2

Git Clone URL: https://aur.archlinux.org/netatop-dkms.git (read-only, click to copy)
Package Base: netatop-dkms
Description: Atop network kernel module, enables network statistics in atop
Upstream URL: http://www.atoptool.nl/
Keywords: atop dkms kernel module netatop
Licenses: GPL
Groups: modules
Conflicts: netatop
Submitter: m1kc
Maintainer: m1kc
Last Packager: m1kc
Votes: 14
Popularity: 0.040929
First Submitted: 2015-06-02 10:10 (UTC)
Last Updated: 2020-12-24 08:31 (UTC)

Latest Comments

1 2 3 4 5 Next › Last »

m1kc commented on 2022-12-14 09:53 (UTC)

Looks like that's my fault after all. Will fix when I have time.

m1kc commented on 2022-12-14 09:45 (UTC)

@npfeiler This file is not a part of the AUR package source — that's an upstream issue and you should report that to atop authors directly.

npfeiler commented on 2022-12-08 10:07 (UTC)

from the journal
systemd[1]: Configuration file /usr/lib/systemd/system/netatop.service is marked executable. Please remove executable permission bits. Proceeding anyway.

m1kc commented on 2021-01-08 00:02 (UTC)

It's easy to miss that make call builds netatopd as well - it's not optional, and it's not "just a check".

bartus commented on 2021-01-04 18:06 (UTC) (edited on 2021-01-04 18:08 (UTC) by bartus)

@m1kc: hard dependency on linux-headers package has been removed.

I understand how user need a header for every costume kernel for the *-dkms packages to get processed by dkms post install hook, but removing even default linux-headers prevent building the package in clean chroot.

(-‸ლ)

Is there any chance you can just drop all this build() shenanigans or perhaps move make call to check() ? (it only test if package can be build and discards all resulting files).

This wy user can just run pass --nocheck to makechrootpkg to build in clean env. An when installing the package alpm.hook/dkms will build the module for kernels that has installed headers ?

m1kc commented on 2020-12-25 22:16 (UTC)

Thanks a lot for your feedback.

lekin commented on 2020-12-25 09:19 (UTC)

Horrible fomatting; wasn't sure how to use markdown sysntax properly. Sorry about this.

lekin commented on 2020-12-25 09:13 (UTC)

A few suggestions:

modules-load.d (5) Packages should install their configuration files in /usr/lib/ (distribution packages) or /usr/local/lib/ (local installs). Files in /etc/ are reserved for the local administrator, who may use this logic to override the configuration files installed by vendor packages. It is recommended to prefix all filenames with a two-digit number and a dash, to simplify the ordering of the files. modules-load.d isn't needed anymore as service loads netatop module and starts netatopd netatopd (8) - log network statistics of finished processes

Dez 22 19:00:16 <host> systemd[1]: /usr/lib/systemd/system/netatop.service:12: PIDFile= references a path below legacy directory /var/run/, updating /var/run/netatop.pid → /run/netatop.pid; please update the unit file accordingly. The unit file shouldn't contain /sbin

'armv7h' can be added to PKGBUILD: arch=

m1kc commented on 2020-12-24 08:33 (UTC)

Package updated.

It seems to me that netatop.service just loads the netatop module into kernel, and this is already provided by /etc/modules-load.d/netatop.conf. Still, I guess it's okay to follow the upstream on this one.

Remark: Can be compiled and runs fine on armv7h

Glad to hear that. Is there anything else I can do to help the ARM users?

lekin commented on 2020-12-23 16:23 (UTC)

Remark: Can be compiled and runs fine on armv7h